Re: tg3: link is permanently down after ifdown and ifup

2009-11-19 Thread Michael Chan
On Thu, 2009-11-19 at 08:08 -0800, Felix Radensky wrote: Hi, The problem goes away if I remove the call to tg3_set_power_state(tp, PCI_D3hot); from tg3_close(). Added Matt to CC. He is on vacation and may not be able to look into this right away. Thanks.

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Michael Chan
On Fri, 2008-08-08 at 11:43 -0700, Matthew Carlson wrote: Segher is right. The code should be 2.5 milliseconds but is actually much longer. This fix is actually already in my patch queue and needs to be sent upstream. Matt, I think we can optimize this a little more. The heart beat event

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Michael Chan
On Fri, 2008-08-08 at 15:05 -0700, Benjamin Herrenschmidt wrote: On Fri, 2008-08-08 at 11:43 -0700, Matt Carlson wrote: We really shouldn't be displaying any error messages in the event of a timeout though. Earlier versions of the UMP firmware did not support the link update interface.

Re: dead network on JS21 with tg3 driver after flowcontrol changes

2008-05-16 Thread Michael Chan
Olaf Hering wrote: Yes, this patch fixes nfsroot for me. Thanks. mii-tool is not shipped anymore, even in SLES10. I assume that ethtool is the replacement? Thanks. We'll send the patch to DaveM and to stable as well. ethtool can provide some high level link parameters. But in this case, I

Re: dead network on JS21 with tg3 driver after flowcontrol changes

2008-05-15 Thread Michael Chan
Olaf Hering wrote: Any ideas how to fix this? What info do you need from the system? Are you using eth0 or eth1? The dmesg below shows that link came up on eth1 and IP address from DHCP was received. Sending DHCP requests .6tg3: eth1: Link is up at 1000 Mbps, full duplex. tg3: eth1:

Re: dead network on JS21 with tg3 driver after flowcontrol changes

2008-05-15 Thread Michael Chan
On Thu, 2008-05-15 at 17:49 +0200, Olaf Hering wrote: On Thu, May 15, Michael Chan wrote: Olaf Hering wrote: Any ideas how to fix this? What info do you need from the system? Are you using eth0 or eth1? The dmesg below shows that link came up on eth1 and IP address from DHCP

Re: dead network on JS21 with tg3 driver after flowcontrol changes

2008-05-15 Thread Michael Chan
On Thu, 2008-05-15 at 10:15 -0700, Matt Carlson wrote: If you were to start with the original file, does the following patch fix the problem? diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 07b3f77..4c248d7 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -3168,8

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-20 Thread Michael Chan
On Sat, 2007-10-20 at 16:43 +1000, Michael Ellerman wrote: On Fri, 2007-10-19 at 17:53 -0700, David Miller wrote: I don't see this, in all cases write_msi_msg() will transfer the given *msg to entry-msg by this assignment in drivers/pci/msi.c: void write_msi_msg(unsigned int irq,