Re: linux-next: boot failures with next-20120411

2012-04-11 Thread Milton Miller
On Wed, 11 Apr 2012 about 16:58:35 +1000, Stephen Rothwell wrote: Hi all, Some (not all) of my PowerPC boot tests have failed like this after getting into user mode (this one was just after udev started, but others are after other processes getting going): Unable to handle kernel paging

Re: [PATCH 08/18] PCI, powerpc: Register busn_res for root buses

2012-04-02 Thread Milton Miller
[Apollogies if I left anyone off cc. I am not subscribed and the archives go to great pains to hide the to and cc lists, and then truncate it for size] On Tue Feb 28 2012 about 18:42:03 EST, Benjamin Herrenschmidt wrote: On Tue, 2012-02-28 at 16:31 -0700, Bjorn Helgaas wrote: We may need

Re: [PATCH 08/18] PCI, powerpc: Register busn_res for root buses

2012-04-02 Thread Milton Miller
[Apollogies if I left anyone off cc. I am not subscribed and the archives go to great pains to hide the to and cc lists, and then truncate it for size] {fix a comma in cc} On Tue Feb 28 2012 about 18:42:03 EST, Benjamin Herrenschmidt wrote: On Tue, 2012-02-28 at 16:31 -0700, Bjorn Helgaas

Re: [1/2] powerpc/44x: Fix PCI MSI support for APM821xx SoC and Bluestone board

2012-03-05 Thread Milton Miller
On Mon, 05 Mar 2012 about 17:29:41 -, Mai La wrote: @@ -43,7 +43,12 @@ #define PEIH_FLUSH0 0x30 #define PEIH_FLUSH1 0x38 #define PEIH_CNTRST 0x48 + +#ifdef CONFIG_APM821xx +#define NR_MSI_IRQS 8 +#else #define NR_MSI_IRQS 4 +#endif does this need to go into the dts

Re: [PATCH v7] powerpc: Force page alignment for initrd reserved memory

2011-05-26 Thread Milton Miller
, and will move the device tree if it overlaps with the range extension of initrd. This patch will also consolidate the identical function free_initrd_mem() from mm/init_32.c, init_64.c to mm/mem.c, and adds the same range extension when freeing initrd. Many thanks to Milton Miller for his input

Re: [PATCH 6/8] powerpc 8xx: cascade eoi will be performed by generic_handle_irq handler

2011-05-26 Thread Milton Miller
On Thu, 26 May 2011 about 13:32:33 +1000, Benjamin Herrenschmidt wrote: On Wed, 2011-05-25 at 01:34 -0500, Milton Miller wrote: The 8xx cpm_cascade was calling irq_eoi for the cascaded irq, but that will already have been called by the handle_fasteoi_irq that generic_handle_irq

[PATCH 8/8] powerpc: fix irq_free_virt by adjusting bounds before loop

2011-05-25 Thread Milton Miller
unsigned integer overflows. Signed-off-by: Milton Miller milt...@bga.com --- I am not aware of any call sites where the difference matters; I prepared the refactor while continuing work on the irq host extraction and noticed the logic error during the code movement. Index: work.git/arch/powerpc

[PATCH 0/8] ipi and irq cleanups and fixes

2011-05-25 Thread Milton Miller
Here are a few cleanups and fies mostly around the previous series and a few more as I continue to explore exporting the irq_host concept for other architectures. milton ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

[PATCH 3/8] powerpc irq: remove stale and misleading comment

2011-05-25 Thread Milton Miller
The comment claims we will call host-ops-map() to update the flags if we find a previously established mapping, but we never did. We used to call remap, but that call was removed in da05198002 (powerpc: Remove irq_host_ops-remap hook). Signed-off-by: Milton Miller milt...@bga.com Index

[PATCH 5/8] powerpc: check desc in handle_one_irq and expand generic_handle_irq

2011-05-25 Thread Milton Miller
to allow its use by interrupt controllers in modules. However, handle_one_irq is core arch code. It already knows the details of struct irq_desc and handling irqs in the nested irq case. This will avoid the extra stack frame to return the value we don't check. Signed-off-by: Milton Miller milt

[PATCH 6/8] powerpc 8xx: cascade eoi will be performed by generic_handle_irq handler

2011-05-25 Thread Milton Miller
The 8xx cpm_cascade was calling irq_eoi for the cascaded irq, but that will already have been called by the handle_fasteoi_irq that generic_handle_irq will call. The handler is set in arch/powerpc/sysdev/cpm1.c by the host map routine. Signed-off-by: Milton Miller milt...@bga.com Index

[PATCH 4/8] powerpc irq: always free duplicate IRQ_LEGACY hosts

2011-05-25 Thread Milton Miller
Since kmem caches are allocated before init_IRQ as noted in 3af259d155 (powerpc: Radix trees are available before init_IRQ), we now call kmalloc in all cases and can can always call kfree if we are asked to allocate a duplicate or conflicting IRQ_HOST_MAP_LEGACY host. Signed-off-by: Milton Miller

[PATCH 2/8] powerpc cell: rename ipi functions to match current abstractions

2011-05-25 Thread Milton Miller
from ipi to message. Also make it clear that iic_request_ipi takes a message number as the argument for which ipi to create and request. No functionional change, just renames to avoid future confusion. Signed-off-by: Milton Miller milt...@bga.com Index: work.git/arch/powerpc/platforms/cell

[PATCH 7/8] powerpc irq: protect irq_radix_revmap_lookup against irq_free_virt

2011-05-25 Thread Milton Miller
and decrement. This does not show up in the rcu lockdep because in 2.6.34 commit 2676a58c98 (radix-tree: Disable RCU lockdep checking in radix tree) deemed it too hard to pass the condition of the protecting lock to the library. Signed-off-by: Milton Miller milt...@bga.com Index: work.git/arch/powerpc/kernel

Re: [v5] powerpc: Force page alignment for initrd reserved memory

2011-05-25 Thread Milton Miller
the same range extension when freeing initrd. It will also move the device tree if it overlaps with the reserved memory for initrd. Many thanks to Milton Miller for his input on this patch. Signed-off-by: Dave Carroll dcarr...@astekcorp.com --- * This patch is based on Linus' current

RE: [ v4] powerpc: Force page alignment for initrd reserved memory

2011-05-23 Thread Milton Miller
On Mon, 23 May 2011 about 10:50:07 -0600, Dave Carroll wrote: I'm withdrawing this patch for the moment, due to two areas that need further research; 1) An adjacent FDT blob, as mentioned by Milton Miller, and Ok ... by the way, see move_device_tree() in arch/powerpc/kernel/prom.c 2

Re: [PATCH v3] powerpc: Force page alignment for initrd reserved memory

2011-05-22 Thread 'Milton Miller'
On Sat, 21 May 2011 about 11:05:27 -0600, Dave Carroll wrote: When using 64K pages with a separate cpio rootfs, U-Boot will align the rootfs on a 4K page boundary. When the memory is reserved, and subsequent early memblock_alloc is called, it will allocate memory between the 64K page

Re: [v2] powerpc: Force page alignment for initrd

2011-05-21 Thread Milton Miller
On Fri, 20 May 2011 about 13:23:36 -, Dave Carroll wrote: When using 64K pages with a separate cpio rootfs, U-Boot will align the rootfs on a 4K page boundary. When the memory is reserved, and subsequent early memblock_alloc is called, it will allocate memory between the 64K page alignment

Re: powerpc: mpc85xx regression since 2.6.39-rc2, one cpu core lame

2011-05-18 Thread Milton Miller
Does this patch help? If so please reply to that thread so patchwork will see it in addition to here. http://patchwork.ozlabs.org/patch/96146/ milton ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

RE: [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq is not atomic

2011-05-18 Thread Milton Miller
On Wed, 18 May 2011 about 09:35:56 -0600, Eric Moore wrote: On Wednesday, May 18, 2011 2:24 AM, Milton Miller wrote: On Wed, 18 May 2011 around 17:00:10 +1000, Benjamin Herrenschmidt wrote: (Just adding Milton to the CC list, he suspects races in the driver instead). On Wed, 2011-05

Re: [PATCH 7/8] powerpc: use the newly added get_required_mask dma_map_ops hook

2011-05-12 Thread Milton Miller
On Thu, May 12, 2011 at 00:25, Nishanth Aravamudan n...@us.ibm.com wrote: diff --git a/arch/powerpc/platforms/ps3/system-bus.c b/arch/powerpc/platforms/ps3/system-bus.c index 23083c3..688141c 100644 --- a/arch/powerpc/platforms/ps3/system-bus.c +++

Re: powerpc: Make early memory scan more resilient to out of order nodes

2011-05-12 Thread Milton Miller
first_memblock_size; __initdata (its only referenced by 2 __init functions) Acked-by: Milton Miller milt...@bga.com static int __init early_parse_mem(char *p) { .. @@ -507,11 +508,14 @@ void __init early_init_dt_add_memory_arch(u64 base, u64 size) .. @@ -708,6 +712,7 @@ void __init early_init_devtree

Re: [PATCH 37/37] powerpc: make IRQ_NOREQUEST last to clear, first to set

2011-05-12 Thread Milton Miller
On Wed, 11 May 2011 about 21:18:11 +0200, Grant Likely wrote: On Wed, May 11, 2011 at 7:30 AM, Milton Miller milt...@bga.com wrote: When allocating irqs, wait to clear the IRQ_NOREQUEST flag until the host map hook has been called. When freeing irqs, set the IRQ_NOREQUEST flag before

[PATCH] seqlock: don't smp_rmb in seqlock reader spin loop

2011-05-12 Thread Milton Miller
: sta...@vger.kernel.org Signed-off-by: Milton Miller milt...@bga.com --- To the readers of [RFC] time: xtime_lock is held too long: I initially thought x86 would not see this because rmb would be a nop, but upon closer inspection X86_PPRO_FENCE will add a lfence for rmb. milton Index: common

[tip:core/locking] seqlock: Don't smp_rmb in seqlock reader spin loop

2011-05-12 Thread tip-bot for Milton Miller
Commit-ID: 5db1256a5131d3b133946fa02ac9770a784e6eb2 Gitweb: http://git.kernel.org/tip/5db1256a5131d3b133946fa02ac9770a784e6eb2 Author: Milton Miller milt...@bga.com AuthorDate: Thu, 12 May 2011 04:13:54 -0500 Committer: Thomas Gleixner t...@linutronix.de CommitDate: Thu, 12 May 2011 12

[PATCH 01/37] powerpc: fix memory corruption from unallocated slaves

2011-05-11 Thread Milton Miller
-by: Milton Miller milt...@bga.com Cc: sta...@kernel.org # (1fc711f was backported to 2.6.32) --- arch/powerpc/kernel/misc_64.S | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/misc_64.S b/arch/powerpc/kernel/misc_64.S index 206a321..e89df59

[PATCH 03/37] powerpc/kdump64: Don't reference freed memory as pacas

2011-05-11 Thread Milton Miller
) the number of pacas allocated is always nr_cpu_ids. Signed-off-by: Milton Miller milt...@bga.com Cc: sta...@kernel.org # .34.x --- This is the simplest fix, and quite sutiable for stable. We can merge the crash waits with the normal kexec waits later, and fix the hole described in the other version

[PATCH 33/37] powerpc: spider-pic: get pic from chip_data instead of irq_map

2011-05-11 Thread Milton Miller
Building on Grant's efforts to remove the irq_map array, this patch moves spider-pics use of virq_to_host() to use irq_data_get_chip_data and sets the irq chip data in the map call, like most other interrupt controllers in powerpc. Signed-off-by: Milton Miller milt...@bga.com --- --- arch

[PATCH 34/37] powerpc: axon_msi: validate msi irq via chip_data

2011-05-11 Thread Milton Miller
Instead of checking for rogue msi numbers via the irq_map host field set the chip_data to h.host_data (which is the msic struct pointer) at map and compare it in get_irq. Signed-off-by: Milton Miller milt...@bga.com --- --- arch/powerpc/platforms/cell/axon_msi.c |3 ++- 1 files changed, 2

[PATCH 37/37] powerpc: make IRQ_NOREQUEST last to clear, first to set

2011-05-11 Thread Milton Miller
When allocating irqs, wait to clear the IRQ_NOREQUEST flag until the host map hook has been called. When freeing irqs, set the IRQ_NOREQUEST flag before calling the host unmap hook. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/kernel/irq.c | 14 +++--- 1 files changed

[PATCH 35/37] powerpc: add virq_is_host to reduce virq_to_host usage

2011-05-11 Thread Milton Miller
-by: Milton Miller milt...@bga.com --- arch/powerpc/include/asm/irq.h |1 + arch/powerpc/kernel/irq.c |6 ++ arch/powerpc/sysdev/xics/xics-common.c |2 +- 3 files changed, 8 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/include/asm/irq.h b/arch/powerpc/include

[PATCH 06/37] powerpc: use nr_cpu_ids in initial paca allocation

2011-05-11 Thread Milton Miller
Now that we never set a cpu above nr_cpu_ids possible we can limit our initial paca allocation to nr_cpu_ids. We can then clamp the number of cpus in platforms/iseries/setup.c. Signed-off-by: Milton Miller milt...@bga.com --- --- arch/powerpc/kernel/paca.c | 17

[PATCH 05/37] powerpc: Respect nr_cpu_ids when calling set_cpu_possible and set_cpu_present

2011-05-11 Thread Milton Miller
-off-by: Milton Miller milt...@bga.com --- Probably-not-worth-Cc: stable (2.6.34 and up) --- arch/powerpc/kernel/setup-common.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c index 1475df6

[PATCH 30/37] powerpc: mpc62xx_pic: fix get_irq handling of NO_IRQ

2011-05-11 Thread Milton Miller
and only then return NO_IRQ. If no status bit is set, then we should return NO_IRQ directly. The interrupt should not be suppressed from spurious counting, in fact that is the definition of supurious. Signed-off-by: Milton Miller milt...@bga.com --- --- arch/powerpc/platforms/52xx/mpc52xx_pic.c

[PATCH 29/37] powerpc: mpc5121_ads_cpld: remove use of NO_IRQ_IGNORE

2011-05-11 Thread Milton Miller
-by: Milton Miller milt...@bga.com --- --- arch/powerpc/platforms/512x/mpc5121_ads_cpld.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c b/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c index a8bc0d4..9f09319 100644 --- a/arch

[PATCH 04/37] powerpc/iseries: cleanup and fix secondary startup

2011-05-11 Thread Milton Miller
loops. Move all sync instructions from the loops to the forward progress path. Wait to load current_set until paca is set to go. Move the iseries_secondary_smp_loop label to cover the whole spin loop. Add HMT_MEDIUM when we make forward progress. Signed-off-by: Milton Miller milt...@bga.com

[PATCH 28/37] powerpc: fsl_msi: use chip_data not handler_data

2011-05-11 Thread Milton Miller
). Signed-off-by: Milton Miller milt...@bga.com --- --- arch/powerpc/sysdev/fsl_msi.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c index 06c..067cc88 100644 --- a/arch/powerpc/sysdev/fsl_msi.c +++ b/arch

[PATCH 27/37] powerpc fsl_msi: don't abuse platform_data for driver_data

2011-05-11 Thread Milton Miller
not the platform device driver. It is generally not needed for drivers that only support systems with device trees. Signed-off-by: Milton Miller milt...@bga.com --- --- arch/powerpc/sysdev/fsl_msi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev

[PATCH 31/37] powerpc: psurge: create a irq_host for secondary cpus

2011-05-11 Thread Milton Miller
of NO_IRQ_IGNORE, records the ipi stats for the secondary cpus, and runs the ipi on the interrupt stack. Signed-off-by: Milton Miller milt...@bga.com --- --- arch/powerpc/platforms/powermac/pic.c |9 ++ arch/powerpc/platforms/powermac/pmac.h |1 + arch/powerpc/platforms/powermac/smp.c

[PATCH 32/37] powerpc: remove irq_host_ops-remap hook

2011-05-11 Thread Milton Miller
the requirements of irq_domain concept. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/include/asm/irq.h |3 --- arch/powerpc/kernel/irq.c|2 -- arch/powerpc/platforms/cell/beat_interrupt.c | 11 --- 3 files changed, 0 insertions

[PATCH 26/37] powerpc: remove i8259 irq_host_ops-unmap

2011-05-11 Thread Milton Miller
to call unmap on a legacy irq. Signed-off-by: Milton Miller milt...@bga.com --- --- arch/powerpc/sysdev/i8259.c | 13 - 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/arch/powerpc/sysdev/i8259.c b/arch/powerpc/sysdev/i8259.c index 142770c..d18bb27 100644 --- a/arch/powerpc

[PATCH 25/37] powerpc: remove trival irq_host_ops.unmap

2011-05-11 Thread Milton Miller
These all just clear chip or chipdata fields, which will be done by the generic code when we call irq_free_descs. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/platforms/82xx/pq2ads-pci-pic.c |8 arch/powerpc/platforms/embedded6xx/flipper-pic.c |7

[PATCH 24/37] powerpc: return early if irq_host lookup type is wrong

2011-05-11 Thread Milton Miller
-off-by: Milton Miller milt...@bga.com --- arch/powerpc/kernel/irq.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c index f42e869..4a5aa8c 100644 --- a/arch/powerpc/kernel/irq.c +++ b/arch/powerpc/kernel

[PATCH 21/37] powerpc: use bytes instead of bitops in smp ipi multiplexing

2011-05-11 Thread Milton Miller
optimises for the expected single iteration of the loop. We have a full mb() at the beginning to cover ordering between send, ipi, and receive so we can use xchg_local and forgo the further acquire and release barriers of xchg. Signed-off-by: Milton Miller milt...@bga.com --- v4: cast int to char ptr

[PATCH 23/37] powerpc: radix trees are available before init_IRQ

2011-05-11 Thread Milton Miller
to use zalloc_maybe_bootmem. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/kernel/irq.c | 78 ++-- 1 files changed, 4 insertions(+), 74 deletions(-) diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c index 826552c..f42e869

[PATCH 22/37] powerpc: xics: cleanup xics_host_map and ipi

2011-05-11 Thread Milton Miller
Since we already have a special case in map to set the ipi handler, use the desired flow. If we don't find an ics to handle the interrupt complain instead of returning 0 without having set a chip or handler. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/sysdev/xics/xics-common.c

[PATCH 36/37] powerpc: remove virq_to_host

2011-05-11 Thread Milton Miller
The only references to the irq_map[].host field are internal to arch/powerpc/kernel/irq.c Signed-off-by: Milton Miller milt...@bga.com --- --- arch/powerpc/include/asm/irq.h |1 - arch/powerpc/kernel/irq.c |6 -- 2 files changed, 0 insertions(+), 7 deletions(-) diff --git

[PATCH 20/37] powerpc: add kconfig for muxed smp ipi support

2011-05-11 Thread Milton Miller
unresolved symbol at link. This also creates a new config for power surge powermac upgrade support that can be disabled in expert mode but is default on. I also removed the depends / default y on CONFIG_XICS since it is selected by PSERIES. Signed-off-by: Milton Miller milt...@bga.com --- I kept

[PATCH 18/37] powerpc: move smp_ops_t from machdep.h to smp.h

2011-05-11 Thread Milton Miller
I can't see any reason these functions are needed by machdep.h and they are all hidden by CONFIG_SMP with no UP alternative. Also move the declarations for the fallback timebase ops, which are used to fill in the smp ops. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/include/asm

[PATCH 19/37] powerpc: consolidate ipi message mux and demux

2011-05-11 Thread Milton Miller
to not realize it is running in interrupt context. Add the missing calls. Signed-off-by: Milton Miller milt...@bga.com --- This requires patch 3780 be applied first for cell to compile. --- arch/powerpc/include/asm/dbell.h |3 +- arch/powerpc/include/asm/smp.h | 14

[PATCH 16/37] powerpc: remove stubbed beat smp support

2011-05-11 Thread Milton Miller
are empty functions, and the top of file comment says Incomplete. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/platforms/cell/Makefile |1 - arch/powerpc/platforms/cell/beat_interrupt.c | 16 arch/powerpc/platforms/cell/beat_interrupt.h |3 - arch/powerpc

[PATCH 15/37] powerpc: remove alloc_maybe_bootmem for zalloc version

2011-05-11 Thread Milton Miller
pointers on error paths. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/include/asm/system.h|2 -- arch/powerpc/kernel/pci_dn.c |3 +-- arch/powerpc/lib/alloc.c |8 arch/powerpc/platforms/cell/celleb_pci.c |6 +++--- 4

[PATCH 14/37] powerpc: remove powermac/pic.h

2011-05-11 Thread Milton Miller
Its unused, and of the three declarations, one is duplicated in pmac.h, the second is static and the third is renamed and static. Signed-off-by: Milton Miller milt...@bga.com --- --- arch/powerpc/platforms/powermac/pic.h | 11 --- 1 files changed, 0 insertions(+), 11 deletions

[PATCH 13/37] powerpc/mpic: simplify ipi cpu mask handling

2011-05-11 Thread Milton Miller
Now that MSG_ALL and MSG_ALL_BUT_SELF have been eliminated, smp_mpic_mesage_pass no longer needs to lookup the cpumask just to have mpic_send_ipi extract part of it and recode it in a NR_CPUS loop by mpic_physmask. Signed-off-by: Milton Miller milt...@bga.com --- I chose stepwise refinement

[PATCH 12/37] linux/smp.h: remove unused MSG_ flags

2011-05-11 Thread Milton Miller
Now that powerpc has removed its use of MSG_ALL_BUT_SELF and MSG_ALL all these MSG_ flags are unused. Signed-off-by: Milton Miller milt...@bga.com --- To be merged by powerpc with the series posted to linuxppc-dev After the previous 2 patches, grep shows the following false hits (from partial

[PATCH 11/37] powerpc: remove checks for MSG_ALL and MSG_ALL_BUT_SELF

2011-05-11 Thread Milton Miller
Now that smp_ops-smp_message_pass is always called with an (online) cpu number for the target remove the checks for MSG_ALL and MSG_ALL_BUT_SELF. Signed-off-by: Milton Miller milt...@bga.com --- rediffed for ppc-next xics split --- arch/powerpc/include/asm/dbell.h |2 +- arch/powerpc

[PATCH 10/37] powerpc: remove call sites of MSG_ALL_BUT_SELF

2011-05-11 Thread Milton Miller
and the additional warning it not useful were it to trigger. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/include/asm/smp.h |2 +- arch/powerpc/kernel/kgdb.c |2 +- arch/powerpc/kernel/smp.c | 19 +-- arch/powerpc/xmon/xmon.c |2 +- 4

[PATCH 09/37] powerpc: mpic: break cpumask abstraction earlier

2011-05-11 Thread Milton Miller
with the bits of cpu_online_mask. Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/sysdev/mpic.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c index a93da80..116695b 100644 --- a/arch/powerpc

[PATCH 08/37] powerpc: mpic: limit NR_CPUS loop to 32 bit

2011-05-11 Thread Milton Miller
mpic_physmask was looping NR_CPUS times over a mask that was passed as a u32. Since mpic is architecturaly limited to 32 physical cpus, clamp the logical cpus to 32 when compiling (we could also clamp at runtime to nr_cpu_ids). Signed-off-by: Milton Miller milt...@bga.com --- arch/powerpc/sysdev

[PATCH 07/37] powerpc: call no-longer static setup_nr_cpu_ids instead of replicating it

2011-05-11 Thread Milton Miller
in include/linux/smp.h, so we can call it instead of replicating it. Signed-off-by: Milton Miller milt...@bga.com --- I found this cleanup while c1854e was being merged, but saved it from the end to ease backporting. --- arch/powerpc/kernel/setup-common.c |2 +- 1 files changed, 1 insertions

[PATCH 00/37] fix paca memory usage and NR_CPU loops, factor ipi and simplify irq code

2011-05-11 Thread Milton Miller
This series represents a somewhat ordered, somewhat meandering series development series of patches I've been working on for the past few weeks. It starts with memory corruption fixes that need to go back to stable relating to slave cpu searches and paca allocation. After refactoring and taking

[PATCH 17/37] powerpc cell: use smp_request_message_ipi

2011-05-11 Thread Milton Miller
This is a request to merge patchwork id 3780 with the same subject. I believe it was marked changes requested because it depended on a patch that had requested changes, but those were resolved and this one got overlooked. The next patch will remove smp_msg_recv. thanks, milton Here is the

[PATCH 02/37] powerpc: don't search for paca in freed memory

2011-05-11 Thread Milton Miller
-by: Milton Miller milt...@bga.com --- arch/powerpc/kernel/head_64.S | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S index 73d6e9a..ba50409 100644 --- a/arch/powerpc/kernel/head_64.S +++ b/arch/powerpc

Re: [RFC] powerpc: respect how command line nr_cpus is set

2011-05-11 Thread Milton Miller
On Wed, 04 May 2011 around 10:17:37 -, Kumar Gala wrote: We should utilize nr_cpus as the max # of CPUs that we can have present instead of NR_CPUS. This way we actually respect how nr_cpus is set on the command line rather than ignoring it. Signed-off-by: Kumar Gala

Re: hvc_console: Don't access hvc_task if not initialised

2011-03-28 Thread Milton Miller
On Fri, 25 Mar 2011 about 14:17:14 +0530, Amit Shah wrote: On (Thu) 24 Mar 2011 [08:58:04], Milton Miller wrote: On Thu, 24 Mar 2011 07:29:58 -, Amit Shah wrote: hvc_open() can be called without having any backing device. This results in a call to hvc_kick() which calls

Re: hvc_console: Don't access hvc_task if not initialised

2011-03-24 Thread Milton Miller
[removed stable list from discussion] On Thu, 24 Mar 2011 07:29:58 -, Amit Shah wrote: hvc_open() can be called without having any backing device. This results in a call to hvc_kick() which calls wake_up_process on a NULL pointer. How is hvc_open called without a hvc_driver registered

[PATCH 0/3] xics mask_irq fix and other patches

2011-03-21 Thread Milton Miller
TO: buyt...@secretlab.ca DATA From: Milton Miller milt...@bga.com Subject: [PATCH 1/2] powerpc: xics: fix numberspace mismatch from irq_desc conversion To: linuxppc-dev@lists.ozlabs.org Cc: Lennert Buytenhek buyt...@secretlab.ca Message-id: xics-mask-irq-desc-...@mdm.bga.com In-Reply-To: patches-for-39

[PATCH] powerpc: pseries/smp: query-cpu-stopped-state support won't change

2011-03-21 Thread Milton Miller
If a given firmware doesn't have a token to support query-cpu-stopped-state, its not likely to change during the lifetime of the kernel. Only print this information once, not once per secondary thread. While here, make the line wrap grep friendly. Signed-off-by: Milton Miller milt...@bga.com

[PATCH 2/2] powerpc: xics: use hwirq for xics domain irq number

2011-03-21 Thread Milton Miller
To try to avoid future confusion, rename irq to hwirq when it refers to a xics domain number instead of a linux irq number. Signed-off-by: Milton Miller milt...@bga.com Index: next.git/arch/powerpc/platforms/pseries/xics.c

[PATCH 1/2] powerpc: xics: fix numberspace mismatch from irq_desc conversion

2011-03-21 Thread Milton Miller
an irq source for which we have no linux irq allocated, and thefore we can not have an irq_desc allocated. Revert xics_mask_real_irq to its prior version, naming the argument hwirq to highlight the difference. Signed-off-by: Milton Miller milt...@bga.com -- Lennert can you please review the other

Re: [v4] ppc44x:PHY fixup for USB on canyonlands board

2010-11-30 Thread Milton Miller
I prepared these comments for v1, but aparently forgot to send them, so I'll do so now. On Mon, 29 Nov 2010 about 03:13:01 -, Rupjyoti Sarmah wrote: This fix is a reset for USB PHY that requires some amount of time for power to be stable on Canyonlands. Signed-off-by: Rupjyoti Sarmah

Re: [PATCH] powerpc: fix call to subpage_protection()

2010-11-30 Thread Milton Miller
a NULL fill pointer like init/initramfs.c. Maybe this debugging patch (against 2.6.35, applys with small offset to 2.6.37-rc4) can help isolate the corruption? From: Milton Miller miltonm.bga.com initramfs: show input and output offsets on unpacking failures When the initramfs input is corrupted

Re: [PATCH] powerpc: fix call to subpage_protection()

2010-11-30 Thread Milton Miller
a negative count, which would inlclude a NULL fill pointer like init/initramfs.c. Maybe this debugging patch (against 2.6.35, applys with small offset to 2.6.37-rc4) can help isolate the corruption? From: Milton Miller miltonm.bga.com initramfs: show input and output offsets on unpacking failures When

Re: Corrected data type mismatch

2010-11-16 Thread Milton Miller
[added cc's based on from ff10b88b5a05c8f1646dd15fb9f6093c1384ff6d, which added the patched line ] https://patchwork.kernel.org/patch/323022/ On Sun, 14 Nov 2010 around 02:06:59 -, Hai Shan wrote: Corrected data type mismatch This merely hides the type mismatch by force casting it.

Re: [Call Trace: 2.6.37-rc1-git7 2.6.37-rc1-git8, Powerpc] LTPmsgctl11 test case

2010-11-12 Thread Milton Miller
[guessing partial cc list, not subscribed] On Thu Nov 11 2010 around 02:03:45 EST, Andrew Morton wrote: On Thu, 11 Nov 2010 12:03:39 +0530 Subrata Modak subr...@xx wrote: Hi Peter/Ingo, LTP__ msgctl11 test case creates Call trace and Exception for kernels

Re: [Patch v2] kexec: increase max of kexec segments and use dynamic allocation

2010-07-27 Thread Milton Miller
[ Added kexec at lists.infradead.org and linuxppc-dev@lists.ozlabs.org ] Currently KEXEC_SEGMENT_MAX is only 16 which is too small for machine with many memory ranges. When hibernate on a machine with disjoint memory we do need one segment for each memory region. Increase this hard limit to

Re: [PPC64/Power7 - 2.6.35-rc5] Bad relocation warnings whileBuilding a CONFIG_RELOCATABLE kernel with CONFIG_ISERIES enabled

2010-07-20 Thread Milton Miller
On Mon, 19 Jul 2010 about 14:00:56 +0200, Alexander Graf wrote: Milton Miller wrote: I wrote: On Mon Jul 19 2010 at about 03:36:51 EST, Alexander Graf wrote: On 19.07.2010, at 03:11, Benjamin Herrenschmidt wrote: On Thu, 2010-07-15 at 17:05 +0530, Subrata Modak wrote

Re: [PPC64/Power7 - 2.6.35-rc5] Bad relocation warnings whileBuilding a CONFIG_RELOCATABLE kernel with CONFIG_ISERIES enabled

2010-07-19 Thread Milton Miller
On Mon Jul 19 2010 at about 03:36:51 EST, Alexander Graf wrote: On 19.07.2010, at 03:11, Benjamin Herrenschmidt wrote: On Thu, 2010-07-15 at 17:05 +0530, Subrata Modak wrote: commit e62cee42e66dcca83aae02748535f62e0f564a0c solved the problem for 2.6.34-rc6. However some other bad

Re: [PPC64/Power7 - 2.6.35-rc5] Bad relocation warnings whileBuilding a CONFIG_RELOCATABLE kernel with CONFIG_ISERIES enabled

2010-07-19 Thread Milton Miller
I wrote: On Mon Jul 19 2010 at about 03:36:51 EST, Alexander Graf wrote: On 19.07.2010, at 03:11, Benjamin Herrenschmidt wrote: On Thu, 2010-07-15 at 17:05 +0530, Subrata Modak wrote: commit e62cee42e66dcca83aae02748535f62e0f564a0c solved the problem for 2.6.34-rc6. However some

Re: [PATCH 1/2] Remove REDWOOD_[456] config options and conditional code

2010-07-16 Thread Milton Miller
On Fri, 16 Jul 2010 at about 08:20:55 -0600 Josh Boyer wrote: On Fri, Jul 16, 2010 at 02:29:02PM +0200, Christian Dietrich wrote: The config options for REDWOOD_[456] were commented out in the powerpc Kconfig. The ifdefs referencing this options therefore are dead and all references to

Re: [5/5] Remove REDWOOD_5 and REDWOOD_6 config options and conditional code

2010-07-15 Thread Milton Miller
On Wed, 14 Jul 2010 about 04:05:05 -, Christian Dietrich wrote: The config options for REDWOOD_[56] were commented out in the powerpc Kconfig. The ifdefs referencing this options therefore are dead and all references to this can be removed (Also dependencies in other KConfig files).

Re: arch/powerpc/lib/copy_32.S: Use alternate memcpy for MPC512x and MPC52xx

2010-07-11 Thread Milton Miller
Steve wrote: These processors will corrupt data if accessing the local bus with unaligned addresses. This version fixes the typical case of copying from Flash on the local bus by keeping the source address always aligned. As Dave said in May of 2008[1], the map driver is advertising xip

Re: [RT,RFC] Hacks allowing -rt to run on POWER7 / Powerpc.

2010-07-11 Thread Milton Miller
On Fri, 09 Jul 2010 about 08:55:01 -, Will Schmidt wrote: We've been seeing some issues with userspace randomly SIGSEGV'ing while running the -RT kernels on POWER7 based systems. After lots of debugging, head scratching, and experimental changes to the code, the problem has been

Re: [1/2] powerpc/crashdump: Fix issues with kexec and 36bit physical addr

2010-07-08 Thread Milton Miller
On Wed, 07 Jul 2010 around 10:51:20 - Matthew McClintock wrote: Fix sizes of variables so correct values are exported via /proc. Cast variable in comparison to avoid compiler error. Signed-off-by: Matthew McClintock m...@freescale.com - csize = min(csize, PAGE_SIZE); +

Re: [1/2] powerpc/crashdump: Fix issues with kexec and 36bit physical addr

2010-07-08 Thread Milton Miller
On Thu, 08 Jul 2010 around 09:27:15 -0500 Matthew McClintock wrote: On Thu, 2010-07-08 at 04:07 -0500, Milton Miller wrote: On Wed, 07 Jul 2010 around 10:51:20 - Matthew McClintock wrote: ... Fix sizes of variables so correct values are exported via /proc. Cast variable in comparison

Re: of-flash: Unable to ioremap() both 128MB NOR flashes on 32-bit system with 2GB+ RAM

2010-06-28 Thread Milton Miller
On Fri Jun 25 around 14:01:51 EST 2010 Kyle Moffett wrote: Oops... put the old linuxppc list on the CC, sorry! On Thu, Jun 24, 2010 at 23:45, Kyle Moffett kyle at moffetthome.net wrote: Hello, I've got a new P2020 (32bit mpc85xx family) board I'm working on a port for that includes 2

[PATCH] powerpc: rtas_flash needs to use rtas_data_buf

2010-06-11 Thread Milton Miller
-Off-By: Milton Miller milt...@bga.com --- not even compile tested, but at least code to backup the complaint --- a/arch/powerpc/kernel/rtas_flash.c.orig 2010-06-11 01:56:26.658583560 + +++ a/arch/powerpc/kernel/rtas_flash.c 2010-06-11 02:43:37.244966477 + @@ -93,12 +93,8 @@ struct

Re: [PATCH] powerpc: rtas_flash cannot be a module

2010-06-11 Thread Milton Miller
On Wed, 9 Jun 2010 at about 16:01:10 +1000 Anton Blanchard wrote: When trying to flash a machine via the update_flash command, I received the following error: Restarting system. FLASH: kernel bug...flash list header addr above 4GB The code in question has a comment that the

Re: [PATCH 00/12] treewide: Remove unnecessary kmalloc casts

2010-06-09 Thread Milton Miller
On Mon Jun 07 2010 at around 23:53:18 EST, Joe Perches wrote: Trivial cleanups arch/cris: Remove unnecessary kmalloc casts arch/powerpc: Remove unnecessary kmalloc casts arch/x86/kernel/tlb_uv.c: Remove unnecessary kmalloc casts drivers/gpu/drm: Remove unnecessary kmalloc casts

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-21 Thread Milton Miller
On Thu, 20 May 2010 at 10:21:36 +0200 (CEST) Thomas Gleixner wrote: On Thu, 20 May 2010, Michael Ellerman wrote: On Wed, 2010-05-19 at 16:38 +0200, Thomas Gleixner wrote: On Wed, 19 May 2010, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-21 Thread Milton Miller
On Thu May 20 at 11:28:36 EST in 2010, Michael Ellerman wrote: On Wed, 2010-05-19 at 07:16 -0700, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY

[RFC PATCH] powerpc: Emulate most load and store instructions in emulate_step()

2010-05-21 Thread Milton Miller
[resending to hit the list] + if (regs-gpr[0] == 0x1ebe + cpu_has_feature(CPU_FTR_REAL_LE)) { + regs-msr ^= MSR_LE; + goto instr_done; + } regs-gpr[9] = regs-gpr[13]; + regs-gpr[10]

Re: [PATCH] Do not inline putprops function

2009-08-10 Thread Milton Miller
On Thu Aug 6 at about 02:49:38 EST in 2009, M. Mohan Kumar wrote: When I align the dtstruct variable to 8 bytes, I am able to invoke kdump. When the line static unsigned dtstruct[TREEWORDS], *dt; changed to static unsigned dtstruct[TREEWORDS] __attribute__ ((aligned (8))),

Re: Maple PPC970 kexec crash-dump problems

2009-02-06 Thread Milton Miller
added to the linear map -- except it should be mapped cache inhibited so that may not work either. Basically, I am trying to figure out if I patched the tool correctly. Thanks, Ben On Sat, Jan 24, 2009 at 2:52 AM, Milton Miller milt...@bga.com wrote: On Sat Jan 24 at 07:59:47 EST in 2009

Re: [PATCH] powerpc: use common cpu_die

2009-02-06 Thread Milton Miller
On Feb 3, 2009, at 10:07 PM, Benjamin Herrenschmidt wrote: --- work.git.orig/arch/powerpc/platforms/powermac/setup.c-static void pmac_cpu_die(void) +static void pmac64_cpu_die(void) ... --- work.git.orig/arch/powerpc/platforms/powermac/smp.c 2009-01-05 02:09:08.0 -0600 -void

Re: Maple PPC970 kexec crash-dump problems

2009-01-23 Thread Milton Miller
On Sat Jan 24 at 07:59:47 EST in 2009, Benjamin Walsh wrote: I am trying to use kexec with a crash dump kernel on a Maple board (Motorola ATCA6101 to be precise). This board is running a two-CPU PPC970FX. I am running a 2.6.27-10 kernel and have tried both older kexec-tools and the newest

Re: Re[2]: [PATCH][v4] powerpc 44x: support for 256KB PAGE_SIZE

2009-01-17 Thread Milton Miller
On Jan 16, 2009, at 9:18 AM, Yuri Tikhonov wrote: On Friday, January 16, 2009 you wrote: On Jan 12, 2009, at 4:49 PM, Yuri Tikhonov wrote: This patch adds support for 256KB pages on ppc44x-based boards. +config STDBINUTILS + bool Using standard binutils settings + depends on 44x

Re: [PATCH][v4] powerpc 44x: support for 256KB PAGE_SIZE

2009-01-16 Thread Milton Miller
On Jan 12, 2009, at 4:49 PM, Yuri Tikhonov wrote: This patch adds support for 256KB pages on ppc44x-based boards. Another day, another comment. The motivation for reply was the second comment below. diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 84b8613..18f33ef 100644

Re: [PATCH 0/5 + 2] kexec updates

2009-01-13 Thread Milton Miller
On Jan 12, 2009, at 12:24 AM, Simon Horman wrote: On Fri, Jan 02, 2009 at 02:42:38PM -0600, Milton Miller wrote: Follwing this mail are 5 patches for kexec userspace and two for the kernel. The first fixes an array overflow and the second updates userspace to the merged 2.6.28 kdump support

Re: [PATCH 1/4] hvc_console: do not set low_latency

2009-01-13 Thread Milton Miller
at 10:04:22AM +0100, Christian Borntraeger wrote: Am Donnerstag 08 Januar 2009 schrieb Milton Miller: hvc_console is setting low_latency unconditionally, but some clients are interrupt driven and will call hvc_poll from irq context. This will cause tty_flip_buffer_push to be called from irq

  1   2   3   4   >