Re: [PATCH][next] KVM: PPC: Book3S HV: XIVE: fix spelling mistake "acessing" -> "accessing"

2019-05-02 Thread Mukesh Ojha
On 5/2/2019 3:53 PM, Colin King wrote: From: Colin Ian King There is a spelling mistake in a pr_err message, fix it. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- arch/powerpc/kvm/book3s_xive_native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] powerpc/pseries/iommu: fix set but not used values

2019-04-07 Thread Mukesh Ojha
arch/powerpc/platforms/pseries/iommu.c:948:7: warning: variable 'ranges' set but not used [-Wunused-but-set-variable] int ranges, n_mem_addr_cells, n_mem_size_cells, len; ^~ Signed-off-by: Qian Cai Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- arch/powerpc/platforms/pseries/iommu

Re: [PATCH] powerpc/pseries/pmem: fix a set but not used value

2019-04-07 Thread Mukesh Ojha
pseries/pmem.c:109:6: warning: variable 'count' set but not used [-Wunused-but-set-variable] Signed-off-by: Qian Cai Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- arch/powerpc/platforms/pseries/pmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/platfor

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 6:20 PM, Fabio Estevam wrote: On Fri, Apr 5, 2019 at 9:47 AM Mukesh Ojha wrote: Don't change entire thing with //. only above line with the license is enough. Please apply this rule every patch of yours. Not really. This is the style preferred in this subsystem. you mean

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 5:19 PM, Andra Danciu wrote: Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/efika-audio-fabric.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git

Re: [PATCH 01/20] ASoC: imx-pcm: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 5:19 PM, Andra Danciu wrote: Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- sound/soc/fsl/imx-pcm.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

Re: [PATCH 01/20] ASoC: imx-pcm: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 5:19 PM, Andra Danciu wrote: Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- sound/soc/fsl/imx-pcm.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

Re: [PATCH -next] ibmvnic: remove set but not used variable 'netdev'

2019-04-03 Thread Mukesh Ojha
] It's never used since introduction in commit ed651a10875f ("ibmvnic: Updated reset handling") Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/net/ethernet/ibm/ibmvnic.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ib

Re: [PATCH 03/12] PowerPC-83xx: add missing of_node_put after of_device_is_available

2019-04-01 Thread Mukesh Ojha
uot;) Signed-off-by: Julia Lawall Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- arch/powerpc/platforms/83xx/usb.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -u -p a/arch/powerpc/platforms/83xx/usb.c b/arch/powerpc/platforms/83xx/usb.c --- a/arch/powerpc/platforms/83xx/usb.c ++

Re: [PATCH -next] crypto: nx842 - remove set but not used variables 'dpadding' and 'max_sync_size'

2019-03-30 Thread Mukesh Ojha
: warning: variable 'max_sync_size' set but not used [-Wunused-but-set-variable] They are not used any more and can be removed. Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/crypto/nx/nx-842-pseries.c | 6 ++ drivers/crypto/nx/nx-842.c | 3 +-- 2

Re: [PATCH -next] ocxl: remove set but not used variables 'tid' and 'lpid'

2019-03-29 Thread Mukesh Ojha
:187:6: warning: variable 'lpid' set but not used [-Wunused-but-set-variable] They are never used and can be removed. Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/misc/ocxl/link.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH][next] ASoC: fsl: fix spelling mistake: "missign" -> "missing"

2019-03-28 Thread Mukesh Ojha
On 3/28/2019 2:58 PM, Colin King wrote: From: Colin Ian King There is a spelling mistake in a dev_err message. Fix this. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha -Mukesh --- sound/soc/fsl/imx-audmix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] arch/powerpc: Remove duplicate headers

2019-03-28 Thread Mukesh Ojha
On 3/23/2019 6:20 PM, jagdsh.li...@gmail.com wrote: From: Jagadeesh Pagadala Remove duplicate headers which are included twice. Signed-off-by: Jagadeesh Pagadala Reviewed-by: Mukesh Ojha -Mukesh --- arch/powerpc/kernel/time.c | 1 - arch/powerpc/lib/code-patching.c | 1

Re: [PATCH v2 1/2] powerpc: Make some functions static

2019-03-27 Thread Mukesh Ojha
:17: error: no previous prototype for 'holly_restart' [-Werror=missing-prototypes] Signed-off-by: Mathieu Malaterre Reviewed-by: Mukesh Ojha --- v2: Split the patch in two operations arch/powerpc/platforms/embedded6xx/holly.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --

Re: [PATCH v2 2/2] Remove functions holly_power_off and holly_halt since unused

2019-03-27 Thread Mukesh Ojha
: no previous prototype for 'holly_halt' [-Werror=missing-prototypes] Signed-off-by: Mathieu Malaterre Reviewed-by: Mukesh Ojha -Mukesh --- arch/powerpc/platforms/embedded6xx/holly.c | 12 1 file changed, 12 deletions(-) diff --git a/arch/powerpc/platforms/embedded6xx

[PATCH V2 2/2] powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler

2017-02-20 Thread Mukesh Ojha
d while returning -1 or 0 from handler. Signed-off-by: Mukesh Ojha <mukes...@linux.vnet.ibm.com> Reviewed-by: Vasant Hegde <hegdevas...@linux.vnet.ibm.com> --- arch/powerpc/platforms/powernv/opal-dump.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arc

[PATCH V2 1/2] powerpc/powernv/opal-dump : Handles opal_dump_info properly

2017-02-20 Thread Mukesh Ojha
Moves the return value check of 'opal_dump_info' to a proper place which was previously unnecessarily filling all the dump info even on failure. Signed-off-by: Mukesh Ojha <mukes...@linux.vnet.ibm.com> Acked-by: Stewart Smith <stew...@linux.vnet.ibm.com> Acked-by: Jeremy Kerr <

Re: [PATCH 2/2] powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler

2017-02-20 Thread Mukesh Ojha
On Thursday 16 February 2017 08:10 AM, Jeremy Kerr wrote: Hi Mukesh, The return value of an interrupt handler is the special type irqreturn_t. An interrupt handler can return two special values, IRQ_NONE or IRQ_HANDLED. Yep, you can assume that the reader knows that level of the interrupt

Re: [PATCH 2/2] powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler

2017-02-15 Thread Mukesh Ojha
Hi Jeremy, On Wednesday 15 February 2017 08:48 AM, Jeremy Kerr wrote: Hi Mukesh, Converts all the return explicit number to a more proper IRQ_HANDLED, which looks proper incase of interrupt handler returning case. This looks good to me, but can you describe the effects of those changes to

Re: [PATCH 2/2] powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler

2017-02-14 Thread Mukesh Ojha
On Wednesday 15 February 2017 10:38 AM, Stewart Smith wrote: Mukesh Ojha <mukes...@linux.vnet.ibm.com> writes: Converts all the return explicit number to a more proper IRQ_HANDLED, which looks proper incase of interrupt handler returning case. Signed-off-by: Mukesh Ojha

Re: [PATCH 1/2] powerpc/powernv/opal-dump : Handles opal_dump_info properly

2017-02-12 Thread Mukesh Ojha
Hi Micheal, Can you please look at this patchset? -Mukesh On Tuesday 06 December 2016 12:07 PM, Mukesh Ojha wrote: Hi Michael, Can you please have a look at this patchset as there is no functional changes involve with this? Thanks, Mukesh On Thursday 01 December 2016 02:38 PM, Mukesh

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2016-12-20 Thread Mukesh Ojha
IO; - case OPAL_HARDWARE: return -EIO; - case OPAL_INTERNAL_ERROR: return -EIO; + case OPAL_UNSUPPORTED: + case OPAL_HARDWARE: + case OPAL_INTERNAL_ERROR: + case OPAL_WRONG_STATE: return -EIO; Looks good. Reviewed-by: Mukesh Ojha <mukes...

Re: [PATCH 1/2] powerpc/powernv/opal-dump : Handles opal_dump_info properly

2016-12-05 Thread Mukesh Ojha
Hi Michael, Can you please have a look at this patchset as there is no functional changes involve with this? Thanks, Mukesh On Thursday 01 December 2016 02:38 PM, Mukesh Ojha wrote: Moves the return value check of 'opal_dump_info' to a proper place which was previously unnecessarily

[PATCH 2/2] powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler

2016-12-01 Thread Mukesh Ojha
Converts all the return explicit number to a more proper IRQ_HANDLED, which looks proper incase of interrupt handler returning case. Signed-off-by: Mukesh Ojha <mukes...@linux.vnet.ibm.com> Reviewed-by: Vasant Hegde <hegdevas...@linux.vnet.ibm.com> --- arch/powerpc/platforms/powernv

[PATCH 1/2] powerpc/powernv/opal-dump : Handles opal_dump_info properly

2016-12-01 Thread Mukesh Ojha
Moves the return value check of 'opal_dump_info' to a proper place which was previously unnecessarily filling all the dump info even on failure. Signed-off-by: Mukesh Ojha <mukes...@linux.vnet.ibm.com> --- arch/powerpc/platforms/powernv/opal-dump.c | 9 ++--- 1 file changed, 6 inse

[PATCH] powerpc/powernv : Drop reference added by kset_find_obj()

2016-08-22 Thread Mukesh Ojha
earlier. Signed-off-by: Mukesh Ojha <mukes...@linux.vnet.ibm.com> Cc: sta...@vger.kernel.org --- arch/powerpc/platforms/powernv/opal-dump.c | 7 ++- arch/powerpc/platforms/powernv/opal-elog.c | 7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/pla