[PATCH] FS_ENET: Don't attempt to set mii_speed when fec_inf is null

2008-06-27 Thread Nye Liu
From: Nye Liu <[EMAIL PROTECTED]> When using CONFIG_FIXED_PHY, fec_inf (fep->phydev->bus->priv) is NULL in fs_enet/mac-fec.c restart(). Dereferencing fec_inf when trying to set the mii_speed causes a kernel oops. Signed-off-by: Nye Liu <[EMAIL PROTECTED]> --- diff --git

Re: [PATCH] FS_ENET: Don't attempt to set mii_speed when fec_inf is null

2008-06-27 Thread Nye Liu
. */ - FW(fecp, mii_speed, fec_inf->mii_speed); + if (fec_inf) + FW(fecp, mii_speed, fec_inf->mii_speed); /* * Clear any outstanding interrupt. On Sat, Jun 28, 2008 at 01:29:16AM +0400, Sergei Shtylyov wrote: > Hello. > > Nye Liu wrote: &

[PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc

2008-06-27 Thread Nye Liu
From: Nye Liu <[EMAIL PROTECTED]> udbg_putc is a *function pointer* that is initialized during udbg_init_cpm. It might not be initialized properly when called from udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly. Printing an "X" on initialization is ugly. How abou

[PATCH] FS_ENET: Don't attempt to set mii_speed when fec_inf is null

2008-06-27 Thread Nye Liu
From: Nye Liu <[EMAIL PROTECTED]> When using CONFIG_FIXED_PHY, fec_inf (fep->phydev->bus->priv) is NULL in fs_enet/mac-fec.c restart(). Dereferencing fec_inf when trying to set the mii_speed causes a kernel oops. Signed-off-by: Nye Liu <[EMAIL PROTECTED]> --- diff --git