Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue

2024-05-09 Thread Paolo Abeni
On Wed, 2024-05-08 at 21:16 +0100, Simon Horman wrote: > * As this patch seems to involve many non-trivial changes > it seems to me that it would be best to break it up somehow. > To allow proper review. I would like to stress this latest point: it looks like the changes to all the drivers

Re: [PATCH] ibmvnic: Use -EBUSY in __ibmvnic_reset()

2024-04-23 Thread Paolo Abeni
On Fri, 2024-04-19 at 16:08 +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 19 Apr 2024 15:46:17 +0200 > > Add a minus sign before the error code “EBUSY” > so that a negative value will be used as in other cases. > > This issue was transformed by using the Coccinelle software.

Re: [PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-02-05 Thread Paolo Abeni
On Mon, 2024-02-05 at 15:22 +0100, Herve Codina wrote: > Hi Paolo, > > On Thu, 01 Feb 2024 12:41:32 +0100 > Paolo Abeni wrote: > > [...] > > > +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device > > > *netdev) > > >

Re: [PATCH v2 5/6] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support

2024-02-01 Thread Paolo Abeni
On Tue, 2024-01-30 at 09:40 +0100, Herve Codina wrote: > QMC channels support runtime timeslots changes but nothing is done at > the QMC HDLC driver to handle these changes. > > Use existing IFACE ioctl in order to configure the timeslots to use. > > Signed-off-by: Herve Codina > Reviewed-by:

Re: [PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-02-01 Thread Paolo Abeni
On Tue, 2024-01-30 at 09:40 +0100, Herve Codina wrote: > The QMC HDLC driver provides support for HDLC using the QMC (QUICC > Multichannel Controller) to transfer the HDLC data. > > Signed-off-by: Herve Codina > Reviewed-by: Christophe Leroy > Acked-by: Jakub Kicinski > --- >

Re: [PATCH v4] drivers/net: process the result of hdlc_open() and add call of hdlc_close() in uhdlc_close()

2023-09-05 Thread Paolo Abeni
On Mon, 2023-09-04 at 17:03 +, Christophe Leroy wrote: > > Le 04/09/2023 à 14:31, Alexandra Diupina a écrit : > > diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c > > index 47c2ad7a3e42..fd999dabdd39 100644 > > --- a/drivers/net/wan/fsl_ucc_hdlc.c > > +++

Re: [PATCH] net: Explicitly include correct DT includes

2023-07-18 Thread Paolo Abeni
Hi, On Sat, 2023-07-15 at 10:11 -0500, Alex Elder wrote: > On 7/14/23 12:48 PM, Rob Herring wrote: > > The DT of_device.h and of_platform.h date back to the separate > > of_platform_bus_type before it as merged into the regular platform bus. > > As part of that merge prepping Arm DT support 13

Re: [PATCH net-next v5 08/18] net: sparx5: Replace usage of found with dedicated list iterator variable

2022-04-28 Thread Paolo Abeni
Hello, On Wed, 2022-04-27 at 18:06 +0200, Jakob Koschel wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it

Re: [PATCH net-next v2] net: ethernet: Prepare cleanup of powerpc's asm/prom.h

2022-04-19 Thread Paolo Abeni
Hello, Sorry for the late reply. On Fri, 2022-04-15 at 10:39 +0200, Christophe Leroy wrote: > powerpc's asm/prom.h brings some headers that it doesn't > need itself. It's probably my fault, but I really can't parse the above. Could you please re-phrase? > > In order to clean it up in a further

Re: [PATCH net-next v2 05/18] net: dsa: mv88e6xxx: remove redundant check in mv88e6xxx_port_vlan()

2022-04-12 Thread Paolo Abeni
On Tue, 2022-04-12 at 13:37 +0200, Jakob Koschel wrote: > > > On 12. Apr 2022, at 13:27, Russell King (Oracle) > > wrote: > > > > On Tue, Apr 12, 2022 at 12:58:17PM +0200, Jakob Koschel wrote: > > > We know that "dev > dst->last_switch" in the "else" block. > > > In other words, that "dev -

[PATCH net-next] udp: fix poll()

2017-06-23 Thread Paolo Abeni
ength() after the possible checksum update. Fixes: b65ac44674dd ("udp: try to avoid 2 cache miss on dequeue") Reported-by: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> Signed-off-by: Paolo Abeni <pab..

Re: DNS (?) not working on G5 (64-bit powerpc) (was [net-next,v3,3/3] udp: try to avoid 2 cache miss on dequeue)

2017-06-23 Thread Paolo Abeni
On Fri, 2017-06-23 at 16:59 +1000, Michael Ellerman wrote: > Hannes Frederic Sowa <han...@stressinduktion.org> writes: > > > On Thu, Jun 22, 2017, at 22:57, Paolo Abeni wrote: > > > > > > Can you please check if the following patch fixes the is

Re: DNS (?) not working on G5 (64-bit powerpc) (was [net-next,v3,3/3] udp: try to avoid 2 cache miss on dequeue)

2017-06-23 Thread Paolo Abeni
On Thu, 2017-06-22 at 18:43 +0200, Paolo Abeni wrote: > On Thu, 2017-06-22 at 23:06 +1000, Michael Ellerman wrote: > > Paolo wrote: > > > when udp_recvmsg() is executed, on x86_64 and other archs, most skb > > > fields are on cold cachelines. > > > If the skb

Re: DNS (?) not working on G5 (64-bit powerpc) (was [net-next,v3,3/3] udp: try to avoid 2 cache miss on dequeue)

2017-06-22 Thread Paolo Abeni
hat are left out. > > > > This can save up to 2 cache miss per packet. > > > > v1 -> v2: > > - changed udp_dev_scratch fields types to u{32,16} variant, > > replaced bitfiled with bool > > > > Signed-off-by: Paolo Abe

Re: DNS (?) not working on G5 (64-bit powerpc) (was [net-next,v3,3/3] udp: try to avoid 2 cache miss on dequeue)

2017-06-22 Thread Paolo Abeni
On Thu, 2017-06-22 at 18:43 +0200, Paolo Abeni wrote: > On Thu, 2017-06-22 at 23:06 +1000, Michael Ellerman wrote: > > Paolo wrote: > > > when udp_recvmsg() is executed, on x86_64 and other archs, most skb > > > fields are on cold cachelines. > > > If the skb

Re: DNS (?) not working on G5 (64-bit powerpc) (was [net-next,v3,3/3] udp: try to avoid 2 cache miss on dequeue)

2017-06-22 Thread Paolo Abeni
hat are left out. > > > > This can save up to 2 cache miss per packet. > > > > v1 -> v2: > > - changed udp_dev_scratch fields types to u{32,16} variant, > > replaced bitfiled with bool > > > > Signed-off-by: Paolo Abe