;
> + pr_info("fusb300_ep0fail\n");
> }
>
> if (int_grp1 & FUSB300_IGR1_CX_SETUP_INT) {
> - printk(KERN_INFO "fusb300_ep0setup\n");
> + pr_info("fusb300_ep0setup\n");
> if (setup_packet(fusb300, )) {
> spin_unlock(>lock);
> if (fusb300->driver->setup(>gadget, ) < 0)
> @@ -1209,16 +1209,16 @@ static irqreturn_t fusb300_irq(int irq, void
> *_fusb300)
> }
>
> if (int_grp1 & FUSB300_IGR1_CX_CMDEND_INT)
> - printk(KERN_INFO "fusb300_cmdend\n");
> + pr_info("fusb300_cmdend\n");
>
>
> if (int_grp1 & FUSB300_IGR1_CX_OUT_INT) {
> - printk(KERN_INFO "fusb300_cxout\n");
> + pr_info("fusb300_cxout\n");
> fusb300_ep0out(fusb300);
> }
>
> if (int_grp1 & FUSB300_IGR1_CX_IN_INT) {
> - printk(KERN_INFO "fusb300_cxin\n");
> + pr_info("fusb300_cxin\n");
> fusb300_ep0in(fusb300);
> }
>
> diff --git a/drivers/usb/gadget/udc/goku_udc.c
> b/drivers/usb/gadget/udc/goku_udc.c
> index 3e1267d38774..4f225552861a 100644
> --- a/drivers/usb/gadget/udc/goku_udc.c
> +++ b/drivers/usb/gadget/udc/goku_udc.c
> @@ -1748,7 +1748,7 @@ static int goku_probe(struct pci_dev *pdev, const
> struct pci_device_id *id)
> int retval;
>
> if (!pdev->irq) {
> - printk(KERN_ERR "Check PCI %s IRQ setup!\n", pci_name(pdev));
> + pr_err("Check PCI %s IRQ setup!\n", pci_name(pdev));
> retval = -ENODEV;
> goto err;
> }
> diff --git a/drivers/usb/gadget/udc/r8a66597-udc.h
> b/drivers/usb/gadget/udc/r8a66597-udc.h
> index 9a115caba661..fa4d62c32ea1 100644
> --- a/drivers/usb/gadget/udc/r8a66597-udc.h
> +++ b/drivers/usb/gadget/udc/r8a66597-udc.h
> @@ -247,7 +247,7 @@ static inline u16 get_xtal_from_pdata(struct
> r8a66597_platdata *pdata)
> clock = XTAL48;
> break;
> default:
> - printk(KERN_ERR "r8a66597: platdata clock is wrong.\n");
> + pr_err("r8a66597: platdata clock is wrong.\n");
> break;
> }
>
> --
> 2.11.0
>
--
Thanks,
Peter Chen
Acked-by: Peter Chen
For:
Documentation/ABI/testing/usb-charger-uevent
Peter
ct ep_queue_head *qh;
>
> - if (!_ep || _ep->desc || !(_ep->desc->bEndpointAddress&0xF))
> + if (!_ep || !_ep->desc || !(_ep->desc->bEndpointAddress&0xF))
> return -ENODEV;
>
Reviewed-by: Peter Chen
Peter
s/usb/gadget/udc/fsl_udc_core.c
> @@ -53,7 +53,6 @@
> #define DMA_ADDR_INVALID(~(dma_addr_t)0)
>
> static const char driver_name[] = "fsl-usb2-udc";
> -static const char driver_desc[] = DRIVER_DESC;
>
> static struct usb_dr_device __iomem *dr_regs;
>
> --
> 2.17.1
>
>
Reviewed-by: Peter Chen
--
Thanks,
Peter Chen
>
>On Fri, Aug 12, 2016 at 09:34:41AM +0800, Peter Chen wrote:
>> of_node_put needs to be called when the device node which is got from
>> of_parse_phandle has finished using.
>>
>> Cc: Minghuan Lian <minghuan.l...@freescale.com>
>> Cc: Mingkai Hu <m
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Minghuan Lian <minghuan.l...@freescale.com>
Cc: Mingkai Hu <mingkai...@freescale.com>
Cc: Roy Zang <tie-fei.z...@freescale.com>
Signed-off-by: Peter Chen &
;
> tmp = in_be16(>usb_param->frame_n);
> if (tmp & 0x8000)
> - tmp = tmp & 0x07ff;
> - else
> - tmp = -EINVAL;
> -
> - return (int)tmp;
> + return tmp & 0x07ff;
> + return -EINVAL;
> }
Acked
break;
> ep = >eps[pipe];
>
Acked-by: Peter Chen <peter.c...@nxp.com>
--
Best Regards,
Peter Chen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
BR,
Peter Chen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
My configuration:
-
Host: Freescale i.MX512 with ARM Cortex A8 (USB 2.0 host controller) Linux
kernel: 2.6.31, using EHCI USB driver
Hub: 4-PORT USB 1.1 HUB (Texas Instruments PN: tusb2046b)
Devices: 4 USB 1.1 audio codecs (Texas Instruments PN: pcm2901)
Note: each
= newstate)
struct usb_dr_mmap {
/* Capability register */
--
2.1.0.GIT
--
Best Regards,
Peter Chen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Thu, Jan 17, 2013 at 11:14:22AM +0200, Felipe Balbi wrote:
On Wed, Jan 16, 2013 at 09:48:25AM +0800, Peter Chen wrote:
On Tue, Jan 15, 2013 at 10:03:46PM +0800, Shawn Guo wrote:
On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote:
As mach/hardware.h is deleted, we need to use
() as it has already pdata runtime check
Changes for v4:
- Using pdev's struct resource to do ioremap
- Add ioremap return value check
Changes for v3:
- Split the one big patch into three patches
Changes for v2:
- Add const for fsl_udc_devtype
- Do ioremap for phy address at fsl-mxc-udc
Peter Chen (3
As mach/hardware.h is deleted, we need to use platform_device_id to
differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has
already used pdata to differentiate runtime
Meanwhile we update the platform code accordingly.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm
As we use platform_device_id for fsl-usb2-udc driver, it needs to
change clk connection-id, or the related devm_clk_get will be failed.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/mach-imx/clk-imx25.c |6 +++---
arch/arm/mach-imx/clk-imx27.c |6
As mach/hardware.h is deleted, we can't visit platform code at driver.
It has no phy driver to combine with this controller, so it has to use
ioremap to map phy address as a workaround.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/gadget/fsl_mxc_udc.c | 30
() as it has already pdata runtime check
Changes for v4:
- Using pdev's struct resource to do ioremap
- Add ioremap return value check
Changes for v3:
- Split the one big patch into three patches
Changes for v2:
- Add const for fsl_udc_devtype
- Do ioremap for phy address at fsl-mxc-udc
Peter Chen (3
As mach/hardware.h is deleted, we can't visit platform code at driver.
It has no phy driver to combine with this controller, so it has to use
ioremap to map phy address as a workaround.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/gadget/fsl_mxc_udc.c | 30
As mach/hardware.h is deleted, we need to use platform_device_id to
differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has
already used pdata to differentiate runtime
Meanwhile we update the platform code accordingly.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm
As we use platform_device_id for fsl-usb2-udc driver, it needs to
change clk connection-id, or the related devm_clk_get will be failed.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/mach-imx/clk-imx25.c |6 +++---
arch/arm/mach-imx/clk-imx27.c |6
gets added, let's say
imx-udc-mxyy then
!strcmp(pdev-id_entry-name, imx-udc-mx27)) will not correspond to
!cpu_is_mx51() anymore.
--
Best Regards,
Peter Chen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org
for fsl_udc_devtype
- Do ioremap for phy address at fsl-mxc-udc
Peter Chen (3):
usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id
usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap
ARM: i.MX clock: Change the connection-id for fsl-usb2-udc
arch/arm/mach-imx/clk-imx25.c
As mach/hardware.h is deleted, we need to use platform_device_id to
differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has
already used pdata to differentiate runtime
Meanwhile we update the platform code accordingly.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm
As mach/hardware.h is deleted, we can't visit platform code at driver.
It has no phy driver to combine with this controller, so it has to use
ioremap to map phy address as a workaround.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/gadget/fsl_mxc_udc.c | 30
As we use platform_device_id for fsl-usb2-udc driver, it needs to
change clk connection-id, or the related devm_clk_get will be failed.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/mach-imx/clk-imx25.c |6 +++---
arch/arm/mach-imx/clk-imx27.c |6
On Fri, Jan 18, 2013 at 10:23:39AM +0800, Shawn Guo wrote:
Peter,
On Fri, Jan 18, 2013 at 10:15:49AM +0800, Peter Chen wrote:
As we use platform_device_id for fsl-usb2-udc driver, it needs to
change clk connection-id, or the related devm_clk_get will be failed.
Signed-off-by: Peter
On Tue, Jan 15, 2013 at 10:03:46PM +0800, Shawn Guo wrote:
On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote:
As mach/hardware.h is deleted, we need to use platform_device_id to
differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has
already used pdata to differentiate
On Mon, Jan 14, 2013 at 09:48:58AM +0200, Felipe Balbi wrote:
Hi,
On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote:
It changes the driver to use platform_device_id rather than cpu_is_xxx
to determine the SoC type, and updates the platform code accordingly.
Compile ok
On Mon, Jan 14, 2013 at 10:50:27AM +0200, Felipe Balbi wrote:
Hi,
On Mon, Jan 14, 2013 at 04:17:35PM +0800, Peter Chen wrote:
On Mon, Jan 14, 2013 at 09:48:58AM +0200, Felipe Balbi wrote:
Hi,
On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote:
It changes the driver
Changes for v3:
- Split the one big patch into three patches
Changes for v2:
- Add const for fsl_udc_devtype
- Do ioremap for phy address at fsl-mxc-udc
Peter Chen (3):
usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id
usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap
ARM
As mach/hardware.h is deleted, we need to use platform_device_id to
differentiate SoCs.
Besides we update the platform code accordingly.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/mach-imx/devices/devices-common.h|1 +
arch/arm/mach-imx/devices/platform-fsl-usb2
As mach/hardware.h is deleted, we can't visit platform code at driver.
It has no phy driver to combine with this controller, so it has to use
ioremap to map phy address as a workaround.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/gadget/fsl_mxc_udc.c | 12 +++-
1
As we use platform_device_id for fsl-usb2-udc driver, it needs to
change clk connection-id, or the related devm_clk_get will be failed.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/mach-imx/clk-imx25.c |6 +++---
arch/arm/mach-imx/clk-imx27.c |6
--
Best Regards,
Peter Chen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Mon, Jan 14, 2013 at 12:17:08PM +0200, Felipe Balbi wrote:
On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote:
As mach/hardware.h is deleted, we can't visit platform code at driver.
It has no phy driver to combine with this controller, so it has to use
ioremap to map phy address
On Mon, Jan 14, 2013 at 01:10:56PM +, Russell King - ARM Linux wrote:
On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote:
@@ -83,15 +84,16 @@ void fsl_udc_clk_finalize(enum fsl_udc_type devtype,
struct fsl_usb2_platform_data *pdata = pdev-dev.platform_data;
if (devtype
Changes for v4:
- Using pdev's struct resource to do ioremap
- Add ioremap return value check
Changes for v3:
- Split the one big patch into three patches
Changes for v2:
- Add const for fsl_udc_devtype
- Do ioremap for phy address at fsl-mxc-udc
Peter Chen (3):
usb: fsl-mxc-udc: replace
As mach/hardware.h is deleted, we need to use platform_device_id to
differentiate SoCs.
Besides we update the platform code accordingly.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/mach-imx/devices/devices-common.h|1 +
arch/arm/mach-imx/devices/platform-fsl-usb2
As mach/hardware.h is deleted, we can't visit platform code at driver.
It has no phy driver to combine with this controller, so it has to use
ioremap to map phy address as a workaround.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/gadget/fsl_mxc_udc.c | 27
As we use platform_device_id for fsl-usb2-udc driver, it needs to
change clk connection-id, or the related devm_clk_get will be failed.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/mach-imx/clk-imx25.c |6 +++---
arch/arm/mach-imx/clk-imx27.c |6
On Mon, Jan 14, 2013 at 07:57:24PM +0200, Felipe Balbi wrote:
On Mon, Jan 14, 2013 at 06:54:22PM +0100, Marc Kleine-Budde wrote:
On 01/14/2013 06:40 PM, Felipe Balbi wrote:
Hi,
On Mon, Jan 14, 2013 at 08:56:33PM +0800, Peter Chen wrote:
snip
Usually there isn't any
const for fsl_udc_devtype
- Do ioremap for phy address at fsl-mxc-udc
Peter Chen (3):
usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id
usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap
ARM: i.MX clock: Change the connection-id for fsl-usb2-udc
arch/arm/mach-imx/clk-imx25.c
As mach/hardware.h is deleted, we need to use platform_device_id to
differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has
already used pdata to differentiate runtime
Meanwhile we update the platform code accordingly.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm
As mach/hardware.h is deleted, we can't visit platform code at driver.
It has no phy driver to combine with this controller, so it has to use
ioremap to map phy address as a workaround.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/gadget/fsl_mxc_udc.c | 30
As we use platform_device_id for fsl-usb2-udc driver, it needs to
change clk connection-id, or the related devm_clk_get will be failed.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/mach-imx/clk-imx25.c |6 +++---
arch/arm/mach-imx/clk-imx27.c |6
On Fri, Jan 11, 2013 at 02:50:59PM +0200, Felipe Balbi wrote:
Hi,
On Fri, Jan 11, 2013 at 05:56:28PM +0800, Peter Chen wrote:
It changes the driver to use platform_device_id rather than cpu_is_xxx
to determine the SoC type, and updates the platform code accordingly.
Compile ok
this problem)
Signed-off-by: Peter Chen peter.c...@freescale.com
---
Changes for v2:
- Add const for fsl_udc_devtype
- Do ioremap for phy address at fsl-mxc-udc
arch/arm/mach-imx/clk-imx25.c |6 +-
arch/arm/mach-imx/clk-imx27.c |6 +-
arch/arm/mach
this problem)
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/mach-imx/clk-imx25.c |6 +-
arch/arm/mach-imx/clk-imx27.c |6 +-
arch/arm/mach-imx/clk-imx31.c |6 +-
arch/arm/mach-imx/clk-imx35.c
/majordomo-info.html
--
Best Regards,
Peter Chen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Thu, Feb 16, 2012 at 9:41 AM, Peter Chen peter.c...@freescale.com wrote:
When build i.mx platform with imx_v6_v7_defconfig, and after adding
USB Gadget support, it has below build error:
CC drivers/usb/host/fsl-mph-dr-of.o
drivers/usb/host/fsl-mph-dr-of.c: In function
-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/host/fsl-mph-dr-of.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 7916e56..ab333ac 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers
this code
can help me a test? Thank you
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/host/fsl-mph-dr-of.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 7916e56..ab333ac 100644
this code
can help me a test? Thank you
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/host/fsl-mph-dr-of.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 7916e56..ab333ac 100644
--
Best Regards,
Peter Chen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
://vger.kernel.org/majordomo-info.html
--
BR,
Peter Chen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Wed, Nov 23, 2011 at 08:12:56PM +0800, Li Yang wrote:
The original implementation of dequeuing a request in progress
is not correct. Change to use a correct process and also clean
up the related functions a little bit.
Signed-off-by: Li Yang le...@freescale.com
Cc: Peter Chen peter.c
unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards,
Peter Chen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https
you do me a favor on investigating why it's failing?
Thanks,
Leo
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
BR,
Peter Chen
On Tue, Nov 22, 2011 at 7:48 PM, Peter Chen hzpeterc...@gmail.com wrote:
It seems to can't get the correct qh pointer, you may still need to use
below code to get it
int i = ep_index(ep) * 2 + ep_is_in(ep);
struct ep_queue_head *dQH = ep-udc-ep_qh[i];
Thanks for trying
Some ISO gadgets, like audio, has SYNC attribute as well as
USB_ENDPOINT_XFER_ISOC for their bmAttributes at ISO endpoint
descriptor. So, it needs to use instead of == to judge if
it is ISO XFER.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c |4
Some ISO gadgets, like audio, has SYNC attribute as well as
USB_ENDPOINT_XFER_ISOC for their bmAttributes at ISO endpoint
descriptor. So, it needs to use usb_endpoint_xfer_isoc to judge
ISO XFER.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c |4
61 matches
Mail list logo
