Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

Hi Michal, On Tue, 7 Dec 2021 18:32:21 +0100 Michal Suchánek wrote: > On Tue, Dec 07, 2021 at 05:10:14PM +0100, Philipp Rudo wrote: > > Hi Michal, > > > > i finally had the time to take a closer look at the series. Except for > > the nit in patch 4 and my persona

Re: [PATCH v2 4/6] module: strip the signature marker in the verification function.

Hi Michal, On Thu, 25 Nov 2021 19:02:42 +0100 Michal Suchanek wrote: > It is stripped by each caller separately. > > Signed-off-by: Michal Suchanek > --- > arch/powerpc/kexec/elf_64.c | 9 - > arch/s390/kernel/machine_kexec_file.c | 9 - > kernel/module.c

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

Hi Michal, i finally had the time to take a closer look at the series. Except for the nit in patch 4 and my personal preference in patch 6 the code looks good to me. What I don't like are the commit messages on the first commits. In my opinion they are so short that they are almost useless. For e

Re: [PATCH v2 6/6] module: Move duplicate mod_check_sig users code to mod_parse_sig

Hi Michal, On Thu, 25 Nov 2021 19:02:44 +0100 Michal Suchanek wrote: > Multiple users of mod_check_sig check for the marker, then call > mod_check_sig, extract signature length, and remove the signature. > > Put this code in one place together with mod_check_sig. > > Signed-off-by: Michal Such

Re: [PATCH 0/3] KEXEC_SIG with appended signature

Hi Michal, On Wed, 24 Nov 2021 14:27:16 +0100 Michal Suchánek wrote: > On Wed, Nov 24, 2021 at 08:10:10AM -0500, Mimi Zohar wrote: > > On Wed, 2021-11-24 at 12:09 +0100, Philipp Rudo wrote: > > > Now Michal wants to adapt KEXEC_SIG for ppc too so distros can rely on all &

Re: [PATCH 0/3] KEXEC_SIG with appended signature

Hi Mimi, On Fri, 19 Nov 2021 13:16:20 -0500 Mimi Zohar wrote: > On Fri, 2021-11-19 at 12:18 +0100, Michal Suchánek wrote: > > Maybe I was not clear enough. If you happen to focus on an architecture > > that supports IMA fully it's great. > > > > My point of view is maintaining multiple architec

Re: [PATCH v3] ima: add a new CONFIG for loading arch-specific policies

t;noise", this patch > defines a new IMA Kconfig IMA_SECURE_AND_OR_TRUSTED_BOOT option, allowing > the different architectures to select it. > > Suggested-by: Linus Torvalds > Signed-off-by: Nayna Jain > Acked-by: Ard Biesheuvel > Cc: Ard Biesheuvel > Cc: Philipp Rudo

Re: [PATCH v2] ima: add a new CONFIG for loading arch-specific policies

RUSTED_BOOT option, allowing > > > the different architectures to select it. > > > > > > Suggested-by: Linus Torvalds > > > Signed-off-by: Nayna Jain > > > Cc: Ard Biesheuvel > > > Cc: Philipp Rudo > > > Cc: Michael Ellerman > > > > Ac

Re: [PATCH v12 01/11] MODSIGN: Export module signature definitions

Hi Thiago, > > The patch looks good now. > > Thanks! Can I add your Reviewed-by? sorry, for the late answer, but I was on vacation the last two weeks. I hope it's not too late now. Reviewed-by: Philipp Rudo

Re: [PATCH v12 01/11] MODSIGN: Export module signature definitions

Hi Thiago, On Thu, 04 Jul 2019 15:57:34 -0300 Thiago Jung Bauermann wrote: > Hello Philipp, > > Philipp Rudo writes: > > > Hi Thiago, > > > > > > On Thu, 04 Jul 2019 03:42:57 -0300 > > Thiago Jung Bauermann wrote: > > > >> Jessica

Re: [PATCH v12 01/11] MODSIGN: Export module signature definitions

Hi Thiago, On Thu, 04 Jul 2019 03:42:57 -0300 Thiago Jung Bauermann wrote: > Jessica Yu writes: > > > +++ Thiago Jung Bauermann [27/06/19 23:19 -0300]: > >>IMA will use the module_signature format for append signatures, so export > >>the relevant definitions and factor out the code which ve

Re: [PATCH RFC] generic ELF support for kexec

Hi Sven, On Tue, 25 Jun 2019 20:54:34 +0200 Sven Schnelle wrote: > Hi List, > > i recently started working on kexec for PA-RISC. While doing so, i figured > that powerpc already has support for reading ELF images inside of the Kernel. > My first attempt was to steal the source code and modify i