[PATCH v12 18/20] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

Port Detected Errors [2] PCIe Base Spec r6.0, 7.8.4.3 Uncorrectable Error Mask Register, 7.8.4.6 Correctable Error Mask Register Co-developed-by: Terry Bowman Signed-off-by: Terry Bowman Signed-off-by: Robert Richter Acked-by: Bjorn Helgaas Reviewed-by: Jonathan Cameron Reviewed-by: Dave

[PATCH v12 17/20] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

spec: 9.11.8 CXL Devices Attached to an RCH [2] CXL 3.0 spec, 12.2.1.1 RCH Downstream Port-detected Errors [3] CXL 3.0 spec, 8.1.3 PCIe DVSEC for CXL Devices Co-developed-by: Terry Bowman Signed-off-by: Terry Bowman Signed-off-by: Robert Richter Cc: "Oliver O'Halloran" Cc: Bjorn H

[PATCH v12 12/20] PCI/AER: Refactor cper_print_aer() for use by CXL driver module

(). The cper_print_aer() function name implies CPER specific use but is useful in non-CPER cases as well. Rename cper_print_aer() to pci_print_aer(). Also, update cxl_core to import CXL namespace imports. Co-developed-by: Robert Richter Signed-off-by: Terry Bowman Signed-off-by: Robert Richter

[PATCH v11 17/20] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

spec: 9.11.8 CXL Devices Attached to an RCH [2] CXL 3.0 spec, 12.2.1.1 RCH Downstream Port-detected Errors [3] CXL 3.0 spec, 8.1.3 PCIe DVSEC for CXL Devices Co-developed-by: Terry Bowman Signed-off-by: Terry Bowman Signed-off-by: Robert Richter Cc: "Oliver O'Halloran" Cc: Bjorn H

[PATCH v11 18/20] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

Port Detected Errors [2] PCIe Base Spec r6.0, 7.8.4.3 Uncorrectable Error Mask Register, 7.8.4.6 Correctable Error Mask Register Co-developed-by: Terry Bowman Signed-off-by: Terry Bowman Signed-off-by: Robert Richter Acked-by: Bjorn Helgaas Reviewed-by: Jonathan Cameron Reviewed-by: Dave

[PATCH v11 12/20] PCI/AER: Refactor cper_print_aer() for use by CXL driver module

(). The cper_print_aer() function name implies CPER specific use but is useful in non-CPER cases as well. Rename cper_print_aer() to pci_print_aer(). Also, update cxl_core to import CXL namespace imports. Co-developed-by: Robert Richter Signed-off-by: Terry Bowman Signed-off-by: Robert Richter

Re: [PATCH v4 22/23] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

On 25.05.23 17:01:01, Bjorn Helgaas wrote: > On Thu, May 25, 2023 at 11:29:58PM +0200, Robert Richter wrote: > > eOn 24.05.23 16:32:35, Bjorn Helgaas wrote: > > > On Tue, May 23, 2023 at 06:22:13PM -0500, Terry Bowman wrote: > > > > From: Robert Richter > > &

Re: [PATCH v4 22/23] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

eOn 24.05.23 16:32:35, Bjorn Helgaas wrote: > On Tue, May 23, 2023 at 06:22:13PM -0500, Terry Bowman wrote: > > From: Robert Richter > > > > In Restricted CXL Device (RCD) mode a CXL device is exposed as an > > RCiEP, but CXL downstream and upstream ports are not enu

Re: [PATCH v3 5/6] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

Bjorn, On 18.04.23 00:00:58, Robert Richter wrote: > On 14.04.23 16:32:54, Bjorn Helgaas wrote: > > On Thu, Apr 13, 2023 at 01:40:52PM +0200, Robert Richter wrote: > > > On 12.04.23 17:02:33, Bjorn Helgaas wrote: > > > > On Tue, Apr 11, 2023 at 01:03:01PM -0500

Re: [PATCH v3 5/6] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

Dan, thanks for review, see comments inline. On 17.04.23 18:01:41, Dan Williams wrote: > Terry Bowman wrote: > > From: Robert Richter > > > > In Restricted CXL Device (RCD) mode a CXL device is exposed as an > > RCiEP, but CXL downstream and upstre

Re: [PATCH v3 5/6] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

On 14.04.23 16:32:54, Bjorn Helgaas wrote: > On Thu, Apr 13, 2023 at 01:40:52PM +0200, Robert Richter wrote: > > On 12.04.23 17:02:33, Bjorn Helgaas wrote: > > > On Tue, Apr 11, 2023 at 01:03:01PM -0500, Terry Bowman wrote: > > > > From: Robert Richter > >

Re: [PATCH v3 5/6] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

Hi Jonathan, On 17.04.23 17:54:31, Jonathan Cameron wrote: > On Fri, 14 Apr 2023 16:35:05 +0200 > Robert Richter wrote: > > > On 14.04.23 13:19:50, Jonathan Cameron wrote: > > > On Tue, 11 Apr 2023 13:03:01 -0500 > > > Terry Bowman wrote: >

Re: [PATCH v3 6/6] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

On 14.04.23 12:55:43, Jonathan Cameron wrote: > On Fri, 14 Apr 2023 13:21:37 +0200 > Robert Richter wrote: > > The version I have ready after addressing Bjorn's comments is pretty > > much the same, apart from error checking of the read/writes. > > > > From you

Re: [PATCH v3 5/6] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

On 14.04.23 13:19:50, Jonathan Cameron wrote: > On Tue, 11 Apr 2023 13:03:01 -0500 > Terry Bowman wrote: > > > From: Robert Richter > > > > In Restricted CXL Device (RCD) mode a CXL device is exposed as an > > RCiEP, but CXL downstream and upstream ports are n

Re: [PATCH v3 6/6] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

On 13.04.23 18:05:08, Jonathan Cameron wrote: > On Thu, 13 Apr 2023 15:38:07 +0200 > Robert Richter wrote: > > > On 12.04.23 16:29:01, Bjorn Helgaas wrote: > > > On Tue, Apr 11, 2023 at 01:03:02PM -0500, Terry Bowman wrote: > > > With the exception of this fu

Re: [PATCH v3 6/6] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

On 13.04.23 15:52:36, Ira Weiny wrote: > Jonathan Cameron wrote: > > On Wed, 12 Apr 2023 16:29:01 -0500 > > Bjorn Helgaas wrote: > > > > > On Tue, Apr 11, 2023 at 01:03:02PM -0500, Terry Bowman wrote: > > > > From: Robert Richter > > > > &

Re: [PATCH v3 6/6] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

On 12.04.23 16:29:01, Bjorn Helgaas wrote: > On Tue, Apr 11, 2023 at 01:03:02PM -0500, Terry Bowman wrote: > > From: Robert Richter > > > > RCEC AER corrected and uncorrectable internal errors (CIE/UIE) are > > disabled by default. > > "Disabled by default&

Re: [PATCH v3 5/6] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

Bjorn, thanks for your detailed review. On 12.04.23 17:02:33, Bjorn Helgaas wrote: > On Tue, Apr 11, 2023 at 01:03:01PM -0500, Terry Bowman wrote: > > From: Robert Richter > > > > In Restricted CXL Device (RCD) mode a CXL device is exposed as an > > RCiEP, but CXL do

Re: [PATCH v2 4/5] cxl/pci: Forward RCH downstream port-detected errors to the CXL.mem dev handler

On 28.03.23 12:21:04, Bjorn Helgaas wrote: > [+cc linux-pci, more error handling folks; beginning of thread at > https://lore.kernel.org/all/20230323213808.398039-1-terry.bow...@amd.com/] > > On Mon, Mar 27, 2023 at 11:51:39PM +0200, Robert Richter wrote: > > On 24.03.23 17:36

Re: gcc trunk fails to build kernel on PowerPC64 due to oprofile warnings

On 26.01.17 10:46:43, William Cohen wrote: > From 7e46dbd7dc5bc941926a4a63c28ccebf46493e8d Mon Sep 17 00:00:00 2001 > From: William Cohen > Date: Thu, 26 Jan 2017 10:33:59 -0500 > Subject: [PATCH] Avoid hypthetical string truncation in oprofile stats buffer > MIME-Version: 1.0

Re: [PATCH v10 3/8] dt, numa: adding numa dt binding implementation.

On 11.02.16 08:50:41, Rob Herring wrote: > On Tue, Feb 2, 2016 at 4:09 AM, Ganapatrao Kulkarni > wrote: > > dt node parsing for numa topology is done using device property > > numa-node-id and device node distance-map. > > How is it that powerpc doesn't need flat DT

Re: [PATCH v10 0/8] arm64, numa: Add numa support for arm64 platforms

edundant NODE_DATA macro from asm header > files. I have tested the whole series on single and dual node systems for devicetree and acpi (with Hanjun's acpi numa v3 patches ported on top). Tested-by: Robert Richter <rrich...@cavium.com> -Robert > > Documentation/devicetree/bin

Re: [PATCH v13 04/14] perf, tools: Allow events with dot

On 03.06.15 12:32:04, Jiri Olsa wrote: On Tue, Jun 02, 2015 at 10:12:04AM -0700, Sukadev Bhattiprolu wrote: From: Andi Kleen a...@linux.intel.com The Intel events use a dot to separate event name and unit mask. Allow dot in names in the scanner, and remove special handling of dot as

Re: [PATCH 1/2] oprofile: Disable oprofile NMI timer on ppc64

symbols (eg cpu_khz). Modify the config entry for OPROFILE_NMI_TIMER to disable it on PPC64. Signed-off-by: Anton Blanchard an...@samba.org Acked-by: Robert Richter r...@kernel.org Please pass this patch along with patch 2 of this series (ppc tree or so). Thanks, -Robert --- arch

Re: [PATCH 1/2] oprofile: Add HAVE_OPROFILE_NMI_TIMER

On 21.01.15 22:54:08, Anton Blanchard wrote: HAVE_PERF_EVENTS_NMI is used for two things - the oprofile NMI timer and the hard lockup detector. Create HAVE_OPROFILE_NMI_TIMER so an architecture can select them separately. On ppc64 we want to add the hard lockup detector, but not the

Re: perf: POWER-event translation questions

On 09.11.12 11:26:26, Stephane Eranian wrote: On Thu, Nov 8, 2012 at 2:10 AM, Sukadev Bhattiprolu suka...@linux.vnet.ibm.com wrote: 2. Can we allow hyphens in the {name} token (please see my change to util/parse-events.l below). With this change, I can run: The current code does not

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

Sukadev, On 15.10.12 17:55:34, Robert Richter wrote: On 11.10.12 18:28:39, Sukadev Bhattiprolu wrote: + { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_STALLED_CYCLES_FIXED_POINT }, + { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_STALLED_CYCLES_LOAD_STORE

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

On 11.10.12 18:28:39, Sukadev Bhattiprolu wrote: + { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_STALLED_CYCLES_FIXED_POINT }, + { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_STALLED_CYCLES_LOAD_STORE }, + { .type = PERF_TYPE_HARDWARE, .config =

Re: oprofile callgraph support missing for common cpus

On 17.11.11 22:27:46, Joakim Tjernlund wrote: For my e300c2 cpu both if's are false and I don't get support for callgraph/backtrace support. Moving the ops-backtrace = op_powerpc_backtrace; to the top enables backtrace for me. It sure seems to work :) Backtrace support also works

Re: [PATCH] oprofile, powerpc: Handle events that raise an exception without overflowing

On 23.05.11 10:22:40, Eric B Munson wrote: Commit 0837e3242c73566fc1c0196b4ec61779c25ffc93 fixes a situation on POWER7 where events can roll back if a specualtive event doesn't actually complete. This can raise a performance monitor exception. We need to catch this to ensure that we reset

Re: [PATCH] powerpc/oprofile: fix potential buffer overrun in op_model_cell.c

On 01.06.10 15:43:34, Denis Kirjanov wrote: Fix potential initial_lfsr buffer overrun. Writing past the end of the buffer could happen when index == ENTRIES Signed-off-by: Denis Kirjanov dkirja...@kernel.org Patch applied to git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git

Re: [Patch 0/3] Overview, OProfile SPU event profiling support for IBM Cell processor

On 12.01.09 08:15:27, Carl Love wrote: On Sun, 2009-01-11 at 10:31 +1100, Benjamin Herrenschmidt wrote: On Thu, 2009-01-08 at 16:26 -0800, Carl Love wrote: I pulled down the git tree, compiled and installed it. I tested it against the OProfile testsuite, which includes SPU event

Re: [Patch 0/3] Overview, OProfile SPU event profiling support for IBM Cell processor

On 08.01.09 16:26:31, Carl Love wrote: git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git cell The patches did not apply cleanly. I had to change the path to arch/powerpc/include/asm/, fix cell/pr_util.h and did some whitespace cleanups. Please run your tests on the cell

Re: [Patch 0/3] Overview, OProfile SPU event profiling support for IBM Cell processor

On 01.12.08 16:18:26, Carl Love wrote: This is a rework of the previously posted set of patches. Patch 1 is the user level patch to add the SPU events to the user OProfile tool. Patch 2 is a kernel patch to do code clean up and restructuring to make it easier to add the new SPU event

Re: [UPDATED PATCH VER2] Cell OProfile: Incorrect local array size in activate spu profiling function

On 29.10.08 08:06:45, Carl Love wrote: Updated the patch to address comments by Michael Ellerman. Specifically, changed upper limit in for loop to ARRAY_SIZE() macro and added a check to make sure the number of events specified by the user, which is used as the max for indexing various

Re: [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function

On 24.10.08 11:47:29, Carl Love wrote: The size of the pm_signal_local array should be equal to the number of SPUs being configured in the call. Currently, the array is of size 4 (NR_PHYS_CTRS) but being indexed by a for loop from 0 to 7 (NUM_SPUS_PER_NODE). Signed-off-by: Carl Love

Re: [git pull] Please pull from powerpc.git next branch

Ben, there are still these OProfile patches for powerpc pending: Carl Love (1): powerpc/cell/oprofile: fix mutex locking for spu-oprofile Roel Kluin (1): powerpc/cell/oprofile: vma_map: fix test on overlay_tbl_offset Can you or Paul send them upstream? You can pull from here:

Re: [Cbe-oss-dev] powerpc/cell/oprofile: fix mutex locking for spu-oprofile

On 13.10.08 16:53:28, Arnd Bergmann wrote: On Monday 25 August 2008, Arnd Bergmann wrote: On Monday 25 August 2008, Paul Mackerras wrote: Since rc4 is out now, I understand if you feel more comfortable with putting the patch into -next instead of -merge. Linus has been

Re: [PATCH] powerpc/cell/oprofile: vma_map: fix test on overlay_tbl_offset

On 07.10.08 10:38:33, Arnd Bergmann wrote: From: Roel Kluin [EMAIL PROTECTED] Offset is unsigned and when an address isn't found in the vma map vma_map_lookup() returns the vma physical address + 0x1000. vma_map_lookup used to return 0x on a failed lookup, but a change was

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

I am fine with the changes with the exception of removing add_event_entry() from include/linux/oprofile.h. Though there is no usage of the function also in other architectures anymore, this change in the API should be discussed on the oprofile mailing list. Please separate the change in a

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

On 20.08.08 14:05:31, Arnd Bergmann wrote: On Wednesday 20 August 2008, Robert Richter wrote: I am fine with the changes with the exception of removing add_event_entry() from include/linux/oprofile.h. Though there is no usage of the function also in other architectures anymore, this change

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

-by: Carl Love [EMAIL PROTECTED] Signed-off-by: Maynard Johnson [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Acked-by: Robert Richter [EMAIL PROTECTED] -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: [EMAIL PROTECTED

Re: powerpc/cell/oprofile: avoid double free of profile buffer

. This results in a kernel oops. The following changes prevent the call to delete buffers that don't exist. Signed-off-by: Carl Love [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Acked-by: Robert Richter [EMAIL PROTECTED] -Robert -- Advanced Micro Devices, Inc. Operating System