Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

asami Hiramatsu > Cc: Mathieu Desnoyers > Cc: Linus Torvalds > Cc: Julia Lawall > Signed-off-by: Steven Rostedt (Google) For the sound part Acked-by: Takashi Iwai thanks, Takashi

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

On Wed, 15 May 2024 11:50:52 +0200, Jaroslav Kysela wrote: > > On 15. 05. 24 11:17, Hans Verkuil wrote: > > Hi Jaroslav, > > > > On 5/13/24 13:56, Jaroslav Kysela wrote: > >> On 09. 05. 24 13:13, Jaroslav Kysela wrote: > >>> On 09. 05. 24 12:44, Shengjiu Wang wrote: > >> mem2mem is just like

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

On Wed, 01 May 2024 03:56:15 +0200, Mark Brown wrote: > > On Tue, Apr 30, 2024 at 05:27:52PM +0100, Mauro Carvalho Chehab wrote: > > Mark Brown escreveu: > > > On Tue, Apr 30, 2024 at 10:21:12AM +0200, Sebastian Fricke wrote: > > > > The discussion around this originally was that all the audio

Re: [PATCH 1/1] ALSA: aoa: soundbus: i2sbus: pcm: use 'time_left' variable with wait_for_completion_timeout()

On Tue, 30 Apr 2024 14:10:27 +0200, Wolfram Sang wrote: > > There is a confusing pattern in the kernel to use a variable named 'timeout' > to > store the result of wait_for_completion_timeout() causing patterns like: > > timeout = wait_for_completion_timeout(...) > if (!timeout)

Re: [PATCH 8/9] ALSA: aoa: avoid false-positive format truncation warning

On Tue, 26 Mar 2024 23:38:07 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang warns about what it interprets as a truncated snprintf: > > sound/aoa/soundbus/i2sbus/core.c:171:6: error: 'snprintf' will always be > truncated; specified size is 6, but format string expands to at

Re: [PATCH] ASoC: soc-card: Fix missing locking in snd_soc_card_get_kcontrol()

On Wed, 21 Feb 2024 13:37:10 +0100, Richard Fitzgerald wrote: > > snd_soc_card_get_kcontrol() must be holding a read lock on > card->controls_rwsem while walking the controls list. > > Compare with snd_ctl_find_numid(). > > The existing function is renamed snd_soc_card_get_kcontrol_locked() >

Re: [PATCH 0/2] ALSA: struct bus_type cleanup

l.org/lkml/?q=f%3Agregkh%40linuxfoundation.org+s%3A%22make%22+and+s%3A%22const%22 > > To: Johannes Berg > To: Jaroslav Kysela > To: Takashi Iwai > Cc: > Cc: > Cc: > Cc: > Cc: Greg Kroah-Hartman > Signed-off-by: Ricardo B. Marliere > > --- > Ricardo B

Re: [PATCH] ALSA: aoa: Replace asm/prom.h with explicit includes

On Tue, 03 Oct 2023 18:32:02 +0200, Rob Herring wrote: > > asm/prom.h should not be included directly as it no longer contains > anything drivers need. Drivers should include of.h and/or other headers > which were getting implicitly included. > > Signed-off-by: Rob Herring Applied now to

Re: [RFC PATCH v2 0/7] Add audio support in v4l2 framework

On Fri, 25 Aug 2023 05:46:43 +0200, Shengjiu Wang wrote: > > On Fri, Aug 25, 2023 at 4:21 AM Mark Brown wrote: > > > > On Thu, Aug 24, 2023 at 07:03:09PM +0200, Takashi Iwai wrote: > > > Shengjiu Wang wrote: > > > > > > But there are several issues:

Re: [RFC PATCH v2 0/7] Add audio support in v4l2 framework

On Wed, 23 Aug 2023 16:33:19 +0200, Shengjiu Wang wrote: > > On Fri, Aug 11, 2023 at 7:05 PM Shengjiu Wang wrote: > > > > Hi Mark, Takashi > > > > On Thu, Aug 3, 2023 at 9:11 PM Shengjiu Wang > > wrote: > > > > > > On Thu, Aug 3, 2023 at 1:28 AM Mark Brown wrote: > > > > > > > > On Wed, Aug

Re: [RFC PATCH v2 0/7] Add audio support in v4l2 framework

On Wed, 02 Aug 2023 14:02:29 +0200, Shengjiu Wang wrote: > > On Wed, Aug 2, 2023 at 7:22 PM Takashi Iwai wrote: > > > > On Wed, 02 Aug 2023 09:32:37 +0200, > > Hans Verkuil wrote: > > > > > > Hi all, > > > > > > On 25/07/2023 08:

Re: [RFC PATCH v2 0/7] Add audio support in v4l2 framework

On Wed, 02 Aug 2023 09:32:37 +0200, Hans Verkuil wrote: > > Hi all, > > On 25/07/2023 08:12, Shengjiu Wang wrote: > > Audio signal processing has the requirement for memory to > > memory similar as Video. > > > > This patch is to add this support in v4l2 framework, defined > > new buffer type

Re: [PATCH 1/6] media: v4l2: Add audio capture and output support

On Mon, 03 Jul 2023 15:12:55 +0200, Hans Verkuil wrote: > > On 03/07/2023 14:53, Mark Brown wrote: > > On Mon, Jul 03, 2023 at 02:07:10PM +0200, Takashi Iwai wrote: > >> Shengjiu Wang wrote: > > > >>> There is no such memory to memory interface defined in

Re: [PATCH 1/6] media: v4l2: Add audio capture and output support

On Mon, 03 Jul 2023 11:54:22 +0200, Shengjiu Wang wrote: > > > Hi Sakari > > On Fri, Jun 30, 2023 at 6:05 PM Sakari Ailus wrote: > > Hi Shengjiu, > > On Thu, Jun 29, 2023 at 09:37:48AM +0800, Shengjiu Wang wrote: > > Audio signal processing has the requirement for memory to >

Re: [PATCH] sound: Switch i2c drivers back to use .probe()

On Thu, 25 May 2023 22:36:40 +0200, Uwe Kleine-König wrote: > > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert > back to (the

Re: [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void

t; There are nearly no interdependencies in this patch set---only 1 <- 11 and > 2 <- 16. So even if some individual problems are found (I don't expect that), > the other patches can (and from my POV should) still be applied. > > Best regards > Uwe > > Uwe Kleine-König (173): (snip) For the whole series, Acked-by: Takashi Iwai thanks, Takashi

Re: [PATCH 0/3] ALSA: core: Make some functions return void

On Tue, 07 Feb 2023 20:19:04 +0100, Uwe Kleine-König wrote: > > Hello, > > while checking in which cases hda_tegra_remove() can return a non-zero value, > I > found that actually cannot happen. This series makes the involved functions > return void to make this obvious. > > This is a

Re: [PATCH v2] ALSA: aoa: make remove callback of soundbus driver void returned

On Fri, 06 Jan 2023 16:17:46 +0100, Dawei Li wrote: > > Since commit fc7a6209d571 ("bus: Make remove callback return void") > forces bus_type::remove be void-returned, it doesn't make much sense > for any bus based driver implementing remove callbalk to return > non-void to its caller. > > As

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

On Thu, 01 Dec 2022 14:22:12 +0100, Oliver Neukum wrote: > > On 01.12.22 14:03, Ricardo Ribalda wrote: > > Hi, > > > This patchset does not modify this behaviour. It simply fixes the > > stall for kexec(). > > > > The patch that introduced the stall: > > 83bfc7e793b5 ("ASoC: SOF: core:

Re: [PATCH 598/606] ALSA: aoa: tas: Convert to i2c's .probe_new()

On Fri, 18 Nov 2022 23:45:32 +0100, Uwe Kleine-König wrote: > > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Applied to for-next branch. thanks, Takashi

Re: [PATCH 597/606] ALSA: aoa: onyx: Convert to i2c's .probe_new()

On Fri, 18 Nov 2022 23:45:31 +0100, Uwe Kleine-König wrote: > > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Applied now to for-next branch. thanks, Takashi

Re: [PATCH] ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()

On Thu, 27 Oct 2022 09:41:03 +0200, Yang Yingliang wrote: > > > On 2022/10/27 14:38, Takashi Iwai wrote: > > On Thu, 27 Oct 2022 03:34:38 +0200, > > Yang Yingliang wrote: > >> dev_set_name() in soundbus_add_one() allocates memory for name, it need be > >>

Re: [PATCH] ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()

On Thu, 27 Oct 2022 03:34:38 +0200, Yang Yingliang wrote: > > dev_set_name() in soundbus_add_one() allocates memory for name, it need be > freed when of_device_register() fails, call soundbus_dev_put() to give up > the reference that hold in device_initialize(), so that it can be freed in >

Re: [PATCH 1/1] ALSA: aoa: remove unnecessary oom message

On Thu, 17 Jun 2021 12:27:45 +0200, Zhen Lei wrote: > > Fixes scripts/checkpatch.pl warning: > WARNING: Possible unnecessary 'out of memory' message > > Remove it can help us save a bit of memory. > > Signed-off-by: Zhen Lei Thanks, applied. Takashi

Re: [PATCH] ALSA: ppc: keywest: remove outdated comment

On Wed, 10 Mar 2021 20:32:27 +0100, Wolfram Sang wrote: > > The I2C attach_adapter callback is gone. Remove this reference. > > Signed-off-by: Wolfram Sang Applied, thanks. Takashi

Re: [PATCH] sound: pps: fix spelling typo of values

On Tue, 02 Mar 2021 04:40:53 +0100, dingsen...@163.com wrote: > > From: dingsenjie > > vaules -> values > > Signed-off-by: dingsenjie Thanks, applied. Takashi

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

On Wed, 02 Dec 2020 13:14:06 +0100, Michael Ellerman wrote: > > Uwe Kleine-König writes: > > Hello Michael, > > > > On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote: > >> On Thu, 26 Nov 2020 17:59:50 +0100, > >> Uwe Kleine-König wro

Re: [PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe

On Fri, 27 Nov 2020 16:22:59 +0100, Leonard Goehrs wrote: > > The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed > in ps3_system_bus_init() before registering the driver. So if the probe > function is actually used, this feature is already known to be available. > > The

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

; accordingly. > > Signed-off-by: Uwe Kleine-König For the sound bit: Acked-by: Takashi Iwai thanks, Takashi > --- > arch/powerpc/include/asm/ps3.h | 4 ++-- > arch/powerpc/platforms/ps3/system-bus.c | 5 ++--- > drivers/block/ps3disk.c

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

On Thu, 26 Nov 2020 17:59:49 +0100, Uwe Kleine-König wrote: > > The remove callback is only called for devices that were probed > successfully before. As the matching probe function cannot complete > without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to > check this here. > >

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

On Tue, 01 Sep 2020 12:04:53 +0200, Allen wrote: > > Takashi, > > > > > These patches which I wasn't CCed on and which need their subject > > > > > lines > > > > > fixing :( . With the subject lines fixed I guess so so > > > > > > > Extremely sorry. I thought I had it covered. How would you

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

On Wed, 19 Aug 2020 13:16:05 +0200, Mark Brown wrote: > > On Wed, Aug 19, 2020 at 04:21:58PM +0530, Allen wrote: > > > > These patches which I wasn't CCed on and which need their subject lines > > > fixing :( . With the subject lines fixed I guess so so > > > Extremely sorry. I thought I had

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

On Tue, 18 Aug 2020 12:44:32 +0200, Mark Brown wrote: > > On Tue, Aug 18, 2020 at 12:25:31PM +0200, Takashi Iwai wrote: > > > Mark, may I apply those ASoC patches through my tree together with > > others? Those seem targeting to 5.9, and I have a patch set to > >

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

On Mon, 17 Aug 2020 10:56:53 +0200, Allen Pais wrote: > > From: Allen Pais > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > introduced a new tasklet initialization API. This series converts > all the sound drivers to use the new tasklet_setup() API > > Allen Pais (10):

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

On Mon, 17 Aug 2020 11:18:53 +0200, Allen Pais wrote: > > > > > Is this targeted for 5.9 or 5.10? > > This is targeted for 5.9. Well, then at the next time, please mention it explicitly in the cover letter. Usually this kind of API conversion isn't done during rc. Or it's done systematically

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

On Mon, 17 Aug 2020 10:56:53 +0200, Allen Pais wrote: > > From: Allen Pais > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > introduced a new tasklet initialization API. This series converts > all the sound drivers to use the new tasklet_setup() API Is this targeted for

Re: [PATCH -next] ALSA: sound/ppc: Use bitwise instead of arithmetic operator for flags

On Thu, 07 May 2020 05:54:07 +0200, Samuel Zou wrote: > > Fix the following coccinelle warnings: > > sound/ppc/pmac.c:729:57-58: WARNING: sum of probable bitmasks, consider | > sound/ppc/pmac.c:229:37-38: WARNING: sum of probable bitmasks, consider | > > Reported-by: Hulk Robot >

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

On Wed, 01 Apr 2020 12:35:16 +0200, Michael Ellerman wrote: > > Michal Simek writes: > > On 01. 04. 20 4:07, Michael Ellerman wrote: > >> Michal Simek writes: > >>> Hi, > >>> > >>> recently we wanted to update xilinx intc driver and we found that function > >>> which we wanted to remove is

[PATCH] hwmon: (ibmpowernv) Use scnprintf() for avoiding potential buffer overflow

Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Signed-off-by: Takashi Iwai --- drivers/hwmon/ibmpowernv.c | 8 1 file changed, 4 insertions(+), 4

Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

On Mon, 04 Nov 2019 09:49:43 +0100, Greg Kroah-Hartman wrote: > > On 11/4/19 9:32 AM, Greg Kroah-Hartman wrote: > > On 11/4/19 9:27 AM, youling 257 wrote: > > > This driver > > >

Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

On Mon, 04 Nov 2019 08:06:37 +0100, youling 257 wrote: > > This patch cause oops on android mainline kernel about gadget audio_source. > Androidx86 run on android mainline kernel. > > [ 385.104963] android_work: sent uevent USB_STATE=CONNECTED > [ 385.109006] android_work: sent uevent

Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

On Tue, 06 Aug 2019 07:29:49 +0200, Christoph Hellwig wrote: > > On Mon, Aug 05, 2019 at 11:22:03AM +0200, Takashi Iwai wrote: > > This won't work as expected, unfortunately. It's a bit tricky check, > > since the driver may have its own mmap implementation via > &

Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

On Mon, 05 Aug 2019 11:11:56 +0200, Christoph Hellwig wrote: > > Replace the local hack with the dma_can_mmap helper to check if > a given device supports mapping DMA allocations to userspace. > > Signed-off-by: Christoph Hellwig > --- > sound/core/pcm_native.c | 5 ++--- > 1 file changed, 2

Re: [PATCH 5/5] dma-mapping: remove ARCH_NO_COHERENT_DMA_MMAP

On Sat, 03 Aug 2019 12:30:24 +0200, Christoph Hellwig wrote: > > On Fri, Aug 02, 2019 at 10:24:02AM +0200, Takashi Iwai wrote: > > I wasn't careful enough to look at that change, sorry. > > > > The code there tries to check whether dma_mmap_coherent() would always &g

Re: [PATCH 5/5] dma-mapping: remove ARCH_NO_COHERENT_DMA_MMAP

On Fri, 02 Aug 2019 09:03:54 +0200, Christoph Hellwig wrote: > > Takashi, > > any comments on the sounds/ side of this? I wasn't careful enough to look at that change, sorry. The code there tries to check whether dma_mmap_coherent() would always fail on some platforms. Then the driver clears

Re: [PATCH] sound: ppc: snd_ps3: Remove Unneeded variable: "ret"

On Wed, 10 Jul 2019 04:39:46 +0200, Hariprasad Kelam wrote: > > This patch fixes below issue reported by coccicheck > sound/ppc/snd_ps3.c:631:5-8: Unneeded variable: "ret". Return "0" on > line 668 > > We cannot change return type of snd_ps3_pcm_trigger as it is registered > with

Re: [alsa-devel] [PATCH v2 27/27] sound: ppc: remove unneeded memset after dma_alloc_coherent

On Fri, 28 Jun 2019 11:11:08 +0200, Fuqian Huang wrote: > > The merge commit log tells (dma-mapping: zero memory returned from > dma_alloc_* and deprecating the dma_zalloc_coherent). > I used this commit just want to say that dma_alloc_coherent has > zeroed the allocated memory. > Sorry for this

Re: [PATCH 41/87] sound: ppc: remove memset after dma_alloc_coherent

On Fri, 28 Jun 2019 10:54:34 +0200, Takashi Iwai wrote: > > On Fri, 28 Jun 2019 10:53:14 +0200, > Christophe Leroy wrote: > > > > > > > > Le 28/06/2019 à 10:48, Takashi Iwai a écrit : > > > On Thu, 27 Jun 2019 19:40:17 +0200, > > > Fuqia

Re: [PATCH 41/87] sound: ppc: remove memset after dma_alloc_coherent

On Fri, 28 Jun 2019 10:53:14 +0200, Christophe Leroy wrote: > > > > Le 28/06/2019 à 10:48, Takashi Iwai a écrit : > > On Thu, 27 Jun 2019 19:40:17 +0200, > > Fuqian Huang wrote: > >> > >> In commit af7ddd8a627c > >> ("Merge tag 'dma-mapp

Re: [PATCH 41/87] sound: ppc: remove memset after dma_alloc_coherent

On Thu, 27 Jun 2019 19:40:17 +0200, Fuqian Huang wrote: > > In commit af7ddd8a627c > ("Merge tag 'dma-mapping-4.21' of > git://git.infradead.org/users/hch/dma-mapping"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. > > Signed-off-by: Fuqian Huang Applied,

Re: [PATCH -next] ALSA: ps3: Remove set but not used variables 'start_vaddr' and 'pcm_index'

On Wed, 17 Apr 2019 20:19:30 +0200, Geoff Levand wrote: > > On 4/17/19 7:57 AM, Yue Haibing wrote: > > From: YueHaibing > > > > Fixes gcc '-Wunused-but-set-variable' warnings: > > > > sound/ppc/snd_ps3.c: In function 'snd_ps3_program_dma': > > sound/ppc/snd_ps3.c:236:8: warning: variable

Re: [PATCH] ALSA: Use of_node_name_eq for node name comparisons

verted > to use for_each_child_of_node() instead. > > Cc: Johannes Berg > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: linuxppc-dev@lists.ozlabs.org > Cc: alsa-de...@alsa-project.org > Signed-off-by: Rob Herring Applied, thanks. Takashi

Re: [PATCH] ALSA: soundbus: Remove direct OF name and type accesses

e > pointers. > > Cc: Johannes Berg > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: linuxppc-dev@lists.ozlabs.org > Cc: alsa-de...@alsa-project.org > Signed-off-by: Rob Herring Applied, thanks. Takashi

Re: [PATCH] ALSA: aoa: Use device_type helpers to access the node type

node() while we're here. > > Cc: Johannes Berg > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: linuxppc-dev@lists.ozlabs.org > Cc: alsa-de...@alsa-project.org > Signed-off-by: Rob Herring Applied, thanks. Takashi

Re: [alsa-devel] Build regressions/improvements in v4.20-rc1 (sound/pci/hda/patch_ca0132.c)

On Wed, 07 Nov 2018 09:44:25 +0100, Geert Uytterhoeven wrote: > > Hi Iwai-san, > > On Tue, Nov 6, 2018 at 5:18 PM Takashi Iwai wrote: > > On Tue, 06 Nov 2018 02:04:47 +0100, > > Randy Dunlap wrote: > > > > > > On 11/5/18 2:12 PM, Geert Uytterhoeven wrot

Re: [alsa-devel] Build regressions/improvements in v4.20-rc1 (sound/pci/hda/patch_ca0132.c)

e commit above should have covered the build failure on SH, but apparently isn't enough for some arch setups, as it seems. The cause is clear now: pci_iomap() is defined in asm-generic/pci_iomap.h only when CONFIG_GENERIC_PCI_IOMAP is defined. Including asm/io.h doesn't help unless CONFIG_PCI

Re: [alsa-devel] [PATCH v2] sound: Convert to using %pOFn instead of device_node.name

On Tue, 28 Aug 2018 17:44:31 +0200, Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Johannes Berg > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: linuxppc-d

Re: [PATCH] powerpc/ps3: Set driver coherent_dma_mask

ound bits, Reviewed-by: Takashi Iwai thanks, Takashi > --- > Hi Michael, > > This just silences some warnings. Can you take it through the powerpc > tree? > > -Geoff > > > drivers/usb/host/ehci-ps3.c | 6 -- > drivers/usb/host/ohci-ps3.c | 6

Re: [PATCH] ALSA: snd-aoa: add of_node_put() in error path

On Fri, 29 Jun 2018 19:07:42 +0200, Nicholas Mc Guire wrote: > > Both calls to of_find_node_by_name() and of_get_next_child() return a > node pointer with refcount incremented thus it must be explicidly > decremented here after the last usage. As we are assured to have a > refcounted np either

Re: [PATCH] sound: Use octal not symbolic permissions

On Wed, 23 May 2018 21:20:59 +0200, Joe Perches wrote: > > Convert the S_ symbolic permissions to their octal equivalents as > using octal and not symbolic permissions is preferred by many as more > readable. > > see: https://lkml.org/lkml/2016/8/2/1945 > > Done with automated conversion via: >

Re: [alsa-devel] [trivial PATCH] treewide: Align function definition open/close braces

| 6 +++--- > kernel/trace/trace_printk.c | 4 ++-- > lib/raid6/sse2.c | 14 +++--- > sound/soc/fsl/fsl_dma.c | 2 +- For sound bits, Acked-by: Takashi Iwai <ti...@suse.de> thanks, Takashi

Re: [alsa-devel] Applied "ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20" to the asoc tree

On Thu, 30 Nov 2017 11:41:59 +0100, Mark Brown wrote: > > On Wed, Nov 29, 2017 at 10:23:23PM +0100, Takashi Iwai wrote: > > > Mark, I already took this into my tree, as it's a change in ALSA core > > stuff. As mentioned in another mail, the branch was exposed to > >

Re: [alsa-devel] Applied "ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20" to the asoc tree

On Wed, 29 Nov 2017 20:00:01 +0100, Mark Brown wrote: > > The patch > >ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20 > > has been applied to the asoc tree at > >https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git > > All being well this means that it will be integrated into

Re: [PATCH v4 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20

On Mon, 27 Nov 2017 23:33:29 +0100, Maciej S. Szmigiero wrote: > > This format is similar to existing SNDRV_PCM_FORMAT_{S,U}20_3 that keep > 20-bit PCM samples in 3 bytes, however i.MX6 platform SSI FIFO does not > allow 3-byte accesses (including DMA) so a 4-byte (more conventional) > format

Re: [alsa-devel] [PATCH v3 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20

On Mon, 27 Nov 2017 00:09:47 +0100, Maciej S. Szmigiero wrote: > diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h > index 58acd00cae19..d970879944fc 100644 > --- a/include/sound/soc-dai.h > +++ b/include/sound/soc-dai.h > @@ -102,6 +102,8 @@ struct snd_compr_stream; >

Re: [PATCH 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20_4

On Wed, 22 Nov 2017 20:17:34 +0100, Maciej S. Szmigiero wrote: > > This format is similar to existing SNDRV_PCM_FORMAT_{S,U}20_3 that keep > 20-bit PCM samples in 3 bytes, however i.MX6 platform SSI FIFO does not > allow 3-byte accesses (including DMA) so a 4-byte format is needed for it. > >

Re: [PATCH v3] sound: aoa: Convert to using %pOF instead of full_name

ing > > of the full path string for each node. > > > > Signed-off-by: Rob Herring <r...@kernel.org> > > Cc: Johannes Berg <johan...@sipsolutions.net> > > Cc: Jaroslav Kysela <pe...@perex.cz> > > Cc: Takashi Iwai <ti...@suse.com> > > Cc: l

Re: [PATCH 00/12] ALSA: make snd_pcm_hardware const

On Thu, 17 Aug 2017 11:15:48 +0200, Bhumika Goyal wrote: > > Make these const. > > Bhumika Goyal (12): > ALSA: arm: make snd_pcm_hardware const > ALSA: atmel: make snd_pcm_hardware const > ALSA: drivers: make snd_pcm_hardware const > ALSA: isa: make snd_pcm_hardware const > ALSA: mips:

Re: [PATCH 0/3] ALSA: make snd_kcontrol_new const

On Wed, 16 Aug 2017 10:44:08 +0200, Bhumika Goyal wrote: > > Make these structures const. Done using Coccinelle. > > Bhumika Goyal (3): > ALSA: aoa: make snd_kcontrol_new const > ALSA: pcxhr: make snd_kcontrol_new const > ALSA: hda: make snd_kcontrol_new const Applied all three patches

Re: [PATCH v2] sound: Convert to using %pOF instead of full_name

r...@kernel.org> > Cc: Johannes Berg <johan...@sipsolutions.net> > Cc: Jaroslav Kysela <pe...@perex.cz> > Cc: Takashi Iwai <ti...@suse.com> > Cc: Timur Tabi <ti...@tabi.org> > Cc: Nicolin Chen <nicoleots...@gmail.com> > Cc: Xiubo Li <xiubo

Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure

Gustavo, please stop posting in this style. It's really annoying to see spontaneously popping-up almost same patch for more than two hours long. If you have a series of the same fix patches, send them as a patch set in a shot with a thread. git-send-email does it right. I don't mind a couple

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

On Tue, 30 May 2017 10:56:39 +0200, Julia Lawall wrote: > > > > On Tue, 30 May 2017, Takashi Iwai wrote: > > > On Sat, 27 May 2017 16:46:15 +0200, > > Bhumika Goyal wrote: > > > > > > Declare snd_kcontrol_new structures as const as they are

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

On Sat, 27 May 2017 16:46:15 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using

Re: [PATCH] ALSA: squash lines for simple wrapper functions

On Tue, 06 Sep 2016 13:41:19 +0200, Masahiro Yamada wrote: > > Remove unneeded variables and assignments. > > Signed-off-by: Masahiro Yamada Applied, thanks. Takashi > --- > > sound/aoa/fabrics/layout.c | 7 +-- >

Re: [alsa-devel] [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12"

On Wed, 24 Aug 2016 22:35:58 +0200, Aaro Koskinen wrote: > > Hi, > > On Wed, Aug 24, 2016 at 09:43:23PM +0200, Johannes Berg wrote: > > On Wed, 2016-08-24 at 20:57 +0300, Aaro Koskinen wrote: > > > Enable sound on PowerBook G4 12". > > > > Looks good to me, I assume you tested it and it works

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Fri, 04 Dec 2015 18:02:58 +0100, Jens Axboe wrote: > > On 12/04/2015 09:59 AM, Takashi Iwai wrote: > > On Wed, 25 Nov 2015 20:01:47 +0100, > > Hannes Reinecke wrote: > >> > >> On 11/25/2015 07:01 PM, Mike Snitzer wrote: > >>> On Wed, Nov 25

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Wed, 25 Nov 2015 20:01:47 +0100, Hannes Reinecke wrote: > > On 11/25/2015 07:01 PM, Mike Snitzer wrote: > > On Wed, Nov 25 2015 at 4:04am -0500, > > Hannes Reinecke wrote: > > > >> On 11/20/2015 04:28 PM, Ewan Milne wrote: > >>> On Fri, 2015-11-20 at 15:55 +0100, Hannes

Re: [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver

On Fri, 10 Jul 2015 08:39:02 +0200, Krzysztof Kozlowski wrote: i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Applied, thanks. Takashi --- The coccinelle script which generated the

Re: [PATCH v3] ALSA: aoa: convert bus code to use dev_groups

At Fri, 12 Jun 2015 12:01:42 +0200, Quentin Lambert wrote: On 12/06/2015 11:59, Andreas Schwab wrote: Quentin Lambert lambert.quen...@gmail.com writes: The dev_attrs field of struct bus_type is going away, sue dev_groups instead. s/sue/use/ I meant use do you need to fix

Re: [alsa-devel] [PATCH v2] ALSA: aoa: convert bus code to use dev_groups

At Thu, 11 Jun 2015 10:03:38 +0200, Quentin Lambert wrote: The dev_attrs field of struct bus_type is going away, use dev_groups instead. This converts the soundbus code to use the correct field. Given that all other usages of the macro define the struct attribute *xxx_attrs[] in the same

Re: [alsa-devel] [PATCH v2] ALSA: aoa: convert bus code to use dev_groups

At Thu, 11 Jun 2015 14:04:45 +0200, Quentin Lambert wrote: On 11/06/2015 12:02, Takashi Iwai wrote: At Thu, 11 Jun 2015 10:03:38 +0200, Quentin Lambert wrote: The dev_attrs field of struct bus_type is going away, use dev_groups instead. This converts the soundbus code to use

Re: [alsa-devel] [RFC] sound: ppc: keywest: check if DEQ was already instantiated

At Fri, 29 May 2015 20:06:09 +0900, Wolfram Sang wrote: Do you think from which stable kernel version can this be applied? The offending commit is 3a3dd0186f619b74e61e6f29dddcaf59af7d3cac (i2c/powermac: Improve detection of devices from device-tree) which came in with v3.6 if I read

Re: [alsa-devel] [RFC] sound: ppc: keywest: check if DEQ was already instantiated

At Fri, 29 May 2015 19:50:22 +0900, Wolfram Sang wrote: On Thu, May 28, 2015 at 09:33:27AM +0200, Takashi Iwai wrote: At Tue, 26 May 2015 02:19:34 -0700, Dan DeVoto wrote: Hi, I applied this patch (check if DEQ was already instantiated) on top of sound: ppc: keywest: drop

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

At Fri, 29 May 2015 17:49:06 +0200, Quentin Lambert wrote: On 28/05/2015 17:01, Takashi Iwai wrote: Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into soundbus/sysfs.c, and make it this global instead of soundbus_dev_attrs[]. Ok, I need to find a nice way to do

Re: [alsa-devel] [RFC] sound: ppc: keywest: check if DEQ was already instantiated

At Tue, 26 May 2015 02:19:34 -0700, Dan DeVoto wrote: Hi, I applied this patch (check if DEQ was already instantiated) on top of sound: ppc: keywest: drop using attach adapter and sound works great. Everything works as expected. Below is my dmesg output. Very well, shall I merge the

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use the correct field. These modifications were made using Coccinelle. Signed-off-by: Quentin Lambert

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

At Thu, 28 May 2015 16:43:12 +0200, Quentin Lambert wrote: On 28/05/2015 16:09, Takashi Iwai wrote: At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use

Re: [alsa-devel] [PATCH RESEND] sound: ppc: keywest: drop using attach adapter

At Sat, 9 May 2015 19:42:22 +0200, Wolfram Sang wrote: As we now have deferred probing, we can use a custom mechanism and finally get rid of this legacy interface from the i2c core. Signed-off-by: Wolfram Sang w...@the-dreams.de Tested-by: Dan DeVoto dand1...@yahoo.com Tested-by: Mark

Re: [alsa-devel] [PATCH 1/7 linux-next] ALSA: aoa: constify of_device_id array

At Wed, 18 Mar 2015 17:48:56 +0100, Fabian Frederick wrote: of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick f...@skynet.be Thanks, applied this one. The rest ASoC patches are left to Mark. Takashi ---

Re: [alsa-devel] [RFC 2/2] sound: ppc: keywest: drop using attach adapter

At Thu, 4 Dec 2014 17:41:53 +0100, Wolfram Sang wrote: As we now have deferred probing, we can use a custom mechanism and finally get rid of the legacy interface from the i2c core. Signed-off-by: Wolfram Sang w...@the-dreams.de --- sound/ppc/keywest.c | 21 ++--- 1 file

Re: [PATCH] ALSA: i2sbus: Deletion of unnecessary checks before the function call release_and_free_resource

At Tue, 02 Dec 2014 22:55:57 +0100, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Tue, 2 Dec 2014 22:50:24 +0100 The release_and_free_resource() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

of maintainership, how do you want to proceed ? I'm happy to merge the whole lot via powerpc ASAP (since it's all CC'ed stable) if you guys send me the appropriate acks, otherwise, let me know. Feel free to merge through your tree. Reviewed-by: Takashi Iwai ti...@suse.de thanks, Takashi

Re: [PATCH v2 3/4] sound/radeon: Move 64-bit MSI quirk from arch to driver

: sta...@vger.kernel.org The attached updated patch only flags the affected asics. Alex's patch looks more comprehensive. For either patch, Reviewed-by: Takashi Iwai ti...@suse.de thanks, Takashi Alex --- arch/powerpc/kernel/pci_64.c | 6 -- sound/pci/hda/hda_intel.c| 10

Re: [PATCH 4/4] sounds/hda/radeon: Disable 64-bit DMA on radeon

At Wed, 01 Oct 2014 12:09:53 +1000, Benjamin Herrenschmidt wrote: The chipset has a limitation in the number of address bits it can generate. The graphics portion uses a specific mask of 40 or 48 bits depending on the generation. For audio, it's a bit less of an issue, so just mark them as

Re: [PATCH 4/4] sounds/hda/radeon: Disable 64-bit DMA on radeon

At Wed, 01 Oct 2014 17:41:29 +1000, Benjamin Herrenschmidt wrote: On Wed, 2014-10-01 at 09:38 +0200, Takashi Iwai wrote: diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 3e6d22d..2b679d5 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c

Re: [PATCH 4/4] sounds/hda/radeon: Disable 64-bit DMA on radeon

At Wed, 01 Oct 2014 10:09:28 +0200, Takashi Iwai wrote: At Wed, 01 Oct 2014 17:41:29 +1000, Benjamin Herrenschmidt wrote: On Wed, 2014-10-01 at 09:38 +0200, Takashi Iwai wrote: diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 3e6d22d..2b679d5 100644

Re: [PATCH] sound: aoa: printk replacement

At Wed, 10 Sep 2014 20:02:04 +0530, Sudip Mukherjee wrote: On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros. Are

Re: [PATCH] sound: aoa: printk replacement

At Wed, 10 Sep 2014 20:37:50 +0530, Sudip Mukherjee wrote: On Wed, Sep 10, 2014 at 04:43:03PM +0200, Takashi Iwai wrote: At Wed, 10 Sep 2014 20:02:04 +0530, Sudip Mukherjee wrote: On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: On Wed, 2014-09-10 at 19:21 +0530

Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

At Tue, 19 Aug 2014 09:00:06 +, li.xi...@freescale.com wrote: How about the following : diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 5ae777a..d42f18c 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -15,7 +15,7 @@ config SND_SOC_FSL_ASRC

  1   2   >