Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread Takashi Iwai
At Tue, 19 Aug 2014 09:00:06 +, li.xi...@freescale.com wrote: > > How about the following : > > > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig > index 5ae777a..d42f18c 100644 > --- a/sound/soc/fsl/Kconfig > +++ b/sound/soc/fsl/Kconfig > @@ -15,7 +15,7 @@ config SND_SOC_FSL_ASRC

Re: [PATCH -next 26/26] sound: Use dma_zalloc_coherent

2014-06-16 Thread Takashi Iwai
At Sun, 15 Jun 2014 13:37:55 -0700, Joe Perches wrote: > > Use the zeroing function instead of dma_alloc_coherent & memset(,0,) > > Signed-off-by: Joe Perches Applied, thanks. Takashi > --- > sound/aoa/soundbus/i2sbus/core.c | 12 > sound/sparc/dbri.c | 6 ++

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-13 Thread Takashi Iwai
At Thu, 12 Jun 2014 22:24:55 -0500, Timur Tabi wrote: > > On Thu, Dec 12, 2013 at 4:44 AM, Nicolin Chen > wrote: > > > > +static int fsl_ssi_set_dai_sysclk(struct snd_soc_dai *cpu_dai, > > + int clk_id, unsigned int freq, int dir) > > +{ > > + struct fsl_ssi_

Re: [patch] ALSA: snd-aoa: two copy and paste bugs

2013-11-13 Thread Takashi Iwai
At Wed, 13 Nov 2013 10:45:20 +0300, Dan Carpenter wrote: > > These functions were cut and paste and the tests for NULL weren't > updated properly. > > Signed-off-by: Dan Carpenter Thanks, applied. Takashi > > diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabrics/layout.c > index 61ab6

Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

2013-09-26 Thread Takashi Iwai
At Thu, 26 Sep 2013 10:25:13 +0200, Takashi Iwai wrote: > > At Thu, 26 Sep 2013 08:54:25 +0100, > Russell King - ARM Linux wrote: > > > > On Thu, Sep 26, 2013 at 09:51:23AM +0200, Takashi Iwai wrote: > > > Hi, > > > > > > sorry for the lat re

Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

2013-09-26 Thread Takashi Iwai
At Thu, 26 Sep 2013 08:54:25 +0100, Russell King - ARM Linux wrote: > > On Thu, Sep 26, 2013 at 09:51:23AM +0200, Takashi Iwai wrote: > > Hi, > > > > sorry for the lat response, as I've been traveling in the last weeks. > > > > At Thu, 19 Sep 20

Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

2013-09-26 Thread Takashi Iwai
Hi, sorry for the lat response, as I've been traveling in the last weeks. At Thu, 19 Sep 2013 22:53:02 +0100, Russell King wrote: > > This code sequence is unsafe in modules: > > static u64 mask = DMA_BIT_MASK(something); > ... > if (!dev->dma_mask) > dev->dma_mask = &mask;

Re: [PATCH] powerpc/ps3: Fix lv1_gpu_attribute hcall

2011-10-12 Thread Takashi Iwai
At Wed, 12 Oct 2011 11:42:13 -0700, Geoff Levand wrote: > > The lv1_gpu_attribute hcall takes three, not five input > arguments. Adjust the lv1 hcall table and all calls. > > Signed-off-by: Geoff Levand > CC: Takashi Iwai Acked-by: Takashi Iwai > --- > arch/power

Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED

2011-09-22 Thread Takashi Iwai
At Wed, 21 Sep 2011 11:55:36 +0200 (CEST), Thomas Gleixner wrote: > > > > We run all interrupt handlers with interrupts disabled > > > and we even check and yell when an interrupt handler > > > returns with interrupts enabled (see commit [b738a50a: > > > genirq: Warn when handler enables interrupt

Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED

2011-09-21 Thread Takashi Iwai
pplied safely in 3.1-based tree, right? Anyway, if needed, take my ack: Acked-by: Takashi Iwai thanks, Takashi > --- > include/sound/initval.h|2 +- > sound/arm/aaci.c |2 +- > sound/arm/pxa2xx-ac97-lib.c|2 +- > sound/driv

Re: [PATCH 4/4] sound/aoa/fabrics/layout.c: remove unneeded kfree

2011-08-20 Thread Takashi Iwai
At Sat, 20 Aug 2011 08:12:41 +0200, Julia Lawall wrote: > > From: Julia Lawall > > The label outnodev is only used when kzalloc has not yet taken place or has > failed, so there is no need for the call for kfree under this label. > > A simplified version of the semantic match that finds this pr

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

2011-03-25 Thread Takashi Iwai
At Fri, 25 Mar 2011 21:23:26 +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2011-03-25 at 11:12 +0100, Takashi Iwai wrote: > > At Fri, 25 Mar 2011 20:15:33 +1100, > > Benjamin Herrenschmidt wrote: > > > > > > > > We > > > > > must als

Re: ALSA: vmalloc buffers should use normal mmap

2011-03-25 Thread Takashi Iwai
;s > already hacks for MIPS inside snd_pcm_default_mmap() and other > archs are supposed to use dma_mmap_coherent(). > > (See my separate patch that adds dma_mmap_coherent() to powerpc) > > Signed-off-by: Benjamin Herrenschmidt > CC: Takashi Iwai Applied now to sound git tre

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

2011-03-25 Thread Takashi Iwai
At Fri, 25 Mar 2011 20:15:33 +1100, Benjamin Herrenschmidt wrote: > > > > We > > > must also make sure we don't go down that path for vmalloc memory > > > though. > > > > Yes. > > I haven't actually checked, but I assume that the test > > substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV > >

Re: [PATCH] powerpc: Implement dma_mmap_coherent()

2011-03-25 Thread Takashi Iwai
At Fri, 25 Mar 2011 20:11:57 +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2011-03-25 at 09:06 +0100, Takashi Iwai wrote: > > > @@ -52,6 +53,7 @@ extern void __dma_sync_page(struct page *page, > > unsigned long offset, > > > #define __dma_free_coherent(siz

Re: [PATCH] powerpc: Implement dma_mmap_coherent()

2011-03-25 Thread Takashi Iwai
At Fri, 25 Mar 2011 17:50:06 +1100, Benjamin Herrenschmidt wrote: > > This is used by Alsa to mmap buffers allocated with dma_alloc_coherent() > into userspace. We need a special variant to handle machines with > non-coherent DMAs as those buffers have "special" virt addresses and > require non-ca

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

2011-03-25 Thread Takashi Iwai
At Fri, 25 Mar 2011 09:16:48 +1100, Benjamin Herrenschmidt wrote: > > Hi Takashi ! > > While working on endian-fixing xHCI with Matt (CC), we discovered the > source of our problems with usb-audio on a board we were working on. > > c32d977b8157bf67cdf47729ce7dd054a26eb534 > "ALSA: pcm - Call pgp

Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module

2011-02-21 Thread Takashi Iwai
At Sun, 20 Feb 2011 22:38:28 +0100, Linux User #330250 wrote: > > Hello again! > > Sorry for sending the patch three times. (This is the fourth...) > > About the sign-off: I use the name I've been using since I started > participating. The document $LINUX/Documentation/SubmittingPatches clearly

Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module

2011-02-20 Thread Takashi Iwai
At Sat, 19 Feb 2011 15:53:46 +0100, Linux User #330250 wrote: > > Hello! > > About two years ago Johannes Berg wrote support for the PowerMac3,6 aka G4 > MDD > which I was using as a desktop computer then. Johannes wrote all the code, > and > I tested it. > > I now have a PowerMac3,5 – yes,

Re: [alsa-devel] [PATCH] sound/ppc/powermac: remove undefined operations

2010-09-14 Thread Takashi Iwai
At Sat, 11 Sep 2010 13:16:41 +0200, Andreas Schwab wrote: > > Modifying an object twice without an intervening sequence point is > undefined. > > Signed-off-by: Andreas Schwab Applied now. Thanks. Takashi > --- > sound/ppc/tumbler.c |2 +- > 1 files changed, 1 insertions(+), 1 deletion

Re: [PATCH 11/11] sound: Remove pr_ uses of KERN_

2010-09-13 Thread Takashi Iwai
At Sat, 11 Sep 2010 22:10:59 -0700, Joe Perches wrote: > > Signed-off-by: Joe Perches Applied to sound git tree now. Thanks. Takashi > --- > sound/ppc/snd_ps3.c |2 +- > sound/soc/s3c24xx/s3c-dma.c |3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

2009-10-04 Thread Takashi Iwai
At Sun, 4 Oct 2009 11:35:21 +0200, Jean Delvare wrote: > > Hi Takashi, > > On Thu, 01 Oct 2009 08:52:59 +0200, Takashi Iwai wrote: > > At Wed, 30 Sep 2009 18:55:05 +0200, > > Jean Delvare wrote: > > > > > > On Wed, 30 Sep 2009 17:15:49 +0200, Takash

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

2009-09-30 Thread Takashi Iwai
At Wed, 30 Sep 2009 18:55:05 +0200, Jean Delvare wrote: > > On Wed, 30 Sep 2009 17:15:49 +0200, Takashi Iwai wrote: > > Yes, indeed I prefer NULL check because the user can know the error > > at the right place. I share your concern about the code addition, > > though :)

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

2009-09-30 Thread Takashi Iwai
At Wed, 30 Sep 2009 17:00:06 +0200, Jean Delvare wrote: > > Hi Takashi, > > Thanks for the swift reply. > > On Wed, 30 Sep 2009 16:13:49 +0200, Takashi Iwai wrote: > > At Wed, 30 Sep 2009 15:25:42 +0200, > > Jean Delvare wrote: > > > > > > If i

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

2009-09-30 Thread Takashi Iwai
At Wed, 30 Sep 2009 15:25:42 +0200, Jean Delvare wrote: > > If i2c device probing fails, then there is no driver to dereference > after calling i2c_new_device(). Stop assuming that probing will always > succeed, to avoid NULL pointer dereferences. We have an easier access > to the driver anyway. >

Re: [PATCH -v2 0/7] powerpc: use asm-generic/dma-mapping-common.h

2009-08-13 Thread Takashi Iwai
At Thu, 13 Aug 2009 18:07:57 +1000, Benjamin Herrenschmidt wrote: > > On Thu, 2009-08-13 at 09:11 +0200, Takashi Iwai wrote: > > I'm willing to rebase my patches to the generic dma_ops, so feel free > > to pull it first. > > I think I'll end up pulling Ingo&#

Re: [PATCH -v2 0/7] powerpc: use asm-generic/dma-mapping-common.h

2009-08-13 Thread Takashi Iwai
At Thu, 13 Aug 2009 16:51:53 +1000, Benjamin Herrenschmidt wrote: > > On Thu, 2009-08-13 at 16:44 +1000, Benjamin Herrenschmidt wrote: > > On Wed, 2009-08-05 at 14:08 +0900, FUJITA Tomonori wrote: > > > > > The above swiotlb patchset was merged in -tip so I think that merging > > > this patchset

Re: [PATCH 5/5] sound/aoa: Add kmalloc NULL tests

2009-07-31 Thread Takashi Iwai
At Fri, 31 Jul 2009 08:32:03 +0200 (CEST), Julia Lawall wrote: > > From: Julia Lawall > > Check that the result of kzalloc is not NULL before a dereference. > > The semantic match that finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // > @@ > expression *x; > id

Re: [PATCH 5/5] sound/aoa: Add kmalloc NULL tests

2009-07-30 Thread Takashi Iwai
At Thu, 30 Jul 2009 16:29:54 +0200 (CEST), Julia Lawall wrote: > > On Thu, 30 Jul 2009, Johannes Berg wrote: > > > On Thu, 2009-07-30 at 16:11 +0200, Julia Lawall wrote: > > > From: Julia Lawall > > > > > > Check that the result of kzalloc is not NULL before a dereference. > > > > >

Re: ALSA fixes for non-coherent ppc32 again

2009-07-08 Thread Takashi Iwai
At Fri, 26 Jun 2009 15:14:54 +0200, Gerhard Pircher wrote: > > > Original-Nachricht > > Datum: Wed, 24 Jun 2009 11:47:13 +0200 > > Von: Takashi Iwai > > An: "Gerhard Pircher" > > CC: b...@kernel.crashing.org, linuxppc-...@ozl

Re: ALSA fixes for non-coherent ppc32 again

2009-07-08 Thread Takashi Iwai
At Wed, 08 Jul 2009 13:01:50 +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2009-06-22 at 08:34 +1000, Benjamin Herrenschmidt wrote: > > On Sun, 2009-06-21 at 20:18 +0200, Gerhard Pircher wrote: > > > Hi, > > > > > > Takashi Iwai posted patches

Re: ALSA fixes for non-coherent ppc32 again

2009-06-24 Thread Takashi Iwai
At Wed, 24 Jun 2009 10:46:01 +0200, Gerhard Pircher wrote: > > > Original-Nachricht > > Datum: Tue, 23 Jun 2009 23:42:24 +0200 > > Von: "Gerhard Pircher" > > An: b...@kernel.crashing.org, ti...@suse.de > > CC: linuxppc-...@ozlabs.org > > Betreff: Re: ALSA fixes for non-coherent

Re: ALSA fixes for non-coherent ppc32 again

2009-06-22 Thread Takashi Iwai
At Mon, 22 Jun 2009 08:34:38 +1000, Benjamin Herrenschmidt wrote: > > On Sun, 2009-06-21 at 20:18 +0200, Gerhard Pircher wrote: > > Hi, > > > > Takashi Iwai posted patches to make ALSA work on non-coherent PPC32 > > systems (almost exactly) a year ago. See here: &g

Re: [PATCH 26/33] sound/ps3: Fix checkpatch issues

2009-06-14 Thread Takashi Iwai
At Mon, 15 Jun 2009 15:51:03 +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2009-06-15 at 07:43 +0200, Takashi Iwai wrote: > > The alsa part also already reached to the upstream, so we have to give > > revert patches if needed. But, in the case of sound bits, I think > &g

Re: [PATCH 26/33] sound/ps3: Fix checkpatch issues

2009-06-14 Thread Takashi Iwai
At Mon, 15 Jun 2009 12:22:08 +1000, Benjamin Herrenschmidt wrote: > > On Wed, 2009-06-10 at 16:55 +0200, Takashi Iwai wrote: > > At Wed, 10 Jun 2009 16:39:01 +0200, > > Geert Uytterhoeven wrote: > > > > > > Signed-off-by: Geert Uytterhoeven > >

Re: [PATCH 26/33] sound/ps3: Fix checkpatch issues

2009-06-10 Thread Takashi Iwai
At Wed, 10 Jun 2009 16:39:01 +0200, Geert Uytterhoeven wrote: > > Signed-off-by: Geert Uytterhoeven > Cc: alsa-de...@alsa-project.org > Cc: Takashi Iwai Thanks, applied these three patches (26,27,28) to sound git tree. Takashi > --- > sound/pp

Re: [PATCH] sound/ppc: update annotations of serveral functions

2009-06-02 Thread Takashi Iwai
At Wed, 3 Jun 2009 15:35:19 +1000, Stephen Rothwell wrote: > > [I am not sure if this is the correct approach as I don't know if any of > this actual hardware or drivers are really hot pluggable.] I thought it can be bound/unbound dynamically via sysfs. Anyway, the patch looks correct, so I appl

Re: [PATCH 3/3] sound: use dev_set_drvdata

2009-05-17 Thread Takashi Iwai
At Sun, 17 May 2009 11:29:21 +0200 (CEST), Julia Lawall wrote: > > From: Julia Lawall > > Eliminate direct accesses to the driver_data field. > cf 82ab13b26f15f49be45f15ccc96bfa0b81dfd015 > > The semantic patch that makes this change is as follows: > (http://www.emn.fr/x-info/coccinelle/) > >

Re: [PATCH] keywest: Get rid of useless i2c_device_name() macro

2009-05-14 Thread Takashi Iwai
At Thu, 14 May 2009 14:37:21 +0200, Jean Delvare wrote: > > The i2c_device_name() macro is used only once and doesn't have much > value, it hurts redability more than it helps. Get rid of it. > > Signed-off-by: Jean Delvare > Cc: Benjamin Herrenschmidt Applied now. Thanks. Takashi > --- >

Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device

2009-05-12 Thread Takashi Iwai
At Tue, 12 May 2009 16:05:14 -0700, Greg KH wrote: > > On Tue, May 12, 2009 at 09:23:47AM +0200, Takashi Iwai wrote: > > At Mon, 11 May 2009 23:57:43 -0700, > > Greg KH wrote: > > > > > > On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote: > &

Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device

2009-05-12 Thread Takashi Iwai
At Mon, 11 May 2009 23:57:43 -0700, Greg KH wrote: > > On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote: > > At Mon, 11 May 2009 21:54:51 +0200, > > Roel Kluin wrote: > > > > > > To avoid direct access to the driver_data pointer in struct device,

Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device

2009-05-11 Thread Takashi Iwai
At Mon, 11 May 2009 21:54:51 +0200, Roel Kluin wrote: > > To avoid direct access to the driver_data pointer in struct device, the > functions dev_get_drvdata() and dev_set_drvdata() should be used. > > Signed-off-by: Roel Kluin The same fix has been already in Greg's tree (and thus in linux-nex

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-22 Thread Takashi Iwai
At Wed, 22 Apr 2009 22:56:52 +1000, Paul Mackerras wrote: > > Jean Delvare writes: > > > > I sympathize, but throwing disruptive changes into Linus' tree when > > > we're past -rc3 is not the way to solve the problem. > > > > We're past -rc3 because people discuss instead of testing my patches.

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-21 Thread Takashi Iwai
At Tue, 21 Apr 2009 19:33:00 +1000, Paul Mackerras wrote: > > Takashi Iwai writes: > > > At least, the conversion patch Jean posted can be in 2.6.30, I think. > > Really? What regression, security hole or serious bug are you going > to tell Linus that it fixes?

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-21 Thread Takashi Iwai
At Tue, 21 Apr 2009 11:23:00 +0200, Jean Delvare wrote: > > On Tue, 21 Apr 2009 08:31:00 +0200, Takashi Iwai wrote: > > At Mon, 20 Apr 2009 22:56:59 +0200, > > Jean Delvare wrote: > > > > > > The legacy i2c binding model is going away soon, so convert the p

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-20 Thread Takashi Iwai
At Tue, 21 Apr 2009 08:34:02 +1000, Paul Mackerras wrote: > > Jean Delvare writes: > > > Takashi, please push this patch to Linus quickly, as this is blocking > > the removal of the legacy i2c binding model, which is scheduled for > > 2.6.30. > > I really don't think you can remove it from Linus

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-20 Thread Takashi Iwai
At Mon, 20 Apr 2009 22:56:59 +0200, Jean Delvare wrote: > > The legacy i2c binding model is going away soon, so convert the ppc > keywest sound driver to the new model or it will break. > > Signed-off-by: Jean Delvare > Cc: Benjamin Herrenschmidt > Cc: Takashi Iwai &g

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-20 Thread Takashi Iwai
eas Schwab > Cc: Benjamin Herrenschmidt > Cc: Takashi Iwai > --- > Takashi, please push this patch to Linus quickly, as this is blocking > the removal of the legacy i2c binding model, which is scheduled for > 2.6.30. Applied now. Thanks. Takashi __

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-16 Thread Takashi Iwai
At Thu, 16 Apr 2009 09:53:39 +0200, Jean Delvare wrote: > > On Tue, 14 Apr 2009 16:45:38 +0200, Takashi Iwai wrote: > > Johannes, please let me know if the patch works. Then I'll merge them. > > Note if it matters: the new I2C binding model my patch uses is only > ava

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-14 Thread Takashi Iwai
At Tue, 14 Apr 2009 16:37:41 +0200, Jean Delvare wrote: > > On Fri, 10 Apr 2009 17:02:38 +0200, Jean Delvare wrote: > > On Thu, 9 Apr 2009 14:19:45 +0200, Jean Delvare wrote: > > > From: Jean Delvare > > > Subject: AOA: Convert onyx and tas codecs to new-style i2c drivers > > > > > > The legacy

Re: [PATCH] snd-aoa: handle older machines

2009-01-15 Thread Takashi Iwai
At Thu, 15 Jan 2009 18:21:48 +0100, Johannes Berg wrote: > > This patch changes snd-aoa to handle some older machines that are > currently handled by snd-powermac. snd-aoa has a number of advantages > though, notably it can autoload better and is generally a more modern > driver. > > By hardcodin

Re: [PATCH 09/13] powerpc/ps3: printing fixups for l64 to ll64 conversion: sound/ppc

2009-01-13 Thread Takashi Iwai
At Wed, 14 Jan 2009 17:07:55 +1100, Stephen Rothwell wrote: > > > Signed-off-by: Stephen Rothwell Acked-by: Takashi Iwai > --- > sound/ppc/snd_ps3.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > Takashi, if it is OK with you, this could go

Re: powerpc allmodconfig

2008-10-16 Thread Takashi Iwai
At Thu, 16 Oct 2008 11:21:57 +0300, Adrian Bunk wrote: > > On Thu, Oct 16, 2008 at 09:57:11AM +0200, Takashi Iwai wrote: > > At Thu, 16 Oct 2008 10:38:36 +0300, > > Adrian Bunk wrote: > > > > > > On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote:

Re: powerpc allmodconfig

2008-10-16 Thread Takashi Iwai
At Thu, 16 Oct 2008 10:38:36 +0300, Adrian Bunk wrote: > > On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote: > > At Wed, 15 Oct 2008 21:33:37 -0700, > > Andrew Morton wrote: > > > > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect

Re: powerpc allmodconfig

2008-10-15 Thread Takashi Iwai
At Wed, 15 Oct 2008 21:33:37 -0700, Andrew Morton wrote: > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is > deprecated (declared at sound/soc/soc-dapm.c:1026) > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is > deprecated (declared at sound/soc/soc-dapm

Re: regression on imac G3: problems with sound

2008-10-02 Thread Takashi Iwai
At Thu, 2 Oct 2008 12:39:20 +0200, Mariusz Kozlowski wrote: > > Hello, > > > At Wed, 1 Oct 2008 23:47:34 +0300, > > [EMAIL PROTECTED] wrote: > > > > > > 2008/10/1, Mariusz Kozlowski <[EMAIL PROTECTED]>: > > > > Hello, > > > > > > > > I found that on my old iMac G3 aumix behaves weird on

Re: regression on imac G3: problems with sound

2008-10-01 Thread Takashi Iwai
At Wed, 1 Oct 2008 23:47:34 +0300, [EMAIL PROTECTED] wrote: > > 2008/10/1, Mariusz Kozlowski <[EMAIL PROTECTED]>: > > Hello, > > > > I found that on my old iMac G3 aumix behaves weird on newer (up to > > 2.6.27-rc8) kernels. The sound is only present _when_ muted and is quiet > > I'd say 10% o

Re: [alsa-devel] [PATCH v2] duplicate SNDRV_PCM_FMTBIT_S{16,24}_BE

2008-08-20 Thread Takashi Iwai
At Tue, 19 Aug 2008 11:53:54 -0400, roel kluin wrote: > > Takashi Iwai wrote: > > At Tue, 19 Aug 2008 08:15:05 +0200 (CEST), > > Johannes Berg wrote: > >> roel kluin wrote: > >>> untested, is it correct? > >> not a clue, do you know how long ago th

Re: [alsa-devel] [PATCH] duplicate SNDRV_PCM_FMTBIT_S{16,24}_BE

2008-08-19 Thread Takashi Iwai
At Tue, 19 Aug 2008 08:15:05 +0200 (CEST), Johannes Berg wrote: > > roel kluin wrote: > > untested, is it correct? > > not a clue, do you know how long ago that was? :) > does the driver check endianness anywhere? AFAIK snd-aoa supports only bit-endian formats (at least in sound/aoa/soundbus/i2s

Re: [alsa-devel] [PATCH] powerpc/drivers: use linux/of_device.h instead of asm/of_device.h

2008-08-11 Thread Takashi Iwai
gt; asm/of_device.h Looks good to me. Acked-by: Takashi Iwai <[EMAIL PROTECTED]> thanks, Takashi > diff --git a/drivers/hwmon/ams/ams.h b/drivers/hwmon/ams/ams.h > index a6221e5..221ef69 100644 > --- a/drivers/hwmon/ams/ams.h > +++ b/drivers/hwmon/ams/ams.h > @@ -4,7 +4

Re: [PATCH 0/3] ALSA fixes for non-coherent ppc32

2008-07-09 Thread Takashi Iwai
time for the merge window ? The changes in ppc are only the patch below. The others are in sound/*. I wrote it as an inline function simply it's so short and I didn't want extra exports. thanks, Takashi --- commit 2c8662fde57af4cf928d17e089dc3dd2096f4b30 Author: Takashi Iwai <

Re: [PATCH 0/3] ALSA fixes for non-coherent ppc32

2008-07-09 Thread Takashi Iwai
At Wed, 09 Jul 2008 10:31:11 +0200, Gerhard Pircher wrote: > > Hi, > > Original-Nachricht > > Datum: Wed, 18 Jun 2008 12:38:31 +0200 > > Von: Takashi Iwai <[EMAIL PROTECTED]> > > An: [EMAIL PROTECTED] > > CC: linuxppc-dev@ozlabs.org,

Re: [alsa-devel] [PATCH 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

2008-07-02 Thread Takashi Iwai
At Tue, 01 Jul 2008 17:53:30 -0600, Grant Likely wrote: > diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig > index 18f28ac..c5736e5 100644 > --- a/sound/soc/Kconfig > +++ b/sound/soc/Kconfig > @@ -23,6 +23,12 @@ config SND_SOC > This ASoC audio support can also be built as a module. If s

[PATCH 3/3] ALSA: Fix SG-buffer DMA with non-coherent architectures

2008-06-18 Thread Takashi Iwai
Using SG-buffers with dma_alloc_coherent() is messy for non-coherent architectures. So, simply disable SG-buffers but just allocate normal continuous buffers instead. Signed-off-by: Takashi Iwai <[EMAIL PROTECTED]> --- include/sound/memalloc.h | 19 +++ include

[PATCH 2/3] ALSA: Fix mapping of DMA buffers

2008-06-18 Thread Takashi Iwai
The DMA buffers allocated via dma_alloc_coherent() aren't easily mmappable for many architectures. This is a quick fix for some known archs that don't work properly with the current code. Signed-off-by: Takashi Iwai <[EMAIL PROTECTED]> --- sound/core/Kconfig |7 +++

[PATCH 1/3] ppc: Add dma_mmap_coherent() for PPC32

2008-06-18 Thread Takashi Iwai
A very lazy version of dma_mmap_coherent() implementation for ppc32. Signed-off-by: Takashi Iwai <[EMAIL PROTECTED]> --- include/asm-powerpc/dma-mapping.h | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/include/asm-powerpc/dma-mapping.h b/inclu

[PATCH 0/3] ALSA fixes for non-coherent ppc32

2008-06-18 Thread Takashi Iwai
Hi, I've tried to renew the fixes of ALSA issues about non-coherent DMA memories. The last patch worked for SG-buffers somehow but would result in a problem if many pages are allocated because of dma_alloc_coherent() handling. Now, I chose a more simpler workaround: the SG-buffers are handled as

Re: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

2008-05-20 Thread Takashi Iwai
At Mon, 19 May 2008 19:23:10 +0200, Giuseppe Coviello wrote: > > On mer, 14/05/2008 14.26 +0200, Takashi Iwai wrote: > [cut] > > OK, here is another patch for testing. Since I lost my old patch > > somewhere (and it's not worth to dig the archive), I wrote it up >

Re: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

2008-05-14 Thread Takashi Iwai
At Wed, 14 May 2008 23:01:10 +0200, Gerhard Pircher wrote: > > > Original-Nachricht > > Datum: Wed, 14 May 2008 14:26:53 +0200 > > Von: Takashi Iwai <[EMAIL PROTECTED]> > > An: "Gerhard Pircher" <[EMAIL PROTECTED]> > > CC:

ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

2008-05-14 Thread Takashi Iwai
At Tue, 06 May 2008 11:16:22 +0200, Gerhard Pircher wrote: > > Original-Nachricht > > Datum: Tue, 06 May 2008 18:48:39 +1000 > > Von: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > > An: Gerhard Pircher <[EMAIL PROTECTED]> > > CC: lin

Re: ALSA vs. non coherent DMA

2008-05-08 Thread Takashi Iwai
At Thu, 08 May 2008 07:53:11 +1000, Benjamin Herrenschmidt wrote: > > On Wed, 2008-05-07 at 09:22 -0500, Timur Tabi wrote: > > Takashi Iwai wrote: > > > > > This is a mmap of the data record to be shared in realtime with apps. > > > The app updates its da

Re: [PATCH] Sam440ep support

2008-05-06 Thread Takashi Iwai
At Tue, 06 May 2008 21:25:53 +1000, Benjamin Herrenschmidt wrote: > > > On Tue, 2008-05-06 at 13:14 +0200, Takashi Iwai wrote: > > > sg allocations are usually lists of page, so virt_to_page shouldn't > > be a > > > problem in the first place, though we stil

Re: [PATCH] Sam440ep support

2008-05-06 Thread Takashi Iwai
At Tue, 06 May 2008 20:12:27 +1000, Benjamin Herrenschmidt wrote: > > > On Tue, 2008-05-06 at 11:16 +0200, Gerhard Pircher wrote: > > I can't answer this question. *ducked* :-) Takashi? > > > > FYI: I posted the results of the test with Takashi's dma_mmap_coherent > > patch here: > > http://ozla

Re: ALSA vs. non coherent DMA

2008-05-06 Thread Takashi Iwai
Hi Ben, thanks for signaling this long-standing issue again. At Tue, 06 May 2008 10:08:28 +1000, Benjamin Herrenschmidt wrote: > > Hi Takashi ! > > I'm bringing up an old thread as I'm just discovering that the problem > still hasn't been fixed. > > There seem to be a few issues with ALSA curr

Re: [alsa-devel] [PATCH v3] [POWERPC] Update MPC8610 HPCD to support audio drivers

2008-01-18 Thread Takashi Iwai
At Fri, 18 Jan 2008 09:18:14 -0600, Kumar Gala wrote: > > > On Jan 18, 2008, at 8:48 AM, Timur Tabi wrote: > > > Kumar Gala wrote: > > > >> Can you respin this. It doesn't apply cleanly to my tree. > > > > Ok, but I have a feeling that the merge between alsa-git and powerpc- > > git is going t

Re: [alsa-devel] [PATCH] ASoC drivers for the Freescale MPC8610 SoC

2007-12-20 Thread Takashi Iwai
At Thu, 20 Dec 2007 08:24:35 -0600, Timur Tabi wrote: > > >> +static int fsl_dma_new(struct snd_card *card, struct snd_soc_codec_dai > >> *dai, > >> + struct snd_pcm *pcm) > >> +{ > >> + static u64 fsl_dma_dmamask = 0x; > >> + int ret; > >> + > >> + if (!card->dev->dma_mask) > >> +

Re: [PATCH][36/37] Clean up duplicate includes in sound/ppc/

2007-07-23 Thread Takashi Iwai
At Sat, 21 Jul 2007 17:04:07 +0200, Jesper Juhl wrote: > > Hi, > > This patch cleans up duplicate includes in > / sound/ppc? :) > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Now applied to ALSA tree. Thanks. Takashi > --- > > diff --git a/sound/ppc/snd_ps3.c b/sound/pp

Re: [PATCH] Fix tas_suspend/resume build warning

2007-07-23 Thread Takashi Iwai
At Sat, 21 Jul 2007 19:29:26 +0200, Johannes Berg wrote: > > On Sun, 2007-07-22 at 00:29 +1000, Stephen Rothwell wrote: > > sound/aoa/codecs/snd-aoa-codec-tas.c:750: warning: 'tas_suspend' defined > > but not used > > sound/aoa/codecs/snd-aoa-codec-tas.c:760: warning: 'tas_resume' defined but >

<    1   2