Re: [PATCH v2 05/25] iommu/tegra-gart: Remove tegra-gart

2023-06-01 Thread Thierry Reding
It can't accept a map until the domain is attached >* It forgets about all maps after the domain is detached >* It doesn't clear the HW of maps once the domain is detached > (made worse by having the wrong groups) > > Cc: Thierry Reding > Cc: Dmitry Osipenko > Signed-off

Re: [PATCH 3/3] ALSA: core: Make snd_card_free() return void

2023-02-08 Thread Thierry Reding
re/init.c | 6 ++ > sound/pci/hda/hda_tegra.c | 6 ++ > sound/ppc/snd_ps3.c | 4 +--- > 4 files changed, 6 insertions(+), 12 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

[PATCH] powerpc: dts: Fix some I2C unit addresses

2021-12-20 Thread Thierry Reding
From: Thierry Reding The unit-address for the Maxim MAX1237 ADCs on XPedite5200 boards don't match the value in the "reg" property and cause a DTC warning. Signed-off-by: Thierry Reding --- arch/powerpc/boot/dts/xpedite5200.dts | 2 +- arch/powerpc/boot/dts/xpedite5200_xmon.dts

Re: [PATCH v2 30/34] dt-bindings: arm: Convert Tegra board/soc bindings to json-schema

2018-12-07 Thread Thierry Reding
On Thu, Dec 06, 2018 at 04:38:44PM -0600, Rob Herring wrote: > On Tue, Dec 4, 2018 at 2:50 AM Thierry Reding > wrote: > > > > On Mon, Dec 03, 2018 at 03:32:19PM -0600, Rob Herring wrote: > > > Convert Tegra SoC bindings to DT schema format using json-schema. &

Re: [PATCH v2 30/34] dt-bindings: arm: Convert Tegra board/soc bindings to json-schema

2018-12-04 Thread Thierry Reding
On Mon, Dec 03, 2018 at 03:32:19PM -0600, Rob Herring wrote: > Convert Tegra SoC bindings to DT schema format using json-schema. > > Cc: Mark Rutland > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: devicet...@vger.kernel.org > Cc: linux-te...@vger.kernel.org > Si

Re: [PATCH] soc: Convert to using %pOFn instead of device_node.name

2018-08-28 Thread Thierry Reding
Cc: Heiko Stuebner > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Santosh Shilimkar > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/soc/dove/pmu.c|

Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem

2018-02-20 Thread Thierry Reding
On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: [...] > drivers/watchdog/tegra_wdt.c | 10 +-- [...] Acked-by: Thierry Reding <tred...@nvidia.com> signature.asc Description: PGP signature

Re: [PATCH 01/44] firmware/ivc: use dma_mapping_error

2017-06-13 Thread Thierry Reding
On Thu, Jun 08, 2017 at 03:25:26PM +0200, Christoph Hellwig wrote: > DMA_ERROR_CODE is not supposed to be used by drivers. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > --- > drivers/firmware/tegra/ivc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Thierry Reding
pter\n"); > + if (ret) > goto disable_div_clk; > - } > > return 0; > Acked-by: Thierry Reding <tred...@nvidia.com> signature.asc Description: PGP signature

Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations

2015-04-09 Thread Thierry Reding
On Sun, Apr 05, 2015 at 11:24:54AM -0700, Joe Perches wrote: [...] drivers/tty/serial/serial-tegra.c | 2 +- Acked-by: Thierry Reding tred...@nvidia.com pgpMuP0DtU6my.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH v2 03/22] MSI: Remove the redundant irq_set_chip_data()

2014-09-26 Thread Thierry Reding
On Fri, Sep 26, 2014 at 10:04:45AM +0800, Yijing Wang wrote: On 2014/9/25 15:19, Thierry Reding wrote: On Thu, Sep 25, 2014 at 11:14:13AM +0800, Yijing Wang wrote: Currently, pcie-designware, pcie-rcar, pci-tegra drivers use irq chip_data to save the msi_chip pointer. They already call

Re: [PATCH v2 03/22] MSI: Remove the redundant irq_set_chip_data()

2014-09-26 Thread Thierry Reding
() is useless. Signed-off-by: Yijing Wang wangyij...@huawei.com --- drivers/pci/msi.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Thierry Reding tred...@nvidia.com diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 51d7e62..50f67a3 100644 --- a/drivers/pci

Re: [PATCH v2 00/22] Use MSI chip framework to configure MSI/MSI-X in all platforms

2014-09-26 Thread Thierry Reding
On Fri, Sep 26, 2014 at 02:20:35PM +0800, Yijing Wang wrote: The PCI core can already deal with that. An MSI chip can be set per bus and the weak pcibios_add_bus() can be used to set that. Often it might not even be necessary to do it via pcibios_add_bus() if you create the root bus

Re: [PATCH v2 00/22] Use MSI chip framework to configure MSI/MSI-X in all platforms

2014-09-26 Thread Thierry Reding
On Fri, Sep 26, 2014 at 10:54:32AM +0200, Thierry Reding wrote: [...] At least for Tegra it's trivial to just hook it up in tegra_pcie_scan_bus() directly (patch attached). Really attached this time. Thierry From 2cedfcf38cdfe21688d1363659f28e271ce43358 Mon Sep 17 00:00:00 2001 From: Thierry

Re: [PATCH v2 02/22] PCI/MSI: Remove useless bus-msi assignment

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 11:14:12AM +0800, Yijing Wang wrote: Currently, PCI drivers will initialize bus-msi in pcibios_add_bus(). pcibios_add_bus() will be called in every pci bus initialization. So the bus-msi assignment in pci_alloc_child_bus() is useless. I think this should be the other

Re: [PATCH v2 01/22] PCI/MSI: Clean up struct msi_chip argument

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 11:14:11AM +0800, Yijing Wang wrote: Msi_chip functions setup_irq/teardown_irq rarely use msi_chip argument. That's not true. Out of the four drivers that you modify two use the parameter. And the two that don't probably should be using it too. 50% is not rarely. =)

Re: [PATCH v2 03/22] MSI: Remove the redundant irq_set_chip_data()

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 11:14:13AM +0800, Yijing Wang wrote: Currently, pcie-designware, pcie-rcar, pci-tegra drivers use irq chip_data to save the msi_chip pointer. They already call irq_set_chip_data() in their own MSI irq map functions. So irq_set_chip_data() in arch_setup_msi_irq() is

Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 11:14:16AM +0800, Yijing Wang wrote: Introduce weak arch_find_msi_chip() to find the match msi_chip. Currently, MSI chip associates pci bus to msi_chip. Because in ARM platform, there may be more than one MSI controller in system. Associate pci bus to msi_chip help pci

Re: [PATCH v2 12/22] MIPS/Octeon/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 11:14:22AM +0800, Yijing Wang wrote: [...] diff --git a/arch/mips/pci/msi-octeon.c b/arch/mips/pci/msi-octeon.c [...] @@ -132,12 +132,12 @@ msi_irq_allocated: /* Make sure the search for available interrupts didn't fail */ if (irq = 64) { if

Re: [PATCH v2 14/22] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 11:14:24AM +0800, Yijing Wang wrote: Use MSI chip framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Nit: s/irq/IRQ/ in the above. Signed-off-by: Yijing Wang wangyij...@huawei.com ---

Re: [PATCH v2 15/22] MIPS/Xlr/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 11:14:25AM +0800, Yijing Wang wrote: [...] diff --git a/arch/mips/pci/pci-xlr.c b/arch/mips/pci/pci-xlr.c [...] @@ -214,11 +214,11 @@ static int get_irq_vector(const struct pci_dev *dev) } #ifdef CONFIG_PCI_MSI -void arch_teardown_msi_irq(unsigned int irq) +void

Re: [PATCH v2 17/22] s390/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 11:14:27AM +0800, Yijing Wang wrote: [...] diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c [...] @@ -358,7 +358,7 @@ static void zpci_irq_handler(struct airq_struct *airq) } } -int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) +int

Re: [PATCH v2 00/22] Use MSI chip framework to configure MSI/MSI-X in all platforms

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 11:14:10AM +0800, Yijing Wang wrote: This series is based Bjorn's pci/msi branch git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/msi Currently, there are a lot of weak arch functions in MSI code. Thierry Reding Introduced MSI chip framework

Re: [PATCH v2 00/22] Use MSI chip framework to configure MSI/MSI-X in all platforms

2014-09-25 Thread Thierry Reding
On Thu, Sep 25, 2014 at 03:48:55PM +0100, Liviu Dudau wrote: On Thu, Sep 25, 2014 at 09:42:36AM +0200, Thierry Reding wrote: On Thu, Sep 25, 2014 at 11:14:10AM +0800, Yijing Wang wrote: This series is based Bjorn's pci/msi branch git://git.kernel.org/pub/scm/linux/kernel/git/helgaas

Re: [PATCH 0/5] defconfigs: add MTD_SPI_NOR (dependency for M25P80)

2014-04-17 Thread Thierry Reding
On Thu, Apr 17, 2014 at 12:21:44AM -0700, Brian Norris wrote: Hi all, We are introducing a new SPI-NOR library/framework for MTD, to support various types of SPI-NOR flash controllers which require (or benefit from) intimate knowledge of the flash interface, rather than just the relatively

Re: commit e38c0a1f breaks powerpc boards with uli1575 chip

2013-12-19 Thread Thierry Reding
On Wed, Dec 18, 2013 at 12:40:21PM -0600, Rob Herring wrote: [fixed DT maillist address] On 12/17/2013 01:35 AM, Nikita Yushchenko wrote: Hi While trying to make freescale p2020ds and mpc8572ds boards working with mainline kernel, I faced that commit e38c0a1f (Handle

Re: [PATCH v2 08/10] of/platform: Resolve interrupt references at probe time

2013-10-25 Thread Thierry Reding
On Thu, Oct 24, 2013 at 05:37:49PM +0100, Grant Likely wrote: On Wed, 16 Oct 2013 00:24:36 +0100, Grant Likely grant.lik...@linaro.org wrote: On Wed, 18 Sep 2013 15:24:50 +0200, Thierry Reding thierry.red...@gmail.com wrote: Interrupt references are currently resolved very early (when

Re: [PATCH v2 08/10] of/platform: Resolve interrupt references at probe time

2013-10-16 Thread Thierry Reding
On Wed, Oct 16, 2013 at 12:24:36AM +0100, Grant Likely wrote: On Wed, 18 Sep 2013 15:24:50 +0200, Thierry Reding thierry.red...@gmail.com wrote: Interrupt references are currently resolved very early (when a device is created). This has the disadvantage that it will fail in cases where

Re: [PATCH v2 04/10] irqdomain: Return errors from irq_create_of_mapping()

2013-09-23 Thread Thierry Reding
On Sun, Sep 22, 2013 at 04:14:43PM -0500, Rob Herring wrote: On Wed, Sep 18, 2013 at 8:24 AM, Thierry Reding thierry.red...@gmail.com wrote: Instead of returning 0 for all errors, allow the precise error code to be propagated. This will be used in subsequent patches to allow further

Re: [PATCH v2 07/10] of/irq: Propagate errors in of_irq_to_resource_table()

2013-09-23 Thread Thierry Reding
On Sun, Sep 22, 2013 at 04:08:26PM -0500, Rob Herring wrote: On Wed, Sep 18, 2013 at 8:24 AM, Thierry Reding thierry.red...@gmail.com wrote: Now that all helpers return precise error codes, this function can propagate these errors to the caller properly. Signed-off-by: Thierry Reding

[PATCH v2 01/10] of/irq: Rework of_irq_count()

2013-09-18 Thread Thierry Reding
the more lightweight of_irq_map_one(), which, despite the name, doesn't create an actual mapping. Perhaps a better name would be of_irq_translate_one(). Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/of/irq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 00/10] of/irq: Defer interrupt reference resolution

2013-09-18 Thread Thierry Reding
7 of this series. Changes in v2: - use more consistent naming and calling conventions - use less wrappers, update more callers - make of_platform_probe() idempotent The initial version of this patch series can be found here: https://lkml.org/lkml/2013/9/16/111 Thierry Thierry Reding (10

[PATCH v2 02/10] of/irq: Use irq_of_parse_and_map()

2013-09-18 Thread Thierry Reding
Replace some instances of of_irq_map_one()/irq_create_of_mapping() and of_irq_to_resource() by the simpler equivalent irq_of_parse_and_map(). Signed-off-by: Thierry Reding tred...@nvidia.com --- arch/arm/mach-u300/timer.c | 9 - arch/powerpc/platforms/cell

[PATCH v2 03/10] irqdomain: Introduce __irq_create_mapping()

2013-09-18 Thread Thierry Reding
__irq_create_mapping(). Signed-off-by: Thierry Reding tred...@nvidia.com --- kernel/irq/irqdomain.c | 59 +- 1 file changed, 39 insertions(+), 20 deletions(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 706724e..d2a3b01 100644

[PATCH v2 04/10] irqdomain: Return errors from irq_create_of_mapping()

2013-09-18 Thread Thierry Reding
to signal success (== 0) or failure ( 0). Signed-off-by: Thierry Reding tred...@nvidia.com --- Changes in v2: - convert existing callers instead of using compatible wrapper arch/arm/mach-integrator/pci_v3.c | 8 ++-- arch/microblaze/pci/pci-common.c | 6

[PATCH v2 05/10] of/irq: Introduce __irq_of_parse_and_map()

2013-09-18 Thread Thierry Reding
around the new __irq_of_parse_and_map(). Note that this is somewhat complicated by the fact that SPARC implement its own version of irq_of_parse_and_map(). Make SPARC implement __irq_of_parse_and_map() so that the static inline wrapper can be used on all platforms. Signed-off-by: Thierry Reding tred

[PATCH v2 06/10] of/irq: Return errors from of_irq_to_resource()

2013-09-18 Thread Thierry Reding
, so we might as well enforce that by using the right data type. Signed-off-by: Thierry Reding tred...@nvidia.com --- Changes in v2: - convert existing callers instead of using compatible wrapper arch/powerpc/platforms/83xx/mpc832x_rdb.c | 2 +- drivers/net/ethernet/marvell/mv643xx_eth.c | 5

[PATCH v2 07/10] of/irq: Propagate errors in of_irq_to_resource_table()

2013-09-18 Thread Thierry Reding
Now that all helpers return precise error codes, this function can propagate these errors to the caller properly. Signed-off-by: Thierry Reding tred...@nvidia.com --- Changes in v2: - return 0 on success or a negative error code on failure - convert callers to new calling convention arch/mips

[PATCH v2 09/10] of/i2c: Resolve interrupt references at probe time

2013-09-18 Thread Thierry Reding
implements this functionality within the I2C core. Signed-off-by: Thierry Reding tred...@nvidia.com --- Changes in v2: - use __irq_of_parse_and_map() instead of of_irq_get() drivers/i2c/i2c-core.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 10/10] gpio: tegra: Use module_platform_driver()

2013-09-18 Thread Thierry Reding
With the driver core now resolving interrupt references at probe time, it is no longer necessary to force explicit probe ordering using initcalls. Signed-off-by: Thierry Reding tred...@nvidia.com --- Note that there are potentially many more drivers that can be switched to the generic module_

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Thierry Reding
On Mon, Aug 19, 2013 at 07:59:40PM +0200, Wolfram Sang wrote: [...] diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c [...] +#if IS_ENABLED(CONFIG_OF) +static void of_i2c_register_devices(struct i2c_adapter *adap) +{ [...] +} [...] +#endif /* CONFIG_OF */ Isn't this missing the

Re: [PATCHv5 02/11] PCI: use weak functions for MSI arch-specific functions

2013-07-25 Thread Thierry Reding
On Mon, Jul 15, 2013 at 01:52:38PM +0200, Thomas Petazzoni wrote: Until now, the MSI architecture-specific functions could be overloaded using a fairly complex set of #define and compile-time conditionals. In order to prepare for the introduction of the msi_chip infrastructure, it is desirable

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-20 Thread Thierry Reding
On Wed, Dec 12, 2012 at 04:37:50PM +, Andrew Murray wrote: [...] diff --git a/drivers/of/address.c b/drivers/of/address.c [...] + start = of_get_property(node, ranges, rlen); + if (start == NULL) + return NULL; + + end = start + rlen; I'm currently rewriting

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-13 Thread Thierry Reding
On Wed, Dec 12, 2012 at 04:37:50PM +, Andrew Murray wrote: DT bindings for PCI host bridges often use the ranges property to describe memory and IO ranges - this binding tends to be the same across architectures yet several parsing implementations exist, e.g. arch/mips/pci/pci.c,

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-13 Thread Thierry Reding
On Thu, Dec 13, 2012 at 09:45:43AM +, Andrew Murray wrote: On Thu, Dec 13, 2012 at 09:13:33AM +, Thierry Reding wrote: Hi Andrew, I don't like iterator interfaces too much, but I can live with that. Other than that the patch looks good to me and I'll try to work it into my

Re: pci and pcie device-tree binding - range No cells

2012-12-12 Thread Thierry Reding
On Wed, Dec 12, 2012 at 12:19:12PM +, Andrew Murray wrote: On Wed, Dec 12, 2012 at 10:49 AM, Grant Likely wrote: On Wed, Dec 12, 2012 at 10:37 AM, Michal Simek mon...@monstr.eumailto:mon...@monstr.eu wrote: On 12/10/2012 10:41 PM, Grant Likely wrote: drivers/pci/pci-of.c would be