Re: [PATCH v11 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging

2017-06-28 Thread Thomas Gleixner
On Thu, 29 Jun 2017, Anju T Sudhakar wrote: > +static void cleanup_all_core_imc_memory(struct imc_pmu *pmu_ptr) > +{ > + struct imc_mem_info *ptr; > + > + for (ptr = pmu_ptr->mem_info; ptr; ptr++) { > + if (ptr->vbase[0]) > + free_pages((u64)ptr->vbase[0],

Re: [PATCH 1/1] futex: remove duplicated code and fix UB

2017-06-23 Thread Thomas Gleixner
On Wed, 21 Jun 2017, Jiri Slaby wrote: > diff --git a/arch/arm64/include/asm/futex.h b/arch/arm64/include/asm/futex.h > index f32b42e8725d..5bb2fd4674e7 100644 > --- a/arch/arm64/include/asm/futex.h > +++ b/arch/arm64/include/asm/futex.h > @@ -48,20 +48,10 @@ do {

Re: [PATCH] powerpc: Only obtain cpu_hotplug_lock if called by rtasd

2017-06-22 Thread Thomas Gleixner
On Thu, 22 Jun 2017, Thiago Jung Bauermann wrote: > Michael Bringmann provided this information: > >> It's not hard to backport both this patch and commit fe5595c07400 > >> ("stop_machine: Provide stop_machine_cpuslocked()") from branch > >> smp/hotplug in tip.git for stable. > > > > Yeah but it's

Re: [PATCH] powerpc: Only obtain cpu_hotplug_lock if called by rtasd

2017-06-22 Thread Thomas Gleixner
On Wed, 21 Jun 2017, Thiago Jung Bauermann wrote: > Michael Ellerman writes: > >> Notes: > >> This patch applies on tip/smp/hotplug, it should probably be carried > >> there. > > > > stop_machine_cpuslocked() doesn't exist in mainline so I think it has to > > be carried

Re: [PATCH v9 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging

2017-06-12 Thread Thomas Gleixner
On Wed, 7 Jun 2017, Anju T Sudhakar wrote: > On Tuesday 06 June 2017 03:39 PM, Thomas Gleixner wrote: > > On Mon, 5 Jun 2017, Anju T Sudhakar wrote: > > > +static void cleanup_all_core_imc_memory(struct imc_pmu *pmu_ptr) > > > +{ > > > + struct i

Re: [PATCH v9 10/10] powerpc/perf: Thread imc cpuhotplug support

2017-06-06 Thread Thomas Gleixner
On Mon, 5 Jun 2017, Anju T Sudhakar wrote: > static void thread_imc_mem_alloc(int cpu_id) > { > - u64 ldbar_addr, ldbar_value; > int phys_id = topology_physical_package_id(cpu_id); > > per_cpu_add[cpu_id] = (u64)alloc_pages_exact_nid(phys_id, >

Re: [PATCH v9 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging

2017-06-06 Thread Thomas Gleixner
On Mon, 5 Jun 2017, Anju T Sudhakar wrote: > +static void cleanup_all_core_imc_memory(struct imc_pmu *pmu_ptr) > +{ > + struct imc_mem_info *ptr = pmu_ptr->mem_info; > + > + if (!ptr) > + return; That's pointless. > + for (; ptr; ptr++) { for (ptr =

Re: [PATCH v9 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-06-06 Thread Thomas Gleixner
On Mon, 5 Jun 2017, Anju T Sudhakar wrote: > +/* > + * nest_imc_stop : Does OPAL call to stop nest engine. > + */ > +static void nest_imc_stop(int *cpu_opal_rc) > +{ > + int rc; > + > + rc = opal_imc_counters_stop(OPAL_IMC_COUNTERS_NEST); > + if (rc) > +

Re: [PATCH 1/1] futex: remove duplicated code

2017-05-26 Thread Thomas Gleixner
On Thu, 25 May 2017, Will Deacon wrote: > On Mon, May 22, 2017 at 11:11:33PM +0200, Thomas Gleixner wrote: > > On Mon, 15 May 2017, Will Deacon wrote: > > > On Mon, May 15, 2017 at 03:07:42PM +0200, Jiri Slaby wrote: > > > > There is code duplicated o

[patch V3 16/32] powerpc/powernv: Use stop_machine_cpuslocked()

2017-05-24 Thread Thomas Gleixner
. Use stop_machine_cpuslocked() to avoid the nested call. Convert *_online_cpus() to the new interfaces while at it. Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: Peter Zijlstra <pet...@infradead.org> Cc: B

[patch V3 10/32] KVM/PPC/Book3S HV: Use cpuhp_setup_state_nocalls_cpuslocked()

2017-05-24 Thread Thomas Gleixner
percpu rwsem. Use cpuhp_setup_state_nocalls_cpuslocked() to avoid the nested call. Convert *_online_cpus() to the new interfaces while at it. Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: k...@vger.kernel.org Cc: P

RE: RFC: better timer interface

2017-05-23 Thread Thomas Gleixner
On Tue, 23 May 2017, David Laight wrote: > From: Thomas Gleixner > > Sent: 23 May 2017 12:59 > > On Tue, 23 May 2017, David Laight wrote: > > > > > From: Thomas Gleixner > > > > Sent: 21 May 2017 19:15 > > > ... > > > > > timer_s

RE: RFC: better timer interface

2017-05-23 Thread Thomas Gleixner
On Tue, 23 May 2017, David Laight wrote: > From: Thomas Gleixner > > Sent: 21 May 2017 19:15 > ... > > > timer_start(timer, ms, abs) > > > > I'm not even sure, whether we need absolute timer wheel timers at > > all, because most use cases are relative to n

Re: [PATCH 1/1] futex: remove duplicated code

2017-05-22 Thread Thomas Gleixner
On Mon, 15 May 2017, Will Deacon wrote: > Hi Jiri, > > On Mon, May 15, 2017 at 03:07:42PM +0200, Jiri Slaby wrote: > > There is code duplicated over all architecture's headers for > > futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr, > > and comparison of the result. > > > >

Re: RFC: better timer interface

2017-05-22 Thread Thomas Gleixner
On Mon, 22 May 2017, Arnd Bergmann wrote: > On Sun, May 21, 2017 at 8:14 PM, Thomas Gleixner <t...@linutronix.de> wrote: > > But it's easy enough to provide them. All we need for that is something > > like > > > > unsigned long time_msec; > >

Re: RFC: better timer interface

2017-05-22 Thread Thomas Gleixner
On Mon, 22 May 2017, Arnd Bergmann wrote: > On Sun, May 21, 2017 at 7:13 PM, Thomas Gleixner <t...@linutronix.de> wrote: > I agree, one of the above is good enough, if we do the large-scale API > replacement. Having both ms and sec variants would be for convenience > to avoid h

Re: RFC: better timer interface

2017-05-21 Thread Thomas Gleixner
On Sun, 21 May 2017, Thomas Gleixner wrote: > On Tue, 16 May 2017, Arnd Bergmann wrote: > > On Tue, May 16, 2017 at 5:51 PM, Christoph Hellwig <h...@lst.de> wrote: > > > Yes, that sounds useful to me as well. As you said it's an independent > > > but somewhat re

Re: [PATCH 2/9] timers: provide a "modern" variant of timers

2017-05-21 Thread Thomas Gleixner
On Thu, 18 May 2017, Christoph Hellwig wrote: > On Thu, May 18, 2017 at 10:24:48AM +0200, Christoph Hellwig wrote: > > > b) give the union a name (breaks any reference to timer_list->func in C > > > code): > > > > > > + union { > > > + void(*func)(struct

Re: RFC: better timer interface

2017-05-21 Thread Thomas Gleixner
On Tue, 16 May 2017, Arnd Bergmann wrote: > On Tue, May 16, 2017 at 5:51 PM, Christoph Hellwig wrote: > > Yes, that sounds useful to me as well. As you said it's an independent > > but somewhat related change. I can add it to my series, but I'll > > need a suggestions for a good

[patch V2 06/17] powerpc: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in smp_generic_cpu_bootable() to handle the extra states. Signed-off-by: Thomas Gleixner <t...@linutronix.de>

[patch V2 09/17] cpufreq/pasemi: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in pas_cpufreq_cpu_exit() to handle the extra states. Signed-off-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-15 Thread Thomas Gleixner
On Mon, 15 May 2017, Madhavan Srinivasan wrote: > On Wednesday 10 May 2017 05:39 PM, Thomas Gleixner wrote: > > On Thu, 4 May 2017, Anju T Sudhakar wrote: > > > + /* > > > + * Update the cpumask with the target cpu and > > > + * migrate the context if needed

[patch 06/18] powerpc: Adjust system_state check

2017-05-14 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in smp_generic_cpu_bootable() to handle the extra states. Signed-off-by: Thomas Gleixner <t...@linutronix.de&

[patch 09/18] cpufreq/pasemi: Adjust system_state check

2017-05-14 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in pas_cpufreq_cpu_exit() to handle the extra states. Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: &qu

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-11 Thread Thomas Gleixner
On Thu, 11 May 2017, Stephen Rothwell wrote: > Hi, > > On Wed, 10 May 2017 14:09:53 +0200 (CEST) Thomas Gleixner > <t...@linutronix.de> wrote: > > > > > +static void nest_change_cpu_context(int old_cpu, int new_cpu) > > > +{

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-10 Thread Thomas Gleixner
On Thu, 4 May 2017, Anju T Sudhakar wrote: > +/* > + * nest_init : Initializes the nest imc engine for the current chip. > + * by default the nest engine is disabled. > + */ > +static void nest_init(int *cpu_opal_rc) > +{ > + int rc; > + > + /* > + * OPAL figures out which CPU to

[patch V2 13/24] powerpc/powernv: Use stop_machine_cpuslocked()

2017-04-18 Thread Thomas Gleixner
-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/platforms/powernv/subcore.c |

[patch V2 07/24] KVM/PPC/Book3S HV: Use cpuhp_setup_state_nocalls_cpuslocked()

2017-04-18 Thread Thomas Gleixner
percpu rwsem. Use cpuhp_setup_state_nocalls_cpuslocked() to avoid the nested call. Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: Alexander Graf <ag...@suse.com> Cc: Benjamin Herrenschmidt <b...@kerne

[patch 07/20] KVM/PPC/Book3S HV: Use cpuhp_setup_state_nocalls_locked()

2017-04-15 Thread Thomas Gleixner
percpu rwsem. Use cpuhp_setup_state_nocalls_locked() to avoid the nested call. Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: Alexander Graf <ag...@suse.com> Cc: Benjamin Herrenschmidt <b...@kernel.crashin

[patch 13/20] powerpc/powernv: Use stop_machine_locked()

2017-04-15 Thread Thomas Gleixner
Andrzej Siewior <bige...@linutronix.de> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/platforms/powernv/subcore.c |

[patch 05/13] powerpc/smp: Replace open coded task affinity logic

2017-04-12 Thread Thomas Gleixner
can happen, but the access to task_struct::cpus_allowed is about to restricted. Replace it with a call to work_on_cpu_safe() which achieves the same result. Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras &l

Re: [RFC PATCH 00/13] Introduce first class virtual address spaces

2017-03-16 Thread Thomas Gleixner
On Thu, 16 Mar 2017, Till Smejkal wrote: > On Thu, 16 Mar 2017, Thomas Gleixner wrote: > > Why do we need yet another mechanism to represent something which looks > > like a file instead of simply using existing mechanisms and extend them? > > You are right. I a

Re: [RFC PATCH 00/13] Introduce first class virtual address spaces

2017-03-16 Thread Thomas Gleixner
On Wed, 15 Mar 2017, Till Smejkal wrote: > On Wed, 15 Mar 2017, Andy Lutomirski wrote: > > > VAS segments on the other side would provide a functionality to > > > achieve the same without the need of any mounted filesystem. However, > > > I agree, that this is just a small advantage compared to

Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124 .icp_hv_eoi+0x40/0x140

2017-02-20 Thread Thomas Gleixner
On Tue, 21 Feb 2017, Benjamin Herrenschmidt wrote: > On Mon, 2017-02-20 at 21:55 +1100, Michael Ellerman wrote: > > But when we're called for CONFIG_DEBUG_SHIRQ get_irq() is not called, > > precisely because we're faking an interrupt. > > > > I'm not sure if there's a good way to fix it :/ > >

Re: [PATCH] genirq/affinity: fix node generation from cpumask

2016-12-15 Thread Thomas Gleixner
On Thu, 15 Dec 2016, Gavin Shan wrote: > > static int get_nodes_in_cpumask(const struct cpumask *mask, nodemask_t > > *nodemsk) > > { > >-int n, nodes; > >+int n, nodes = 0; > > > > /* Calculate the number of nodes in the supplied affinity mask */ > >-for (n = 0, nodes = 0; n <

Re: [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx, kind-of-intr not provided

2016-11-21 Thread Thomas Gleixner
On Mon, 21 Nov 2016, Zubair Lutfullah Kakakhel wrote: > On 11/18/2016 01:29 PM, Thomas Gleixner wrote: > I'll elaborate on the commit message. > > The DT node in arch/powerpc for this driver is > > intc_0: interrupt-controller@8180 { > #i

Re: [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx, kind-of-intr not provided

2016-11-18 Thread Thomas Gleixner
On Mon, 14 Nov 2016, Zubair Lutfullah Kakakhel wrote: > The powerpc dts file does not have the xlnx,kind-of-intr property. > Instead of erroring out, give a warning instead. And attempt to > continue to probe the interrupt controller while assuming > kind-of-intr is 0x0 as a fall back. This is

Re: [Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

2016-10-31 Thread Thomas Gleixner
On Mon, 31 Oct 2016, Zubair Lutfullah Kakakhel wrote: > The drivers read/write function handling is a bit quirky. Can you please explain in more detail what's quirky and why it should be done differently, > And the irqmask is passed directly to the handler. I can't make any sense out of that

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-25 Thread Thomas Gleixner
On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote: > On 10/21/2016 10:48 AM, Marc Zyngier wrote: > > Shouldn't you return an error if irq is zero? > > > > I'll add the following for the error case > > pr_err("%s: Parent exists but interrupts property not defined\n" , > __func__);

Re: [PATCH] kernel: irq: fix build failure

2016-10-21 Thread Thomas Gleixner
On Fri, 21 Oct 2016, Stephen Rothwell wrote: > On Thu, 20 Oct 2016 14:55:45 +0200 (CEST) Thomas Gleixner > <t...@linutronix.de> wrote: > > I know. This is under discussion with the driver folks as we are not going > > to blindly export stuff just because someone

Re: [PATCH] kernel: irq: fix build failure

2016-10-20 Thread Thomas Gleixner
On Mon, 10 Oct 2016, Sudip Mukherjee wrote: > On Thursday 06 October 2016 11:06 PM, Sudip Mukherjee wrote: > > The allmodconfig build of powerpc is failing with the error: > > ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined! > > > > export the symbol to fix the failure. > > Hi

Re: [PATCH 1/9] mm: Hardened usercopy

2016-07-07 Thread Thomas Gleixner
On Thu, 7 Jul 2016, Kees Cook wrote: > On Thu, Jul 7, 2016 at 3:42 AM, Thomas Gleixner <t...@linutronix.de> wrote: > > I'd rather make that a weak function returning 1 which can be replaced by > > x86 for CONFIG_FRAME_POINTER=y. That also allows other architectures to > &g

Re: [PATCH 1/9] mm: Hardened usercopy

2016-07-07 Thread Thomas Gleixner
On Wed, 6 Jul 2016, Kees Cook wrote: > + > +#if defined(CONFIG_FRAME_POINTER) && defined(CONFIG_X86) > + const void *frame = NULL; > + const void *oldframe; > +#endif That's ugly > + > + /* Object is not on the stack at all. */ > + if (obj + len <= stack || stackend <= obj) > +

Re: [PATCH 2/8] char/rtc: legacy RTC is no longer supported on x86

2016-04-27 Thread Thomas Gleixner
at contain a two older implementations of > the CONFIG_RTC_DRV_CMOS driver. > > This removes x86 from the list. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Thomas Gleixner <t...@linutronix.de> ___ Linuxp

Re: [PATCH v2 2/3] x86: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Thomas Gleixner
, which ignored > CONFIG_DEBUG_PAGEALLOC. Do we need to fence this as well? > > Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Thomas Gleixner <t...@linutronix.de> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.o

Re: [PATCH v2 1/3] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC

2016-01-27 Thread Thomas Gleixner
nt...@google.com> Acked-by: Thomas Gleixner <t...@linutronix.de> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere

2016-01-26 Thread Thomas Gleixner
On Thu, 21 Jan 2016, Zhao Qiang wrote: > 127 is the theoretical up boundary of QEIC number, > in fact there only be 44 qe_ic_info now. > add check to overflow for qe_ic_info How do you trigger that overflow? The above does not explain WHY we need these checks. > diff --git

Re: [PATCH v3 27/41] x86: define __smp_xxx

2016-01-12 Thread Thomas Gleixner
; > Acked-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Thomas Gleixner <t...@linutronix.de> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 13/41] x86: reuse asm-generic/barrier.h

2016-01-12 Thread Thomas Gleixner
in preparation to refactoring this code area. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > Acked-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Thomas Gleixner <t...@linutronix.de> ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH v6 40/53] PCI: Unify skip_ioresource_align()

2015-10-01 Thread Thomas Gleixner
on...@monstr.eu> > Cc: Paul Mackerras <pau...@samba.org> > Cc: Michael Ellerman <m...@ellerman.id.au> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-a...@vger.kernel.org > Signed-off-by: Yinghai Lu <

RE: [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake

2015-09-23 Thread Thomas Gleixner
On Wed, 23 Sep 2015, Wang Dongsheng wrote: > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > > ow...@vger.kernel.org] On Behalf Of Thomas Gleixner > > Sent: Wednesday, September 23, 2015 11:49 AM > > To: Wang Dongs

RE: [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake

2015-09-22 Thread Thomas Gleixner
On Wed, 23 Sep 2015, Wang Dongsheng wrote: > > On Mon, 2015-09-21 at 16:47 +0100, Sudeep Holla wrote: > > > mpic_irq_set_wake return -ENXIO for non FSL MPIC and sets IRQF_NO_SUSPEND > > > flag for FSL ones. enable_irq_wake already returns -ENXIO if irq_set_wak > > > is not implemented. Also

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-18 Thread Thomas Gleixner
On Fri, 18 Sep 2015, Segher Boessenkool wrote: > On Fri, Sep 18, 2015 at 08:01:57PM +1000, Michael Ellerman wrote: > > Weird. > > > > Can you try: > > > > d690740f22f6 ("powerpc/powernv: Enable LEDS support") > > > > That is the commit before my merge of Scott's tree, which had all the > >

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-17 Thread Thomas Gleixner
On Wed, 16 Sep 2015, Steven Rostedt wrote: > On Wed, 16 Sep 2015 22:01:06 +0200 (CEST) > Thomas Gleixner <t...@linutronix.de> wrote: > > So now I have to chase down that one: > > > > [0.230210] ftrace: allocating 16560 entries in 49 pages > > [

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-17 Thread Thomas Gleixner
On Thu, 17 Sep 2015, Steven Rostedt wrote: > On Thu, 17 Sep 2015 16:38:52 +0200 (CEST) > Thomas Gleixner <t...@linutronix.de> wrote: > > > On Thu, 17 Sep 2015, Steven Rostedt wrote: > > > > > On Thu, 17 Sep 2015 12:13:15 +0200 (CEST) > > &g

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-17 Thread Thomas Gleixner
On Thu, 17 Sep 2015, Steven Rostedt wrote: > On Thu, 17 Sep 2015 12:13:15 +0200 (CEST) > Thomas Gleixner <t...@linutronix.de> wrote: > > > Digging deeper. My assumption that it's a post powerpc merge failure > > turned out to be wrong. > > Does 4.2 ha

[BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-16 Thread Thomas Gleixner
With this commit applied, my MPC5200 board fails to boot 4.3-rc1. The boot failure is silent. Bisection pointed straight to this commit. Reverting it on top of 4.3-rc1 works like a charm. Thanks, tglx ___ Linuxppc-dev mailing list

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-16 Thread Thomas Gleixner
On Wed, 16 Sep 2015, Scott Wood wrote: > On Wed, 2015-09-16 at 18:23 +0200, Thomas Gleixner wrote: > > With this commit applied, my MPC5200 board fails to boot 4.3-rc1. The > > boot failure is silent. > > > > Bisection pointed straight to this commit. Reverting it

Re: [patch 00/20] powerpc: Interrupt cleanups and API change preparation

2015-07-31 Thread Thomas Gleixner
On Thu, 16 Jul 2015, Michael Ellerman wrote: Sorry I missed your reply ... On Mon, 2015-07-13 at 20:50 +, Thomas Gleixner wrote: The following patch series contains the following changes: - Consolidation of chained interrupt handler setup/removal - Switch to functions

Re: [PATCH 1/3] x86, irq: Rename VECTOR_UNDEFINED and VECTOR_RETRIGGERED to IRQ_*

2015-07-17 Thread Thomas Gleixner
On Sun, 12 Jul 2015, Bjorn Helgaas wrote: The per-cpu vector_irq[] table is indexed by CPU vector numbers, and each entry contains an IRQ number. Rename the special values VECTOR_UNDEFINED and VECTOR_RETRIGGERED to IRQ_UNDEFINED and IRQ_RETRIGGERED to indicate that they are in the IRQ

Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime()

2015-07-16 Thread Thomas Gleixner
On Thu, 16 Jul 2015, Baolin Wang wrote: On 15 July 2015 at 19:55, Thomas Gleixner t...@linutronix.de wrote: On Wed, 15 Jul 2015, Baolin Wang wrote: On 15 July 2015 at 18:31, Thomas Gleixner t...@linutronix.de wrote: On Wed, 15 Jul 2015, Baolin Wang wrote: The cputime_to_timespec

Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime()

2015-07-15 Thread Thomas Gleixner
On Wed, 15 Jul 2015, Baolin Wang wrote: The cputime_to_timespec() and timespec_to_cputime() functions are not year 2038 safe on 32bit systems due to that the struct timepsec will overflow in 2038 year. And how is this relevant? cputime is not based on wall clock time at all. So what has 2038

Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime()

2015-07-15 Thread Thomas Gleixner
On Wed, 15 Jul 2015, Baolin Wang wrote: On 15 July 2015 at 18:31, Thomas Gleixner t...@linutronix.de wrote: On Wed, 15 Jul 2015, Baolin Wang wrote: The cputime_to_timespec() and timespec_to_cputime() functions are not year 2038 safe on 32bit systems due to that the struct timepsec

[patch 02/20] powerpc/52xx: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 05/20] powerpc/cell: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 11/20] powerpc/qe_ic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 14/20] powerpc/mpc52xx: Use irq_set_handler_locked()

2015-07-13 Thread Thomas Gleixner
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Search and replacement was done with coccinelle. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Jiang Liu jiang@linux.intel.com Cc: Julia Lawall julia.law...@lip6.fr Cc: Benjamin Herrenschmidt b

[patch 16/20] powerpc/ipic: Use irq_set_handler_locked()

2015-07-13 Thread Thomas Gleixner
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Search and replacement was done with coccinelle. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Jiang Liu jiang@linux.intel.com Cc: Julia Lawall julia.law...@lip6.fr Cc: Benjamin Herrenschmidt b

[patch 20/20] powerpc/cell: Prepare iic_ioexc_cascade for irq argument removal

2015-07-13 Thread Thomas Gleixner
-by: Thomas Gleixner t...@linutronix.de Cc: Julia Lawall julia.law...@lip6.fr Cc: Jiang Liu jiang@linux.intel.com --- arch/powerpc/platforms/cell/interrupt.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: tip/arch/powerpc/platforms/cell/interrupt.c

[patch 01/20] powerpc/media5200: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 06/20] powerpc/spider-pic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 09/20] powerpc/mpc7448: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 08/20] powerpc/holly: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 18/20] powerpc/mpc5121: Prepare cpld_pic_cascade for irq argument removal

2015-07-13 Thread Thomas Gleixner
-by: Thomas Gleixner t...@linutronix.de Cc: Julia Lawall julia.law...@lip6.fr Cc: Jiang Liu jiang@linux.intel.com --- arch/powerpc/platforms/512x/mpc5121_ads_cpld.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: tip/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c

[patch 04/20] powerpc/axon_msi: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 00/20] powerpc: Interrupt cleanups and API change preparation

2015-07-13 Thread Thomas Gleixner
The following patch series contains the following changes: - Consolidation of chained interrupt handler setup/removal - Switch to functions which avoid a redundant interrupt descriptor lookup - Preparation of interrupt flow handlers for the 'irq' argument removal The

[patch 07/20] powerpc/hlwd-pic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 13/20] powerpc/irq: Use access helper irq_data_get_affinity_mask()

2015-07-13 Thread Thomas Gleixner
-by: Thomas Gleixner t...@linutronix.de --- arch/powerpc/kernel/irq.c |2 +- arch/powerpc/sysdev/xics/ics-opal.c |2 +- arch/powerpc/sysdev/xics/ics-rtas.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Index: tip/arch/powerpc/kernel/irq.c

[patch 15/20] powerpc/cpm2: Use irq_set_handler_locked()

2015-07-13 Thread Thomas Gleixner
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Search and replacement was done with coccinelle. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Jiang Liu jiang@linux.intel.com Cc: Julia Lawall julia.law...@lip6.fr Cc: Benjamin Herrenschmidt b

[patch 17/20] powerpc/mpc8xx: Use irq_set_handler_locked()

2015-07-13 Thread Thomas Gleixner
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Search and replacement was done with coccinelle. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Jiang Liu jiang@linux.intel.com Cc: Julia Lawall julia.law...@lip6.fr Cc: Benjamin Herrenschmidt b

[patch 03/20] powerpc/pq2ads: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 10/20] powerpc/mpic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 12/20] powerpc/uic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc-lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Gleixner t

[patch 19/20] powerpc/85xx: Prepare cascade handlers for irq argument removal

2015-07-13 Thread Thomas Gleixner
-by: Thomas Gleixner t...@linutronix.de Cc: Julia Lawall julia.law...@lip6.fr Cc: Jiang Liu jiang@linux.intel.com --- arch/powerpc/platforms/85xx/mpc85xx_cds.c |3 ++- arch/powerpc/platforms/85xx/socrates_fpga_pic.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) Index: tip

Re: [PATCH v5 00/24] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-12 Thread Thomas Gleixner
On Fri, 12 Jun 2015, Baolin Wang wrote: Sigh. Again threading of the series failed. Some patches are, the whole series is not. Can you please get your tools straight? You neither managed to cc me on the security patch. - Modify the subject line and the changelog: timekeeping: Change the

Re: [v3,33/36] genirq: Use helper function to access irq_data-msi_desc

2015-06-03 Thread Thomas Gleixner
On Tue, 2 Jun 2015, Michael Ellerman wrote: Though I would point out we already have 16 irq_foo_get_bar() accessors?! Say thanks to the people who mindlessly fiddled in the core managed fields of irqdesc and irqdata. The hard to track down wreckage they caused me to enforce accessors. The new

Re: [PATCH v4 00/25] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-02 Thread Thomas Gleixner
On Mon, 1 Jun 2015, Baolin Wang wrote: You failed to thread the patch series again ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v4 00/25] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-02 Thread Thomas Gleixner
On Mon, 1 Jun 2015, Baolin Wang wrote: This patch series changes the 32-bit time types (timespec/itimerspec) to the 64-bit types (timespec64/itimerspec64), since 32-bit time types will break in the year 2038. That's only true for 32bit systems. All in all the patch series looks rather

Re: [Patch v2 08/14] genirq: Introduce helper function irq_data_get_affinity_mask()

2015-05-20 Thread Thomas Gleixner
On Wed, 20 May 2015, Jiang Liu wrote: Introduce helper function irq_data_get_affinity_mask() and irq_get_affinity_mask() to hide implementation details, That patch does way more than introducing the functions. Again: Patch 1: Introduce helpers Patch 2-n: Convert users subsystem wise Thanks,

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Thomas Gleixner
On Wed, 22 Apr 2015, Arnd Bergmann wrote: On Wednesday 22 April 2015 10:45:23 Thomas Gleixner wrote: On Tue, 21 Apr 2015, Thomas Gleixner wrote: So we could save one translation step if we implement new syscalls which have a scalar nsec interface instead of the timespec/timeval cruft

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Thomas Gleixner wrote: On Tue, 21 Apr 2015, Arnd Bergmann wrote: I know there are concerns about this, in particular because C11 and POSIX both require tv_nsec to be 'long', unlike timeval-tv_usec, which is a 'suseconds_t' and can be defined as 'long long

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-21 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Arnd Bergmann wrote: COMPAT_SYSCALL_DEFINE2(timer_gettime, timer_t, timer_id, struct compat_itimerspec __user *, setting) As a side note, I want to kill off the get_fs()/set_fs() calls in the process. These always make me dizzy when I try to work

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-21 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Arnd Bergmann wrote: On Tuesday 21 April 2015 16:14:26 Thomas Gleixner wrote: Note the use of a separate __kernel_itimerspec64 for the user interface here, which I think will be needed to hide the differences between the normal itimerspec on 64-bit machines

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-21 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Arnd Bergmann wrote: I know there are concerns about this, in particular because C11 and POSIX both require tv_nsec to be 'long', unlike timeval-tv_usec, which is a 'suseconds_t' and can be defined as 'long long'. a) struct timespec { time_t tv_sec; long

Re: [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: /* Set clock_realtime */ static int posix_clock_realtime_set(const clockid_t which_clock, - const struct timespec *tp) + const struct timespec64 *tp) { - return

Re: [PATCH 09/11] cputime:Introduce the cputime_to_timespec64/timespec64_to_cputime function

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: This patch introduces some functions for converting cputime to timespec64 and back, that repalce the timespec type with timespec64 type, as well as for arch/s390 and arch/powerpc architecture. No. We want a patch which adds the functions and then a

Re: [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: @@ -771,6 +771,7 @@ SYSCALL_DEFINE2(timer_gettime, timer_t, timer_id, struct itimerspec __user *, setting) { struct itimerspec cur_setting; + struct itimerspec64 cur_setting64; struct k_itimer *timr; struct k_clock

Re: [PATCH 01/11] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: This patch introduces the 'struct itimerspec64' for 64bit to replace itimerspec, and also introduces the conversion methods: itimerspec64_to_itimerspec() and itimerspec_to_itimerspec64(), that makes itimerspec to ready for 2038 year. Signed-off-by:

Re: [PATCH 03/11] time/hrtimer:Introduce hrtimer_get_res64() with timespec64 type for getting the timer resolution

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: This patch introduces hrtimer_get_res64() function to get the timer resolution with timespec64 type, and moves the hrtimer_get_res() function into FYI, That function is about to go away, but it's not a big deal to sort that out once I applied the hrtimer

Re: [PATCH 01/11] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Thomas Gleixner wrote: On Mon, 20 Apr 2015, Baolin Wang wrote: This patch introduces the 'struct itimerspec64' for 64bit to replace itimerspec, and also introduces the conversion methods: itimerspec64_to_itimerspec() and itimerspec_to_itimerspec64(), that makes

<    1   2   3   4   5   6   7   8   >