Re: [PATCH 1/2][RESEND] ehea: error handling improvement

2010-04-23 Thread Thomas Klein
On 04/22/2010 07:36 AM, David Miller wrote: From: Thomas Klein Date: Wed, 21 Apr 2010 11:10:55 +0200 Reset a port's resources only if they're actually in an error state Signed-off-by: Thomas Klein --- Patch created against net-2.6 I thought you were sorry for wasting my time an

[PATCH 2/2][RESEND] ehea: fix possible DLPAR/mem deadlock

2010-04-21 Thread Thomas Klein
Force serialization of userspace-triggered DLPAR/mem operations Signed-off-by: Thomas Klein --- Patch created against net-2.6 diff -Nurp net-2.6.orig/drivers/net/ehea/ehea.h net-2.6/drivers/net/ehea/ehea.h --- net-2.6.orig/drivers/net/ehea/ehea.h2010-04-21 10:23:21.0 +0200

[PATCH 1/2][RESEND] ehea: error handling improvement

2010-04-21 Thread Thomas Klein
Reset a port's resources only if they're actually in an error state Signed-off-by: Thomas Klein --- Patch created against net-2.6 diff -Nurp net-2.6.orig/drivers/net/ehea/ehea_main.c net-2.6/drivers/net/ehea/ehea_main.c --- net-2.6.orig/drivers/net/ehea/ehea_main.c 2010-0

[PATCH 2/2] ehea: fix possible DLPAR/mem deadlock

2010-04-19 Thread Thomas Klein
Force serialization of userspace-triggered DLPAR/mem operations Signed-off-by: Thomas Klein --- Patch created against 2.6.34-rc4 diff -Nurp linux-2.6.34-rc4.orig//drivers/net/ehea/ehea.h linux-2.6.34-rc4//drivers/net/ehea/ehea.h --- linux-2.6.34-rc4.orig//drivers/net/ehea/ehea.h 2010-04

[PATCH 1/2] ehea: error handling improvement

2010-04-19 Thread Thomas Klein
Reset a port's resources only if they're actually in an error state Signed-off-by: Thomas Klein --- Patch created against 2.6.34-rc4 diff -Nurp linux-2.6.34-rc4.orig//drivers/net/ehea/ehea_main.c linux-2.6.34-rc4//drivers/net/ehea/ehea_main.c --- linux-2.6.34-rc4.orig//driver

Re: [PATCH] powerpc: Move ehea hcall definitions into hvcall.h

2009-10-22 Thread Thomas Klein
Anton Blanchard wrote: > Move ehea hcall definitions into hvcall.h. > > Signed-off-by: Anton Blanchard Acked-by: Thomas Klein > --- > > Index: linux.trees.git/arch/powerpc/include/asm/hvcall.h > === >

[PATCH] ehea: Fix memory hotplug handling

2009-02-19 Thread Thomas Klein
Added missing set_bit() to disable data transfer when a memchange notification is handled Signed-off-by: Thomas Klein --- diff -Nurp -X dontdiff linux-2.6.29-rc4/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.29-rc4/drivers/net/ehea/ehea.h2009-02-18 16:59

[PATCH 3/3] ehea: Improve driver behaviour in low mem conditions

2009-01-21 Thread Thomas Klein
Reworked receive queue fill policies to make the driver more tolerant in low memory conditions. Signed-off-by: Thomas Klein --- diff -Nurp -X dontdiff linux-2.6.29-rc2/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c --- linux-2.6.29-rc2/drivers/net/ehea/ehea_main.c

[PATCH 2/3] ehea: Fix mem allocations which require page alignment

2009-01-21 Thread Thomas Klein
PAGE_SIZE allocations via slab are not guaranteed to be page-aligned. Fixed all memory allocations where page alignment is required by firmware. Signed-off-by: Thomas Klein --- Thanks to Nathan Lynch for this hint! diff -Nurp -X dontdiff linux-2.6.29-rc2/drivers/net/ehea/ehea_main.c

[PATCH 1/3] ehea: Use net_device_ops structure

2009-01-21 Thread Thomas Klein
Adapt to lately introduced net_device_ops structure. Signed-off-by: Thomas Klein --- diff -Nurp -X dontdiff linux-2.6.29/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.29/drivers/net/ehea/ehea.h2009-01-16 12:03:27.0 +0100 +++ patched_kernel

[PATCH] ehea: Add hugepage detection

2008-10-27 Thread Thomas Klein
d add only standard memory to the busmap which is later on used for MR registration. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- This reworked patch accounts for comments I got. It's based on davem's net-2.6.git. diff -Nurp -X dontdiff linux-2.6.27/drivers/net/ehea/ehea.h

Re: [PATCH] ehea: Add hugepage detection

2008-10-27 Thread Thomas Klein
Dave, thanks for your valuable comments - see mine below. I'll send a reworked patch asap. Thomas On Friday 24 October 2008 08:55:37 pm you wrote: > On Fri, 2008-10-24 at 13:07 +0200, Thomas Klein wrote: > > 16GB hugepages may not be part of a memory region (firmware restricti

[PATCH] ehea: Add hugepage detection

2008-10-24 Thread Thomas Klein
16GB hugepages may not be part of a memory region (firmware restriction). This patch modifies the walk_memory_resource callback fn to filter hugepages and add only standard memory to the busmap which is later on used for MR registration. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --

Re: [PATCH] [2.6.27] ehea: Fix memory hotplug support

2008-09-23 Thread Thomas Klein
Hannes Hering <[EMAIL PROTECTED]> Jeff, please apply. Acked-by: Thomas Klein <[EMAIL PROTECTED]> ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/2] ehea: fix mutex and spinlock use

2008-09-16 Thread Thomas Klein
Sebastien Dugue wrote: On Mon, 15 Sep 2008 17:18:27 +0200 Thomas Klein <[EMAIL PROTECTED]> wrote: NACK! I regret but this patch is wrong. It is not sufficient to only lock the replacement of an old list with a new list. Building up those lists is a 3-step process: 1. Count the num

Re: [PATCH 2/2] ehea: fix mutex and spinlock use

2008-09-15 Thread Thomas Klein
NACK! I regret but this patch is wrong. It is not sufficient to only lock the replacement of an old list with a new list. Building up those lists is a 3-step process: 1. Count the number of entries a list will contain and allocate mem 2. Fill the list 3. Replace old list with updated list It's

Re: [PATCH HACK] powerpc: quick hack to get a functional eHEA with hardirq preemption

2008-09-15 Thread Thomas Klein
Hi, we are a bit worried about putting this into the mainstream part of non real time linux. There interrupts work perfectly fine, and it was a bit of a challenge to get there for all cases / configurations / machines. Could you try to enable these changes only for RT-Linux via a real-time kconf

[PATCH] ehea: Fix DLPAR memory add support

2008-04-04 Thread Thomas Klein
This patch fixes two weaknesses in send/receive packet handling which may lead to kernel panics during DLPAR memory add operations. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.25-rc8/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/

[PATCH 2.6.24-stable] ehea: Fix IPv6 support

2008-03-25 Thread Thomas Klein
Indicate that HEA calculates IPv4 checksums only Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- diff -Nurp linux-2.6.24.4.org/drivers/net/ehea/ehea.h linux-2.6.24.4/drivers/net/ehea/ehea.h --- linux-2.6.24.4.org/drivers/net/ehea/ehea.h 2008-03-25 12:42:18.0 +0100 +++

Re: [PATCH] ehea: Fix IPv6 support

2008-03-25 Thread Thomas Klein
Andrew Morton wrote: > On Wed, 19 Mar 2008 13:55:43 +0100 > Thomas Klein <[EMAIL PROTECTED]> wrote: > >> Indicate that HEA calculates IPv4 checksums only >> >> Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> >> >> --- >> diff -

[PATCH] ehea: Fix IPv6 support

2008-03-19 Thread Thomas Klein
Indicate that HEA calculates IPv4 checksums only Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h2008-03-17 00:32:14.0

[PATCH] ehea: Fix missing Kconfig dependency

2008-03-03 Thread Thomas Klein
Fixed Kconfig: ehea driver requires sparse mem Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- diff -Nurp linux-2.6.25-rc3.org/drivers/net/Kconfig linux-2.6.25-rc3/drivers/net/Kconfig --- linux-2.6.25-rc3.org/drivers/net/Kconfig2008-02-24 22:25:54.0 +0100 +++ linux-2.6.

[PATCH] ehea: add kdump support

2008-02-13 Thread Thomas Klein
tored there. The arrays are kept up-to-date during normal runtime. The crash handler fn is triggered by the recently introduced PPC crash shutdown reg/unreg functions. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h | 34 +- drivers/net/ehea/ehea_ma

[RFC] ehea: kdump support - rework

2007-12-17 Thread Thomas Klein
RFC #1: http://lkml.org/lkml/2007/12/12/241 Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.24-rc5/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.24-rc5/drivers/net/ehea/ehea.h2007-12-11 04:48:43.0

[RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Thomas Klein
registrations. Please comment. Shutdown hook patches: http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048058.html http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048059.html Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.24-rc5/drivers/ne

[PATCH 2/2][2.6.24] ehea: Reworked rcv queue handling to log only fatal errors

2007-11-21 Thread Thomas Klein
Prevent driver from brawly logging packet checksum errors. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c | 11 +-- drivers/net/ehea/ehea_qmr.h |4 ++-- 3 files changed, 8 insertions(+), 9 del

[PATCH 1/2][2.6.24] ehea: Improve tx packets counting

2007-11-21 Thread Thomas Klein
Using own tx_packets counter instead of firmware counters. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ehea/ehea.h b/d

[PATCH] ehea: Add kdump support

2007-11-09 Thread Thomas Klein
ff-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c | 28 2 files changed, 29 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h index f78e5bf..5935899 100644 --

[RESEND][PATCH 3/3] ehea: Eliminated some compiler warnings

2007-08-06 Thread Thomas Klein
Fixed wrongly casted pointers Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c | 25 ++--- 1 files changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c index 36ca322..9

[RESEND][PATCH 2/3] ehea: Simplify resource usage check

2007-08-06 Thread Thomas Klein
Use shorter method to determine whether adapter has configured ports Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/ne

[RESEND][PATCH 1/3] ehea: Fix workqueue handling

2007-08-06 Thread Thomas Klein
Fix: Workqueue ehea_driver_wq was not destroyed Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/

[PATCH 3/3] ehea: Eliminated some compiler warnings

2007-07-30 Thread Thomas Klein
Fixed wrongly casted pointers Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c | 25 ++--- 1 files changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c index 36ca322..9

[PATCH 2/3] ehea: Simplify resource usage check

2007-07-30 Thread Thomas Klein
Use shorter method to determine whether adapter has configured ports Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/ne

[PATCH 1/3] ehea: Fix workqueue handling

2007-07-30 Thread Thomas Klein
Fix: Workqueue ehea_driver_wq was not destroyed Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/

Re: Possible eHEA performance issue

2007-07-20 Thread Thomas Klein
Michael Neuling wrote: > From ehea_start_xmit in ehea_main.c we have: > > if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) { > spin_lock_irqsave(&pr->netif_queue, flags); > if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) { > pr->p_stats.queue_stopped++; >

[PATCH] eHEA: Fix bonding support

2007-07-18 Thread Thomas Klein
are from the port up and down functions to the port resources setup functions. Additionally the missing update of the last_rx member of the netdev structure was added. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/n

[PATCH 1/1] eHEA: Introducing support vor DLPAR memory add

2007-07-11 Thread Thomas Klein
which performs a rebuild of the mapping table and a re-registration of the global memory region. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h | 23 +-- drivers/net/ehea/ehea_main.c | 144 +++ drivers/net/ehea/ehea_ph