On 10/1/21 11:40 AM, Daniel Axtens wrote:
Hi Vasant,
Commit 587164cd, introduced new opal message type (OPAL_MSG_PRD2) and added
opal notifier. But I missed to unregister the notifier during module unload
path. This results in below call trace if you try to unload and load
opal_prd module.
opal message type")
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-prd.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-prd.c
b/arch/powerpc/platforms/powernv/opal-prd.c
index a191f4c60ce7..113bdb151
]
__do_sys_finit_module+0xd4/0x160
[ 213.336914] [c003c4c0fdb0] [c0031e00]
system_call_exception+0x140/0x290
[ 213.336958] [c003c4c0fe10] [c000c764]
system_call_common+0xf4/0x258
Fixes: 587164cd ("powerpc/powernv: Add new opal message type")
Signed-off-by: Vasant Hegde
On 9/15/21 11:53 AM, Michael Ellerman wrote:
Vasant Hegde writes:
Currently only FSP based powernv systems supports firmware update
interfaces. Hence check that the token OPAL_FLASH_VALIDATE exists
before initalising the flash driver.
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms
On 9/15/21 11:53 AM, Michael Ellerman wrote:
Vasant Hegde writes:
Currently only FSP based powernv systems supports firmware update
interfaces. Hence check that the token OPAL_FLASH_VALIDATE exists
before initalising the flash driver.
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-dump.c
b/arch/powerpc/platforms/powernv/opal-dump.c
index 00c5a59d82d9..717d1d30ade5 100644
--- a/arch/powerpc
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-dump.c
b/arch/powerpc/platforms/powernv/opal-dump.c
index 00c5a59d82d9..717d1d30ade5 100644
--- a/arch/powerpc
Currently only FSP based powernv systems supports firmware update
interfaces. Hence check that the token OPAL_FLASH_VALIDATE exists
before initalising the flash driver.
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-flash.c | 4
1 file changed, 4 insertions(+)
diff
On 10/9/20 10:34 AM, Michael Ellerman wrote:
Vasant Hegde writes:
OPAL interrupts kernel whenever it has new error log. Kernel calls
interrupt handler (elog_event()) to retrieve event. elog_event makes
OPAL API call (opal_get_elog_size()) to retrieve elog info.
In some case before kernel
callers
are returned false. Do the final kobject delete checking
the return value of sysfs_remove_file_self().
Cc: Aneesh Kumar K.V
Cc: Mahesh Salgaonkar
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-dump.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions
eed as well. Hence change it to return
void to make this fix complete.
Fixes: c7e64b9c ("powerpc/powernv Platform dump interface")
CC: Mahesh Salgaonkar
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-dump.c | 41 +++---
1 file changed, 29 insertions(+),
On 10/9/20 10:36 AM, Michael Ellerman wrote:
Vasant Hegde writes:
diff --git a/arch/powerpc/platforms/powernv/opal-dump.c
b/arch/powerpc/platforms/powernv/opal-dump.c
index 543c816fa99e..7e6eeedec32b 100644
--- a/arch/powerpc/platforms/powernv/opal-dump.c
+++ b/arch/powerpc/platforms/powernv
when elog_event() calls opal_get_elog_size API OPAL
returns error. Its safe to ignore this error. Hence reduce the severity
of log message.
CC: Mahesh Salgaonkar
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-elog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
eed as well. Hence change it to return
void to make this fix complete.
Fixes: c7e64b9c ("powerpc/powernv Platform dump interface")
CC: Mahesh Salgaonkar
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-dump.c | 31 +-
1 file changed, 24 insertions(+)
event(>kobj, KOBJ_ADD);
+ /* Drop the extra reference count */
+ kobject_put(>kobj);
Makes sense,
Reviewed-by: Oliver O'Halloran
Reviewed-by: Vasant Hegde
return elog;
Does the returned value actually get used anywhere? We'd have a
similar use-after-free problem if it
twyler
Cc: Michael Ellerman
Signed-off-by: Vasant Hegde
---
Changes in v2:
- Updated patch description based on mpe, Tyrel comment.
-Vasant
arch/powerpc/platforms/pseries/ras.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/ras.c
b/arch/powerpc/platforms/pse
On 8/19/20 1:05 AM, Tyrel Datwyler wrote:
On 8/18/20 3:54 AM, Vasant Hegde wrote:
As per PAPR specification whenever system is running on UPS we have to
wait for predefined time (default 10mins) before initiating shutdown.
The wording in PAPR seems a little unclear. It states
EPOW_SHUTDOWN_ON_UPS event.
Fixes: 79872e35 (powerpc/pseries: All events of EPOW_SYSTEM_SHUTDOWN must
initiate shutdown)
Cc: sta...@vger.kernel.org # v4.0+
Cc: Michael Ellerman
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/pseries/ras.c | 1 -
1 file changed, 1 deletion(-)
diff --git
s/system/cpu/cpu0/topology/physical_package_id
0
#
Now lscpu output is more in line with the system configuration.
Signed-off-by: Srikar Dronamraju
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Michael Ellerman
Cc: Vasant Hegde
Cc: Vaidyanathan Srinivasan
Looks good to me.
Reviewed-by: Vasant Hegde
-Vasant
Allow copying partial data to user space. So that opal-prd daemon
can read message size, reallocate memory and make read call to
get rest of the data.
Cc: Jeremy Kerr
Cc: Vaidyanathan Srinivasan
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-prd.c | 27
On 10/3/19 10:26 AM, Jeremy Kerr wrote:
Hi Vasant,
Correct. We will have `ibm,prd-label` property. That's not the issue.
It sure sounds like the issue - someone has represented a range that
should be mapped by HBRT, but isn't appropriate for mapping by HBRT.
Here issueis HBRT is loaded
On 10/3/19 7:17 AM, Jeremy Kerr wrote:
Hi Vasant,
Jeremy,
Add check to validate whether requested page is part of system RAM
or not before mmap() and error out if its not part of system RAM.
opal_prd_range_is_valid() will return false if the reserved memory range
does not have an
Srinivasan
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-prd.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-prd.c
b/arch/powerpc/platforms/powernv/opal-prd.c
index 45f4223a790f..0f88752302a2 100644
Use "opal-msg-size" device tree property to allocate memory for "opal_msg".
Cc: Mahesh Salgaonkar
Cc: Jeremy Kerr
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal.c | 32 ++-
1 file changed, 22 insertions(+), 10 deletions(-
-off-by: Vasant Hegde
---
arch/powerpc/include/asm/opal-api.h | 1 +
arch/powerpc/platforms/powernv/opal-prd.c | 9 -
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/opal-api.h
b/arch/powerpc/include/asm/opal-api.h
index 383242eb0dea
On 8/22/19 9:06 PM, Vasant Hegde wrote:
On 8/22/19 11:21 AM, Oliver O'Halloran wrote:
On Wed, 2019-08-21 at 13:43 +0530, Vasant Hegde wrote:
Use "opal-msg-size" device tree property to allocate memory for "opal_msg".
Cc: Mahesh Salgaonkar
Cc: Jeremy Kerr
Signed-
On 8/22/19 11:21 AM, Oliver O'Halloran wrote:
On Wed, 2019-08-21 at 13:43 +0530, Vasant Hegde wrote:
Use "opal-msg-size" device tree property to allocate memory for "opal_msg".
Cc: Mahesh Salgaonkar
Cc: Jeremy Kerr
Signed-off-by: Vasant Hegde
---
Changes in v3:
- Cal
-off-by: Vasant Hegde
---
arch/powerpc/include/asm/opal-api.h | 1 +
arch/powerpc/platforms/powernv/opal-prd.c | 9 -
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/opal-api.h
b/arch/powerpc/include/asm/opal-api.h
index 383242eb0dea
Use "opal-msg-size" device tree property to allocate memory for "opal_msg".
Cc: Mahesh Salgaonkar
Cc: Jeremy Kerr
Signed-off-by: Vasant Hegde
---
Changes in v3:
- Call BUG_ON, if we fail to allocate memory during init.
-Vasant
arch/powerpc/platforms
On 06/05/2019 05:16 PM, Vasant Hegde wrote:
Use "opal-msg-size" device tree property to allocate memory for "opal_msg".
Michael,
Can you please look into this patchset?
Thanks
-Vasant
Cc: Mahesh Salgaonkar
Cc: Jeremy Kerr
Signed-off-by: Vasant Hegde
---
ar
-off-by: Vasant Hegde
---
arch/powerpc/include/asm/opal-api.h | 1 +
arch/powerpc/platforms/powernv/opal-prd.c | 9 -
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/opal-api.h
b/arch/powerpc/include/asm/opal-api.h
index 09a8553833d1
Use "opal-msg-size" device tree property to allocate memory for "opal_msg".
Cc: Mahesh Salgaonkar
Cc: Jeremy Kerr
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-
-off-by: Vasant Hegde
---
arch/powerpc/include/asm/opal-api.h | 1 +
arch/powerpc/platforms/powernv/opal-prd.c | 9 -
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/opal-api.h
b/arch/powerpc/include/asm/opal-api.h
index 821ed4fa95ad
Use "opal-msg-size" device tree property to allocate memory for "opal_msg".
Also replace `reserved` field in "struct opal_msg" with `size`. So that
opal_get_msg() user can get actual message size.
Cc: Mahesh Salgaonkar
Cc: Jeremy Kerr
Signed-off-by: Vasant Hegde
On 10/10/2018 10:53 AM, Oliver O'Halloran wrote:
Currently when we get an unknown RTAS event it prints the type as
"Unknown" and no other useful information. Add the raw type code to the
log message so that we have something to work off.
Yeah. Useful one.
Reviewed-by: Vasant Hegde
On 09/03/2018 03:56 PM, Vaibhav Jain wrote:
Ever since fast reboot is enabled by default in opal,
opal_cec_reboot() will use fast-reset instead of full IPL to perform
system reboot. This leaves the user with no direct way to force a full
IPL reboot except changing an nvram setting that
come from a NMI that interrupts OPAL code,
so re-entry to OPAL can cause a number of problems. Putting
secondaries into simple spin loops improves the chances of a
successful reboot.
Cc: Vasant Hegde <hegdevas...@linux.vnet.ibm.com>
Nick,
Patch looks good to me. We have tested this patch
On 03/27/2018 01:08 PM, Nicholas Piggin wrote:
On Tue, 27 Mar 2018 12:47:31 +0530
Vasant Hegde <hegdevas...@linux.vnet.ibm.com> wrote:
On 03/26/2018 08:32 PM, Nicholas Piggin wrote:
opal_nvram_write currently just assumes success if it encounters an
error other than OPA
On 03/27/2018 12:58 PM, Nicholas Piggin wrote:
On Tue, 27 Mar 2018 12:42:32 +0530
Vasant Hegde <hegdevas...@linux.vnet.ibm.com> wrote:
On 03/26/2018 08:39 PM, Nicholas Piggin wrote:
xmon can be entered via sreset NMI (from a management sreset, or an
NMI IPI), which can interrupt OPA
ou say?
}
+ if (rc)
+ return -EIO;
Good catch. Thanks!
Reviewed-by: Vasant Hegde <hegdevas...@linux.vnet.ibm.com>
-Vasant
On 03/26/2018 08:39 PM, Nicholas Piggin wrote:
xmon can be entered via sreset NMI (from a management sreset, or an
NMI IPI), which can interrupt OPAL. Add checks to xmon to see if pc
or sp are within OPAL memory, and if so, then use OPAL_DEBUG to
print the opal stack and return the Linux stack,
adds the 'kobject_put()' which was missing earlier.
Signed-off-by: Mukesh Ojha <mukes...@linux.vnet.ibm.com>
I've reviewed and tested this patch. Looks good to me.
Reviewed-by: Vasant Hegde <hegdevas...@linux.vnet.ibm.com>
-Vasant
Cc: sta...@vger.kernel.org
---
arch/power
rtas_rmo_buf
and we are able to make RTAS syscall.
Reported-by: Bharata B Rao <bhar...@linux.vnet.ibm.com>
CC: Dan Williams <dan.j.willi...@intel.com>
CC: Nathan Fontenot <nf...@linux.vnet.ibm.com>
CC: Michael Ellerman <m...@ellerman.id.au>
Signed-off-by: Vasant Hegde <heg
On 01/22/2016 10:59 AM, Michael Ellerman wrote:
> On Thu, 2016-01-21 at 21:45 +0530, Vasant Hegde wrote:
>
>> With commit 90a545e9 (restrict /dev/mem to idle io memory ranges) mapping
>> rtas_rmo_buf from user space is failing. Hence we are not able to make
>> RTAS syscall
On 11/18/2015 02:12 PM, Vipin K Parashar wrote:
> Kernel prints respective warnings about various EPOW events for
> user information/action after parsing EPOW interrupts. At times
> below EPOW reset event warning is seen to be flooding kernel log
> over a period of time.
>
> May 25 03:46:34 alp
his patch later this week and
update you the results.
I assume this patch is on top of LED git tree.
-Vasant
>
> Signed-off-by: Jacek Anaszewski <j.anaszew...@samsung.com>
> Cc: Vasant Hegde <hegdevas...@linux.vnet.ibm.com>
> ---
> drivers/leds/leds-powernv.c | 16 ++
XX
[22061.541675] 6000 6000
6000 6000
[22061.541688] ---[ end trace 6f9bf0b3d32096aa ]---
Reported-by: NAGESWARA R. SASTRY <nasas...@in.ibm.com>
Signed-off-by: Vasant Hegde <hegdevas...@linux.vnet.ibm.com>
---
arch/powerpc/kernel/rt
On 10/16/2015 04:02 PM, Denis Kirjanov wrote:
> On 10/16/15, Vasant Hegde <hegdevas...@linux.vnet.ibm.com> wrote:
>> Currently we do not validate rtas entry before calling enter_rtas(). This
>> is resulting in a kernel oops (see below) when user space calls rtas system
>&g
On 10/16/2015 11:49 PM, Denis Kirjanov wrote:
> On 10/16/15, Vasant Hegde <hegdevas...@linux.vnet.ibm.com> wrote:
>> On 10/16/2015 04:02 PM, Denis Kirjanov wrote:
>>> On 10/16/15, Vasant Hegde <hegdevas...@linux.vnet.ibm.com> wrote:
>>>> Currently we
as well. Hence added them to config file.
Suggested-by: Michael Ellerman m...@ellerman.id.au
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Cc: Stewart Smith stew...@linux.vnet.ibm.com
---
Changes in v2:
- As suggested by Stewart updated patch description
Michael,
This is PowerNV
On 08/27/2015 03:56 PM, Michael Ellerman wrote:
On Thu, 2015-27-08 at 06:04:10 UTC, Vasant Hegde wrote:
Commit 84ad6e5c added LEDS support for PowerNV platform. Lets
update ppc64_defconfig to pick LEDS driver.
PowerNV LEDS driver looks for /ibm,opal/leds node in device
tree and loads
On 08/26/2015 05:56 AM, Stewart Smith wrote:
Vasant Hegde hegdevas...@linux.vnet.ibm.com writes:
Presently PowerNV LEDS driver is specific to FSP based PowerNV
platform. Hence added it as 'm'. So that we will be loaded only
if we have required device tree support.
Stewart,
Currently
LEDS driver needs NEW_LEDS and LEDS_CLASS
as well. Hence added them to config file.
Suggested-by: Michael Ellerman m...@ellerman.id.au
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
---
Michael,
This is PowerNV specific config. Hence I've not updated pseries_defconfig.
Let me know
states)
Signed-off-by: Michael Ellerman m...@ellerman.id.au
Patch looks good.
Reviewed-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
-Vasant
---
arch/powerpc/include/asm/opal-api.h | 12
drivers/leds/leds-powernv.c | 6 +++---
2 files changed, 15 insertions(+), 3
On 08/22/2015 05:10 AM, Michael Ellerman wrote:
On Fri, 2015-08-21 at 14:29 +0530, Vasant Hegde wrote:
On 08/21/2015 01:55 PM, Stephen Rothwell wrote:
Hi all,
After merging the nvdimm tree, today's linux-next build (powerpc
allyesconfig) failed like this:
Stephen,
Thanks for reporting! I
On 08/21/2015 01:55 PM, Stephen Rothwell wrote:
Hi all,
After merging the nvdimm tree, today's linux-next build (powerpc
allyesconfig) failed like this:
Stephen,
Thanks for reporting! I checked powerpc tree.. This is because of commit
8a8d9181 in powerpc tree.. Basically Michael missed one
On 08/19/2015 05:24 PM, Jacek Anaszewski wrote:
Hi Vasant,
On 07/28/2015 07:40 PM, Jacek Anaszewski wrote:
Vasant,
Without my core changes your driver won't work with led triggers, but
AFAIR this use case is not relevant for your LEDs? Eventually, we could
produce a patch set adding
On 08/19/2015 06:08 PM, Jacek Anaszewski wrote:
Hi Vasant,
Hello Jacek,
I've found two superfluous lines. Please find my remarks below.
Thanks for the review. I will fix both issues and will send v10 soon.
-Vasant
___
Linuxppc-dev mailing list
implementation of LED get and set state has been
achieved through OPAL calls. These calls are made available for the
driver by exporting from architecture specific codes.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Acked-by: Stewart
location code which is passed through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Signed-off-by: Vasant Hegde hegdevas
documentation
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2):
powerpc/powernv: Create LED platform device
leds/powernv: Add driver for PowerNV platform
.../devicetree/bindings/leds/leds-powernv.txt | 26
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1
implementation of LED get and set state has been
achieved through OPAL calls. These calls are made available for the
driver by exporting from architecture specific codes.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Acked-by: Stewart
location code which is passed through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Signed-off-by: Vasant Hegde hegdevas
once are:
Removed list in powernv_led_data structure
s/kzalloc/devm_kzalloc/
Removed compatible property from documentation
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2):
powerpc/powernv: Create LED
On 08/18/2015 03:51 PM, Michael Ellerman wrote:
On Sat, 2015-25-07 at 05:21:10 UTC, Vasant Hegde wrote:
This patch implements LED driver for PowerNV platform using the existing
generic LED class framework.
PowerNV platform has below type of LEDs:
- System attention
Indicates
On 07/27/2015 03:20 PM, Jacek Anaszewski wrote:
Hi Vasant,
On 27.07.2015 05:41, Vasant Hegde wrote:
On 07/27/2015 03:11 AM, Jacek Anaszewski wrote:
Hi Vasant,
Hi Jacek,
Two trivial details left. Please find them below.
Thanks for the review/Ack. I'll fix below issues and resend
j.anaszew...@samsung.com
On 25.07.2015 07:21, Vasant Hegde wrote:
This patch implements LED driver for PowerNV platform using the existing
generic LED class framework.
PowerNV platform has below type of LEDs:
- System attention
Indicates there is a problem with the system that needs
location code which is passed through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Signed-off-by: Vasant Hegde hegdevas
available for the
driver by exporting from architecture specific codes.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Acked-by: Stewart Smith stew...@linux.vnet.ibm.com
Tested-by: Stewart Smith stew...@linux.vnet.ibm.com
https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/log/?h=next
- Added System Attention Indicator support
- Removed redundant code in leds-powernv.c file
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1
On 07/23/2015 01:25 PM, Jacek Anaszewski wrote:
Hi Vasant,
Jacek,
.../...
+/* PowerNV LED data */
+struct powernv_led_data {
+struct led_classdevcdev;
+char*loc_code;/* LED location code */
+intled_type;/* OPAL_SLOT_LED_TYPE_* */
+
redundant code in leds-powernv.c file
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2):
powerpc/powernv: Create LED platform device
leds/powernv: Add driver for PowerNV platform
.../devicetree/bindings/leds/leds
available for the
driver by exporting from architecture specific codes.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Acked-by: Stewart Smith stew...@linux.vnet.ibm.com
Tested-by: Stewart Smith stew...@linux.vnet.ibm.com
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1
location code which is passed through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Signed-off-by: Vasant Hegde hegdevas
On 07/21/2015 11:24 AM, Vasant Hegde wrote:
On 07/20/2015 03:10 AM, Jacek Anaszewski wrote:
Hi Vasant,
Jacek,
I've revised your patch and found few more issues.
Please refer to my comments below.
Thanks.
.../...
Please don't exceed 75 character line length limit.
Ok. I
On 07/20/2015 11:46 AM, Jacek Anaszewski wrote:
On 19.07.2015 23:40, Jacek Anaszewski wrote:
[...]
+/* Platform driver probe */
+static int powernv_led_probe(struct platform_device *pdev)
+{
+int num_leds;
+struct device_node *led_node;
+struct powernv_leds_priv *priv;
+
+
On 07/20/2015 03:10 AM, Jacek Anaszewski wrote:
Hi Vasant,
Jacek,
I've revised your patch and found few more issues.
Please refer to my comments below.
Thanks.
.../...
Please don't exceed 75 character line length limit.
Ok. I will fix it.. But I thought 80 character is the limit.
On 07/17/2015 08:55 PM, Jacek Anaszewski wrote:
Hi Vasant,
Hi Jacek,
.../...
As per the LED class framework, the 'brightness_set' function should not
sleep. Hence these functions have been implemented through global work
queue tasks which might sleep on OPAL async call completion.
The
https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/log/?h=next
- Added System Attention Indicator support
- Removed redundant code in leds-powernv.c file
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1
location code which is passed through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Signed-off-by: Vasant Hegde hegdevas
available for the driver by
exporting from architecture specific codes.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Acked-by: Stewart Smith stew...@linux.vnet.ibm.com
Tested-by: Stewart Smith stew...@linux.vnet.ibm.com
-powernv.c b/drivers/leds/leds-powernv.c
new file mode 100644
index 000..b5a307c
--- /dev/null
+++ b/drivers/leds/leds-powernv.c
@@ -0,0 +1,463 @@
+/*
+ * PowerNV LED Driver
+ *
+ * Copyright IBM Corp. 2015
+ *
+ * Author: Vasant Hegde hegdevas...@linux.vnet.ibm.com
+ * Author: Anshuman
On 07/16/2015 01:57 PM, Jacek Anaszewski wrote:
Hi Vasan,
Hello Jacek,
.../...
I have added as
- compatible : ibm,opal-v3-led.
Please retain Should be :.
Done.
.../...
Please parse the led type once upon initialization and add related
property to the struct powernv_led_data
On 07/16/2015 02:17 PM, Michael Ellerman wrote:
On Thu, 2015-07-16 at 10:27 +0200, Jacek Anaszewski wrote:
On 07/16/2015 08:54 AM, Vasant Hegde wrote:
+static enum led_brightness powernv_led_get(struct led_classdev *led_cdev)
+{
+char *loc_code;
+int rc, led_type;
+__be64
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1
available for the driver by
exporting from architecture specific codes.
Signed-off-by: Vasant Hegde hegdevas...@linux.vnet.ibm.com
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Acked-by: Stewart Smith stew...@linux.vnet.ibm.com
Tested-by: Stewart Smith stew...@linux.vnet.ibm.com
location code which is passed through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Signed-off-by: Vasant Hegde hegdevas
and modifying
system LED states
Vasant Hegde (2):
powerpc/powernv: Create LED platform device
leds/powernv: Add driver for PowerNV platform
.../devicetree/bindings/leds/leds-powernv.txt | 27 ++
arch/powerpc/include/asm/opal-api.h| 29 +-
arch/powerpc/include/asm/opal.h
On 06/25/2015 06:39 AM, Benjamin Herrenschmidt wrote:
On Tue, 2015-04-28 at 15:40 +0530, Vasant Hegde wrote:
+Device Tree binding for LEDs on IBM Power Systems
+-
+
+The 'led' node under '/ibm,opal' lists service indicators available
On 04/28/2015 03:39 PM, Vasant Hegde wrote:
The following series implements LED driver for PowerNV platform.
Ben, Michael,
Can you please review/ACK this patchset?
-Vasant
PowerNV platform has below type of LEDs:
- System attention
Indicates there is a problem with the system
On 04/28/2015 03:48 PM, Arnd Bergmann wrote:
On Tuesday 28 April 2015 15:40:35 Vasant Hegde wrote:
+++ b/Documentation/devicetree/bindings/leds/leds-powernv.txt
@@ -0,0 +1,29 @@
+Device Tree binding for LEDs on IBM Power Systems
+-
+
+The 'led
On 04/30/2015 07:59 PM, Jacek Anaszewski wrote:
Hi Vasant,
Hi Jacek,
.../...
diff --git a/Documentation/devicetree/bindings/leds/leds-powernv.txt
b/Documentation/devicetree/bindings/leds/leds-powernv.txt
new file mode 100644
index 000..6bb0e7e
--- /dev/null
+++
On 04/27/2015 07:17 PM, Vasant Hegde wrote:
On 04/27/2015 04:45 PM, Jacek Anaszewski wrote:
On 04/27/2015 11:53 AM, Benjamin Herrenschmidt wrote:
On Mon, 2015-04-27 at 09:24 +0200, Jacek Anaszewski wrote:
I was not aware that some other entity than the driver could be
interested
location code which is passed through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual khand...@linux.vnet.ibm.com
Signed-off-by: Vasant Hegde hegdevas
interfaces for accessing and modifying system
LED states
Vasant Hegde (2):
powerpc/powernv: Create LED platform device
leds/powernv: Add driver for PowerNV platform
.../devicetree/bindings/leds/leds-powernv.txt | 29 +
arch/powerpc/include/asm/opal-api.h| 29 +
arch
1 - 100 of 195 matches
Mail list logo
