Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

On 02-04-24, 14:25, Linus Walleij wrote: > Hi Allen, > > thanks for your patch! > > On Wed, Mar 27, 2024 at 5:03 PM Allen Pais wrote: > > > The only generic interface to execute asynchronously in the BH context is > > tasklet; however, it's marked deprecated and has some design flaws. To > >

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

On 28-03-24, 12:39, Allen wrote: > > I think that is very great idea. having this wrapped in dma_chan would > > be very good way as well > > > > Am not sure if Allen is up for it :-) > > Thanks Arnd, I know we did speak about this at LPC. I did start > working on using completion. I dropped it

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

On 28-03-24, 13:01, Allen wrote: > > >> > Since almost every driver associates the tasklet with the > > >> > dma_chan, we could go one step further and add the > > >> > work_queue structure directly into struct dma_chan, > > >> > with the wrapper operating on the dma_chan rather than > > >> > the

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

On 28-03-24, 11:08, Arnd Bergmann wrote: > On Thu, Mar 28, 2024, at 06:55, Vinod Koul wrote: > > On 27-03-24, 16:03, Allen Pais wrote: > >> The only generic interface to execute asynchronously in the BH context is > >> tasklet; however, it's marked deprecate

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

Hi Allen, Subsytem is dmaengine, can you rename this to dmaengine: ... On 27-03-24, 16:03, Allen Pais wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue

Re: [PATCH 00/59] dma: Convert to platform remove callback returning void

On 19-09-23, 15:31, Uwe Kleine-König wrote: > Hello, > > this series convert nearly all platform drivers below drivers/dma to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. I

Re: [PATCH 00/59] dma: Convert to platform remove callback returning void

On Tue, 19 Sep 2023 15:31:08 +0200, Uwe Kleine-König wrote: > this series convert nearly all platform drivers below drivers/dma to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver

Re: [PATCH v2] dmaengine: Explicitly include correct DT includes

On Tue, 18 Jul 2023 08:31:35 -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other.

Re: [PATCH v14 06/15] clk: Add Lynx 10G SerDes PLL driver

On 16-05-23, 11:11, Sean Anderson wrote: > On 5/16/23 09:22, Vinod Koul wrote: > > On 09-05-23, 11:26, Sean Anderson wrote: > >> On 5/9/23 09:00, Vinod Koul wrote: > >> > On 08-05-23, 11:31, Sean Anderson wrote: > >> >> On 5/8/23 05:15, Vinod Koul

Re: [PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver

On 08-05-23, 11:28, Sean Anderson wrote: > On 5/8/23 05:22, Vinod Koul wrote: > > On 13-04-23, 12:05, Sean Anderson wrote: > >> +static const struct lynx_cfg ls1088a_cfg = { > >> + .lanes = 4, > >> + .endian = REGMAP_ENDIAN_LITTLE, > >&

Re: [PATCH v14 06/15] clk: Add Lynx 10G SerDes PLL driver

On 09-05-23, 11:26, Sean Anderson wrote: > On 5/9/23 09:00, Vinod Koul wrote: > > On 08-05-23, 11:31, Sean Anderson wrote: > >> On 5/8/23 05:15, Vinod Koul wrote: > > > >> >> +int lynx_clks_init(struct device *dev, struct regmap *regmap, > >> >&

Re: [PATCH v14 06/15] clk: Add Lynx 10G SerDes PLL driver

On 08-05-23, 11:31, Sean Anderson wrote: > On 5/8/23 05:15, Vinod Koul wrote: > >> +int lynx_clks_init(struct device *dev, struct regmap *regmap, > >> + struct clk *plls[2], struct clk *ex_dlys[2], bool compat); > > > > so you have an exported symbol

Re: [PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver

On 13-04-23, 12:05, Sean Anderson wrote: > This adds support for the Lynx 10G "SerDes" devices found on various NXP > QorIQ SoCs. There may be up to four SerDes devices on each SoC, each > supporting up to eight lanes. Protocol support for each SerDes is highly > heterogeneous, with each SoC

Re: [PATCH v14 06/15] clk: Add Lynx 10G SerDes PLL driver

On 13-04-23, 12:05, Sean Anderson wrote: > This adds support for the PLLs found in Lynx 10G "SerDes" devices found on > various NXP QorIQ SoCs. There are two PLLs in each SerDes. This driver has > been split from the main PHY driver to allow for better review, even though > these PLLs are not

Re: [PATCH v13 07/15] phy: fsl: Add Lynx 10G SerDes driver

On 11-04-23, 14:43, Sean Anderson wrote: > This adds support for the Lynx 10G "SerDes" devices found on various NXP > QorIQ SoCs. There may be up to four SerDes devices on each SoC, each > supporting up to eight lanes. Protocol support for each SerDes is highly > heterogeneous, with each SoC

Re: [PATCH v9 00/10] phy: Add support for Lynx 10G SerDes

On 19-01-23, 11:22, Sean Anderson wrote: > On 1/18/23 11:54, Vinod Koul wrote: > > On 17-01-23, 11:46, Sean Anderson wrote: > >> > >> I noticed that this series is marked "changes requested" on patchwork. > >> However, I have received only autom

Re: [PATCH v9 00/10] phy: Add support for Lynx 10G SerDes

On 17-01-23, 11:46, Sean Anderson wrote: > > I noticed that this series is marked "changes requested" on patchwork. > However, I have received only automated feedback. I have done my best > effort to address feedback I have received on prior revisions. I would > appreciate getting another round

Re: [PATCH v6 4/8] phy: fsl: Add Lynx 10G SerDes driver

On 20-09-22, 16:23, Sean Anderson wrote: > This adds support for the Lynx 10G "SerDes" devices found on various NXP > QorIQ SoCs. There may be up to four SerDes devices on each SoC, each > supporting up to eight lanes. Protocol support for each SerDes is highly > heterogeneous, with each SoC

Re: [PATCH v5 0/8] phy: Add support for Lynx 10G SerDes

On 09-09-22, 11:05, Sean Anderson wrote: > > I noticed in patchwork [1] that this entire series is marked as "Changes > Requested," despite having received only automated feedback on one patch > in the series. I am concerned about this because last time this occurred > [2], the series received

Re: [PATCH v4 0/8] phy: Add support for Lynx 10G SerDes

On 30-08-22, 17:44, Sean Anderson wrote: > > ping? > > Vinod/Kishon: any comments on the driver itself? Not sure why this is not in my queue or pw, can you please rebase and resend Thanks -- ~Vinod

Re: [patch V3 34/35] soc: ti: ti_sci_inta_msi: Get rid of ti_sci_inta_msi_get_virq()

On 10-12-21, 23:19, Thomas Gleixner wrote: > From: Thomas Gleixner > > Just use the core function msi_get_virq(). Acked-By: Vinod Koul -- ~Vinod

Re: [patch V3 35/35] dmaengine: qcom_hidma: Cleanup MSI handling

On 10-12-21, 23:19, Thomas Gleixner wrote: > From: Thomas Gleixner > > There is no reason to walk the MSI descriptors to retrieve the interrupt > number for a device. Use msi_get_virq() instead. Acked-By: Vinod Koul -- ~Vinod

Re: [patch V3 29/35] dmaengine: mv_xor_v2: Get rid of msi_desc abuse

On 10-12-21, 23:19, Thomas Gleixner wrote: > From: Thomas Gleixner > > Storing a pointer to the MSI descriptor just to keep track of the Linux > interrupt number is daft. Use msi_get_virq() instead. Acked-By: Vinod Koul -- ~Vinod

Re: [PATCH] dmaengine: bestcomm: fix system boot lockups

On 14-10-21, 11:40, Anatolij Gustschin wrote: > memset() and memcpy() on an MMIO region like here results in a > lockup at startup on mpc5200 platform (since this first happens > during probing of the ATA and Ethernet drivers). Use memset_io() > and memcpy_toio() instead. Applied, thanks --

Re: [PATCH] bus: Make remove callback return void

turn an ignored error code and so don't anticipate > wrong expectations for driver authors. Acked-By: Vinod Koul -- ~Vinod

Re: [PATCH 14/30] Revert "s3c24xx-dma.c: Fix a typo"

On 29-03-21, 05:23, Bhaskar Chowdhury wrote: > s/transferred/transfered/ > > This reverts commit a2ddb8aea8106bd5552f8516ad7a8a26b9282a8f. This is not upstream, why not squash in. Also would make sense to write sensible changelog and not phrases and use the right subsystem conventions! Droped

Re: [PATCH 1/2] dmaengine: fsldma: Fix a resource leak in the remove function

On 12-12-20, 17:05, Christophe JAILLET wrote: > A 'irq_dispose_mapping()' call is missing in the remove function. > Add it. > > This is needed to undo the 'irq_of_parse_and_map() call from the probe > function and already part of the error handling path of the probe function. > > It was added in

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

; looks like it always returned a completely incorrect value. > > And again - the driver may have worked even with that completely > incorrect value, since the use of it seems to be very incidental. Thank you for the fix. Acked-By: Vinod Koul > > In either case ("i

Re: [PATCH][next] dmaengine: Use fallthrough pseudo-keyword

On 27-07-20, 15:34, Gustavo A. R. Silva wrote: > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index 2c508ee672b9..9b69716172a4 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -1061,16 +1061,16 @@ static bool _start(struct pl330_thread *thrd) > > if

Re: [PATCH] dmaengine: fsldma: Mark expected switch fall-through

On 11-08-19, 19:22, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > Fix the following warning (Building: powerpc-ppa8548_defconfig powerpc): > > drivers/dma/fsldma.c: In function ‘fsl_dma_chan_probe’: > drivers/dma/fsldma.c:1165:26: warning: this

Re: [PATCH] dmaengine: fsldma: Add 64-bit I/O accessors for powerpc64

On 25-01-19, 05:54, Peng Ma wrote: > Hi Vinod, > > Sorry to replay late. > 1:This patch has already send to the patchwork. > Please see the patch link: https://patchwork.kernel.org/patch/10741521/ > 2:I have already compile the fsl patches on arm and powerpc after patched >

Re: [PATCH] dmaengine: fsldma: Add 64-bit I/O accessors for powerpc64

On 24-12-18, 05:29, Peng Ma wrote: > Hi Scott, > > Oh, I did not see the in_XX64/out_XX64 supported only __powerpc64__ just now. > Thanks for your reminder. Can you send the formal patch for this... FWIW, fsl patches were not merged last cycle because of reported regression... > > #ifdef

Re: [v11 1/7] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT

On 30-10-18, 10:35, Peng Ma wrote: > From: Wen He > > This patch implement a standard macro call functions is > used to NXP dma drivers. Applied all except DTS patches, thanks -- ~Vinod

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

global macro NUMA_NO_NODE. This helps remove NUMA related assumptions like > 'invalid node' from various places redirecting them to a common definition. > > drivers/dma/dmaengine.c | 4 +++- Acked-by: Vinod Koul -- ~Vinod

Re: [PATCH] mm: Replace all open encodings for NUMA_NO_NODE

On 23-11-18, 15:24, Anshuman Khandual wrote: > --- a/drivers/dma/dmaengine.c > +++ b/drivers/dma/dmaengine.c > @@ -386,7 +386,8 @@ EXPORT_SYMBOL(dma_issue_pending_all); > static bool dma_chan_is_local(struct dma_chan *chan, int cpu) > { > int node = dev_to_node(chan->device->dev); > -

Re: [PATCH 0/6] tree-wide: simplify getting .drvdata

On Sun, Apr 22, 2018 at 11:14:08AM +0200, Wolfram Sang wrote: > I got tired of fixing this in Renesas drivers manually, so I took the big > hammer. Remove this cumbersome code pattern which got copy-pasted too much > already: > > - struct platform_device *pdev = to_platform_device(dev); > -

Re: [PATCH 07/61] dma: simplify getting .drvdata

On Thu, Apr 19, 2018 at 04:05:37PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. Do you mind splitting this per driver please, that makes it easy to manage for me :) -- ~Vinod

Re: [PATCH] dmaengine: fsldma: set BWC, DAHTS and SAHTS values correctly

On Mon, Jun 19, 2017 at 04:40:04PM +0200, Thomas Breitung wrote: > The bits of BWC, DAHTS and SAHTS in the DMA mode register must be cleared > before a new value can be or-ed in. Applied, thanks -- ~Vinod

Re: [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE

On Thu, Jun 08, 2017 at 03:25:28PM +0200, Christoph Hellwig wrote: > DMA_ERROR_CODE is not a public API and will go away. Instead properly > unwind based on the loop counter. Acked-By: Vinod Koul <vinod.k...@intel.com> -- ~Vinod

Re: [PATCH] dma/fsldma : Unmap region obtained by of_iomap

On Wed, Sep 28, 2016 at 04:15:11PM +0530, Arvind Yadav wrote: > Free memory mapping, if probe is not successful. Please use proper subsystem tags for patches. Hint: use git log to find that out Applied after fixing the tag -- ~Vinod

Re: [PATCH] drivers/dma: NO_IRQ removal from powerpc-only drivers

On Sat, Sep 10, 2016 at 07:56:04PM +1000, Michael Ellerman wrote: > We'd like to eventually remove NO_IRQ on powerpc, so remove usages of it > from powerpc-only drivers. Applied after fixing subsystem name -- ~Vinod

Re: [PATCH 7/8] dmaengine: tegra20-apb-dma: Only calculate residue if txstate exists.

On Tue, Jun 21, 2016 at 06:19:50PM +0100, Jon Hunter wrote: > > On 21/06/16 17:01, Vinod Koul wrote: > > On Wed, Jun 08, 2016 at 09:51:57AM +0100, Jon Hunter wrote: > >> Hi Peter, > >> > >> On 07/06/16 18:38, Peter Griffin wrote: > >

Re: [PATCH 0/8] Various dmaengine cleanups

On Tue, Jun 07, 2016 at 06:38:33PM +0100, Peter Griffin wrote: > Hi Vinod, > > This series is a bunch of cleanup updates to various > dmaengine drivers, based on some of the review feeback to my fdma series. Good cleanup, Applied, thanks -- ~Vinod

Re: [PATCH 7/8] dmaengine: tegra20-apb-dma: Only calculate residue if txstate exists.

On Wed, Jun 08, 2016 at 09:51:57AM +0100, Jon Hunter wrote: > Hi Peter, > > On 07/06/16 18:38, Peter Griffin wrote: > > There is no point calculating the residue if there is > > no txstate to store the value. > > > > Signed-off-by: Peter Griffin > > --- > >

Re: [PATCH 8/8] dmaengine: Remove site specific OOM error messages on kzalloc

On Wed, Jun 08, 2016 at 02:12:27PM +0200, Linus Walleij wrote: > On Tue, Jun 7, 2016 at 7:38 PM, Peter Griffin > wrote: > > > If kzalloc() fails it will issue it's own error message including > > a dump_stack(). So remove the site specific error messages. > > > >

Re: [PATCH v2 00/23] ata: sata_dwc_460ex: make it working again

On Mon, May 09, 2016 at 10:59:32PM +0300, Andy Shevchenko wrote: > On Mon, May 9, 2016 at 10:05 PM, Tejun Heo wrote: > > On Mon, May 09, 2016 at 10:13:59AM +0100, Måns Rullgård wrote: > >> Andy Shevchenko writes: > >> > >> > On Mon, May 9, 2016 at 4:09

Re: [PATCH 0/5] Use dma_pool_zalloc

On Fri, Apr 29, 2016 at 10:09:07PM +0200, Julia Lawall wrote: > Dma_pool_zalloc combines dma_pool_alloc and memset 0. The semantic patch > that makes this transformation is as follows: (http://coccinelle.lip6.fr/) Applied all dmaengine patches -- ~Vinod

Re: [PATCH 06/14] dmaengine: bcm2835: DT spelling s/interrupts-names/interrupt-names/

On Wed, Apr 20, 2016 at 05:32:11PM +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > Documentation/devicetree/bindings/sound/davinci-mcbsp.txt | 2 +- This change does not apply for me, can you please split it up and send the sound ones thru

Re: [PATCH] dmaengine:fsldma: fix memory leak

On Tue, Mar 08, 2016 at 02:02:01PM +0800, xuelin@nxp.com wrote: > From: Xuelin Shi > > adding unmap of sources and destinations while doing dequeue. Applied, thanks -- ~Vinod ___ Linuxppc-dev mailing list

Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver

On Tue, Oct 27, 2015 at 11:42:57PM +0300, Alexander Popov wrote: > >> Hello, > >> > >> I've done my best to fix the issues pointed by Timur Tabi and Vinod Koul. > >> Could I have a feedback please? > > > > I dont see to have v4 in my list :( Can you

Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver

nd peripheral devices on LocalPlus Bus. > > > Changes in v4: > > - the race condition is fixed; > > - plenty of style fixes are made; > > - devm_* functions and EPROBE_DEFER are used in probe(). > > Hello, > > I've done my best to fix the issues pointed by Timur Ta

Re: [PATCH v3 3/3] dmaengine: mpc512x: initialize with subsys_initcall()

On Thu, Sep 24, 2015 at 08:28:57PM +0300, Alexander Popov wrote: > Initialize Freescale MPC512x DMA driver with subsys_initcall() > to allow the depending drivers to call dma_request_slave_channel() > during their probe. Why can't we use defered probe ? I have been asking people to not move init

Re: [PATCH v6] dmaengine: Driver support for FSL RaidEngine device.

On Tue, Mar 03, 2015 at 02:26:22PM +0800, xuelin@freescale.com wrote: From: Xuelin Shi xuelin@freescale.com The RaidEngine is a new FSL hardware used for Raid5/6 acceration. This patch enables the RaidEngine functionality and provides hardware offloading capability for memcpy, xor

Re: [PATCH v5] dmaengine: Driver support for FSL RaidEngine device.

On Mon, Dec 15, 2014 at 10:32:28AM +0800, xuelin@freescale.com wrote: +/* Copy descriptor from per chan software queue into hardware job ring */ +static void fsl_re_issue_pending(struct dma_chan *chan) +{ + struct fsl_re_chan *re_chan; + int avail; + struct fsl_re_desc

Re: [RESEND PATCH v4] dmaengine: Driver support for FSL RaidEngine device.

On Fri, Oct 17, 2014 at 03:28:20PM +0800, xuelin@freescale.com wrote: +/* + * drivers/dma/fsl_raid.c + * + * Freescale RAID Engine device driver + * + * Author: + * Harninder Rai harninder@freescale.com + * Naveen Burmi naveenbu...@freescale.com + * + * Rewrite: + * Xuelin

Re: [PATCH v3] dmaengine: driver support for FSL RaidEngine device.

On Fri, Oct 17, 2014 at 02:13:20AM +, Xuelin Shi wrote: Hi Dan Vinod, I have sent out the v4 of this patch and not received any further feedback yet. This patch looks ruled out from the patchwork. https://patchwork.kernel.org/project/linux-dmaengine/list/?page=2 So do you know

[PATCH 0/6] dmaengine: remove FSLDMA_EXTERNAL_START

to new dependency. Vinod Koul (6): dmaengine: add dmaengine_prep_dma_sg() helper dmaengine: freescale: add and export fsl_dma_external_start() carma-fpga: use dmaengine_xxx() API carma-fpga: move to fsl_dma_external_start() dmaengine: freescale: remove FSLDMA_EXTERNAL_START control

[PATCH 1/6] dmaengine: add dmaengine_prep_dma_sg() helper

This was only prep API which didnt have an helper Signed-off-by: Vinod Koul vinod.k...@intel.com --- include/linux/dmaengine.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 3d291f5..ce8a08e 100644

[PATCH 2/6] dmaengine: freescale: add and export fsl_dma_external_start()

The freescale driver uses custom device control FSLDMA_EXTERNAL_START to put the controller in external start mode. Since we are planning to deprecate the device control, move this to exported API. Subsequent patches will remove the FSLDMA_EXTERNAL_START Signed-off-by: Vinod Koul vinod.k

[PATCH 3/6] carma-fpga: use dmaengine_xxx() API

The drivers should use dmaengine_slave_config() and dmaengine_prep_dma_sg() API instead of accessing the device_control which will be deprecated soon Signed-off-by: Vinod Koul vinod.k...@intel.com --- drivers/misc/carma/carma-fpga-program.c |9 - 1 files changed, 4 insertions(+), 5

[PATCH 5/6] dmaengine: freescale: remove FSLDMA_EXTERNAL_START control method

since users have been move to fsl_dma_external_start() API, so remove this now Signed-off-by: Vinod Koul vinod.k...@intel.com --- drivers/dma/fsldma.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 0cded86

[PATCH 4/6] carma-fpga: move to fsl_dma_external_start()

carma-fpga driver uses device control with custom FSLDMA_EXTERNAL_START command. Since we wnat to deprecate the device control, move this driver to use new fsl_dma_external_start() API Signed-off-by: Vinod Koul vinod.k...@intel.com --- drivers/misc/carma/carma-fpga-program.c |3 ++- 1 files

[PATCH 6/6] dmaengine: remove FSLDMA_EXTERNAL_START

as users have been converted, so no need of this custom method Signed-off-by: Vinod Koul vinod.k...@intel.com --- include/linux/dmaengine.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index ce8a08e..3254a03

Re: [PATCH v3 0/3] dmaengine: mpc512x: add device tree binding document and DMA channel lookup

On Wed, Jun 25, 2014 at 02:52:57PM +0400, Alexander Popov wrote: This patch series introduces a device tree binding document for the MPC512x DMA controller and adds device tree based DMA channel lookup for it. This version contains the improved device tree binding document: #dma-cells is

Re: [PATCH v5 0/3] DMA: Freescale: driver cleanups and enhancements

On Wed, May 21, 2014 at 04:03:00PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Hi Dan, Please have a look at this 3/3 as Vinod mentioned. Hi Vinod Koul, Please have a look at the v5 patch set. I dont see any objection, so applying all 3

Re: [PATCH RFC v13 1/5] dmaengine: fix comment typo

On Thu, May 15, 2014 at 06:15:31PM +0400, Alexander Popov wrote: Fix comment typo. Applied, thanks -- ~Vinod ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH RFC v13 2/5] dma: mpc512x: add support for peripheral transfers

On Thu, May 15, 2014 at 06:15:32PM +0400, Alexander Popov wrote: Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously

Re: [PATCH RFC v13 0/5] MPC512x DMA slave s/g support, OF DMA lookup

the description of 'compatible' property according part 2/7; - improve the document according Gerhard's feedback; Parts 1/7, 2/7 and 4/7 have been applied by Vinod Koul and are excluded from v13. Changes in v13: A new patch (part 1/5) is added to this series. Part 2/5: - fix style issue

Re: [PATCH RFC v12 3/7] dma: mpc512x: add support for peripheral transfers

On Thu, May 08, 2014 at 01:49:20PM +0400, Alexander Popov wrote: + case DMA_SLAVE_CONFIG: + /* + * Constraints: + * - only transfers between a peripheral device and + * memory are supported; + * - minimal

Re: [PATCH v4 8/8] DMA: Freescale: add suspend resume functions for DMA driver

On Thu, May 08, 2014 at 05:52:37PM +0800, Hongbo Zhang wrote: On 05/07/2014 04:31 PM, Shevchenko, Andriy wrote: On Sun, 2014-05-04 at 18:22 +0800, Hongbo Zhang wrote: On 05/03/2014 12:46 AM, Vinod Koul wrote: On Fri, Apr 18, 2014 at 04:17:51PM +0800, hongbo.zh...@freescale.com wrote: From

Re: [PATCH v4 1/8] DMA: Freescale: remove the unnecessary FSL_DMA_LD_DEBUG

On Fri, Apr 18, 2014 at 04:17:44PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Some codes are calling chan_dbg with FSL_DMA_LD_DEBUG surrounded, it is really unnecessary to use such a macro because chan_dbg is a wrapper of dev_dbg, we do have

Re: [PATCH v4 3/8] DMA: Freescale: remove attribute DMA_INTERRUPT of dmaengine

On Fri, Apr 18, 2014 at 04:17:46PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Delete attribute DMA_INTERRUPT because fsldma doesn't support this function, exception will be thrown if talitos is used to offload xor at the same time. Applied, thanks

Re: [PATCH v4 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

On Fri, Apr 18, 2014 at 04:17:47PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com There are several places where descriptors are freed using identical code. This patch puts this code into a function to reduce code duplication. Applied, thanks --

Re: [PATCH v4 2/8] DMA: Freescale: unify register access methods

On Fri, Apr 18, 2014 at 04:17:45PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Methods of accessing DMA controller registers are inconsistent, some registers are accessed by DMA_IN/OUT directly, while others are accessed by functions get/set_* which

Re: [PATCH v4 6/8] DMA: Freescale: change descriptor release process for supporting async_tx

On Fri, Apr 18, 2014 at 04:17:49PM +0800, hongbo.zh...@freescale.com wrote: This need review from Dan ... -- ~Vinod From: Hongbo Zhang hongbo.zh...@freescale.com Fix the potential risk when enable config NET_DMA and ASYNC_TX. Async_tx is lack of support in current release process of dma

Re: [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

On Fri, Apr 18, 2014 at 04:17:50PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com The usage of spin_lock_irqsave() is a stronger locking mechanism than is required throughout the driver. The minimum locking required should be used instead. Interrupts

Re: [PATCH v4 5/8] DMA: Freescale: move functions to avoid forward declarations

On Fri, Apr 18, 2014 at 04:17:48PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com These functions will be modified in the next patch in the series. By moving the function in a patch separate from the changes, it will make review easier. Applied,

Re: [PATCH v4 8/8] DMA: Freescale: add suspend resume functions for DMA driver

On Fri, Apr 18, 2014 at 04:17:51PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com This patch adds suspend resume functions for Freescale DMA driver. .prepare callback is used to stop further descriptors from being added into the pending queue, and

Re: [PATCH RFC v12 3/7] dma: mpc512x: add support for peripheral transfers

On Wed, Apr 23, 2014 at 05:53:25PM +0400, Alexander Popov wrote: Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously

Re: [PATCH RFC v12 5/7] dma: of: add common xlate function for matching by channel id

On Wed, Apr 23, 2014 at 05:53:27PM +0400, Alexander Popov wrote: This patch adds a new common OF dma xlate callback function which will match a channel by it's id. The binding expects one integer argument which it will use to lookup the channel by the id. Unlike of_dma_simple_xlate this

Re: [PATCH RFC v12 1/7] dma: mpc512x: reorder mpc8308 specific instructions

On Wed, Apr 23, 2014 at 05:53:23PM +0400, Alexander Popov wrote: Concentrate the specific code for MPC8308 in the 'if' branch and handle MPC512x in the 'else' branch. This modification only reorders instructions but doesn't change behaviour. Signed-off-by: Alexander Popov

Re: [PATCH RFC v12 2/7] dma: mpc512x: separate 'compatible' values for MPC512x and MPC8308

On Wed, Apr 23, 2014 at 05:53:24PM +0400, Alexander Popov wrote: MPC512x and MPC8308 have similar DMA controllers, but are independent SoCs. DMA controller driver should have separate 'compatible' values for these SoCs. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com Applied, thanks --

Re: [PATCH RFC v12 4/7] dma: mpc512x: fix freeing resources in mpc_dma_probe() and mpc_dma_remove()

On Wed, Apr 23, 2014 at 05:53:26PM +0400, Alexander Popov wrote: Fix mpc_dma_probe() error path and mpc_dma_remove(): manually free IRQs and dispose IRQ mappings before devm_* takes care of other resources. Moreover replace devm_request_irq() with request_irq() since there is no need to use it

Re: [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

On Mon, Mar 31, 2014 at 12:08:55PM +0800, Hongbo Zhang wrote: On 03/29/2014 09:45 PM, Vinod Koul wrote: On Fri, Mar 28, 2014 at 02:33:37PM +0800, Hongbo Zhang wrote: On 03/26/2014 03:01 PM, Vinod Koul wrote: On Thu, 2014-01-16 at 13:47 +0800, hongbo.zh...@freescale.com wrote: From: Hongbo

Re: [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

On Fri, Mar 28, 2014 at 02:33:37PM +0800, Hongbo Zhang wrote: On 03/26/2014 03:01 PM, Vinod Koul wrote: On Thu, 2014-01-16 at 13:47 +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com The usage of spin_lock_irqsave() is a stronger locking mechanism than

Re: [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

(chan-desc_lock); chan_dbg(chan, tasklet exit\n); } -- Vinod Koul Intel Corp. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH RFC v9 2/6] dma: mpc512x: add support for peripheral transfers

On Wed, Mar 19, 2014 at 05:26:47PM +0400, Alexander Popov wrote: Hello Andy 2014-03-14 13:47 GMT+04:00 Andy Shevchenko andriy.shevche...@linux.intel.com: On Wed, 2014-03-12 at 15:47 +0400, Alexander Popov wrote: + case DMA_SLAVE_CONFIG: + /* Constraints: +

Re: [PATCH 3/7] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

On Thu, Jan 16, 2014 at 01:47:22PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com There are several places where descriptors are freed using identical code. This patch puts this code into a function to reduce code duplication. Signed-off-by: Hongbo

Re: [PATCH] DMA: Freescale: change BWC from 256 bytes to 1024 bytes

On Thu, Jan 16, 2014 at 02:10:53PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale DMA has a feature of BandWidth Control (ab. BWC), which is currently 256 bytes and should be changed to 1024 bytes for best DMA throughput. Changing BWC from

Re: [PATCH RFC v6 4/5] dma: mpc512x: register for device tree channel lookup

On Wed, Jan 08, 2014 at 05:47:19PM +0100, Gerhard Sittig wrote: [ dropping devicetree from the Cc: list ] [ what is the semantics of DMA_PRIVATE capability flag? is documentation available beyond the initial commit message? need individual channels be handled instead of controllers? ]

Re: [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi

On Wed, Nov 13, 2013 at 10:55:23PM +0800, Nicolin Chen wrote: * ! This series of patches has a direct dependency between them. When * ! applying them, we need to apply to one single branch. Otherwise, * ! it would break currect branches. Applied, thanks -- ~Vinod Changelog v7: *

Re: [PATCH v11 0/3] DMA: Freescale: Add support for 8-channel DMA engine

On Thu, Sep 26, 2013 at 05:33:40PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Hi DMA and DT maintainers, please have a look at these V11 patches. Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch set adds support this DMA

Re: [PATCH] powerpc: add explicit OF includes for ppc4xx

...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams dan.j.willi...@intel.com Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-...@vger.kernel.org Cc: linux-cry...@vger.kernel.org --- I intend to send this patch to Linus with the rest of the DT clean-up

Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

On Mon, Oct 28, 2013 at 05:58:42AM +, Xiubo Li-B47053 wrote: Hi Dan, Vinod, +static int fsl_sai_probe(struct platform_device *pdev) { [...] + + sai-dma_params_rx.addr = res-start + SAI_RDR; + sai-dma_params_rx.maxburst = 6; + index = of_property_match_string(np,

Re: [alsa-devel] [PATCH 23/51] DMA-API: dma: pl08x: add dma_set_mask_and_coherent() call

On Thu, Sep 19, 2013 at 10:48:01PM +0100, Russell King wrote: The DMA API requires drivers to call the appropriate dma_set_mask() functions before doing any DMA mapping. Add this required call to the AMBA PL08x driver. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Vinod

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Vinod Koul vinod.k...@intel.com This also brings me question that should we force the driver to use the dma_set_mask_and_coherent() API or they have below flexiblity too? ~Vinod --- drivers/dma/edma.c |6 ++ 1 files changed

Re: [alsa-devel] [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

doing any DMA mapping. Add this required call to the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 Fixed, thanks. with fixed changelog... Acked-by: Vinod Koul vinod.k...@intel.com ~Vinod

Re: [PATCH v7 0/3] DMA: Freescale: Add support for 8-channel DMA engine

On Tue, Aug 20, 2013 at 04:33:46PM +0800, Hongbo Zhang wrote: On 07/29/2013 06:59 PM, Vinod Koul wrote: On Mon, Jul 29, 2013 at 06:49:01PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Hi Vinod, Dan, Scott and Leo, please have a look at these V7

Re: [PATCH v7 0/3] DMA: Freescale: Add support for 8-channel DMA engine

On Mon, Jul 29, 2013 at 06:49:01PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Hi Vinod, Dan, Scott and Leo, please have a look at these V7 patches. The dma relates changes look okay to me. I need someone to review and ACK the DT bindings. ~Vinod

Re: [PATCH 00/12] dma: various minor clean ups for slave drivers

On Fri, May 31, 2013 at 05:09:51PM -0700, Dan Williams wrote: On Thu, May 30, 2013 at 10:47 AM, Vinod Koul vinod.k...@intel.com wrote: On Mon, May 27, 2013 at 03:14:30PM +0300, Andy Shevchenko wrote: Here is a set of small independent patches that clean up or fix minor things across DMA

  1   2   >