[PATCH 21/21] ASoC: remove unneeded 'fast_io' parameter in regmap_config

2025-08-13 Thread Wolfram Sang
When using MMIO with regmap, fast_io is implied. No need to set it again. Signed-off-by: Wolfram Sang --- No dependencies, can be applied directly to the subsystem tree. Buildbot is happy, too. sound/soc/fsl/fsl_sai.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/fsl/fsl_sai.c b

[PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config

2025-08-13 Thread Wolfram Sang
ot an identifier. These are rare, though, I can fix them manually later. The advantage of this approach is that it produces no false positives to the best of my knowledge. Please apply individually per subsystem. There are no dependencies and buildbot is happy. Patches are based on 6.17-rc1 Ha

Re: [PATCH 0/3] i2c: remove 'of_node' from i2c_board_info

2025-05-20 Thread Wolfram Sang
On Mon, May 19, 2025 at 01:13:11PM +0200, Wolfram Sang wrote: > I promised Andy to support him in his cleanup efforts, and here is the > outcome for tidying up i2c_board_info. It seems it was easier than > anticipated. But my scanning scripts (awk, coccinelle) didn't find any > mo

Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode

2025-05-20 Thread Wolfram Sang
> I took this patch in i2c/i2c-host. Please let me know if you want > me to take also the others. To avoid the dependency with your PR, is it okay if you drop it and I take this patch via my tree? signature.asc Description: PGP signature

Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode

2025-05-19 Thread Wolfram Sang
> > - info.of_node = of_node_get(node); > > + info.fwnode = of_fwnode_handle(of_node_get(node)); > > What puzzles me here is that of_node_get(). We already do the same in the I²C > core, does it really need the second bump of the reference counting? I'd think so. i2c_board_in

[PATCH 1/3] i2c: powermac: convert of_node usage to fwnode

2025-05-19 Thread Wolfram Sang
'of_node' in i2c_boardinfo is deprecated in favor of 'fwnode'. The I2C core handles them equally, so simply convert this driver to fwnode. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-powermac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH 0/3] i2c: remove 'of_node' from i2c_board_info

2025-05-19 Thread Wolfram Sang
at is left to do. No complaint, though. Wolfram Sang (3): i2c: powermac: convert of_node usage to fwnode i2c: use only 'fwnode' for client devices i2c: remove 'of_node' member from i2c_boardinfo drivers/i2c/busses/i2c-powermac.c | 2 +- drivers/i2c/i2c-core-base.c | 3

Re: [RFC PATCH 09/10] i2c: Remove I2C_HYDRA

2024-11-14 Thread Wolfram Sang
-by: Michael Ellerman > > Acked-by: Geert Uytterhoeven > > > --- Acked-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH v2 00/60] i2c: reword first drivers according to newest specification

2024-07-11 Thread Wolfram Sang
> Thanks for this big work, at the end it turned out quite nice and > I'm happy of the outcome! Me too. And thanks for the enormous review work! signature.asc Description: PGP signature

[PATCH v2 00/60] i2c: reword first drivers according to newest specification

2024-07-06 Thread Wolfram Sang
of drivers/i2c yet. Let us first gain experience here and present the well-tested results of what we figured out to other maintainers then. This ensures they have to deal with way less patch revisions. Thanks and happy hacking! Wolfram Sang (60): i2c: reword i2c_algorithm according t

[PATCH v2 59/60] i2c: cpm: reword according to newest specification

2024-07-06 Thread Wolfram Sang
Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 specifications and replace "master/slave" with more appropriate terms. Signed-off-by: Wolfram Sang Reviewed-by: Andi Shyti Acked-by: Jochen Friedrich --- drivers/i2c/busses/i2c-cpm.c | 4 ++-- 1 file changed, 2

[PATCH v2 39/60] i2c: powermac: reword according to newest specification

2024-07-06 Thread Wolfram Sang
Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 specifications and replace "master/slave" with more appropriate terms. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-powermac.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) di

[PATCH v2 37/60] i2c: pasemi: reword according to newest specification

2024-07-06 Thread Wolfram Sang
Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 specifications and replace "master/slave" with more appropriate terms. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-pasemi-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 35/60] i2c: opal: reword according to newest specification

2024-07-06 Thread Wolfram Sang
Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 specifications and replace "master/slave" with more appropriate terms. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-opal.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/d

Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-04 Thread Wolfram Sang
vchenko Acked-by: Wolfram Sang # for I2C signature.asc Description: PGP signature

[PATCH 1/1] ALSA: aoa: soundbus: i2sbus: pcm: use 'time_left' variable with wait_for_completion_timeout()

2024-04-30 Thread Wolfram Sang
7;time_left' as a variable to make the code self explaining. Fix to the proper variable type 'unsigned long' while here. Signed-off-by: Wolfram Sang --- sound/aoa/soundbus/i2sbus/pcm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/aoa/sou

Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

2024-04-08 Thread Wolfram Sang
> > out_8(&cpm->i2c_reg->i2mod, 0x00); > > - out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Master mode */ > > + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Host mode */ > > I2COM_MASTER might be coming from the datasheet. Maybe we can just drop the comment? The value we write

Re: [PATCH 00/64] i2c: reword i2c_algorithm according to newest specification

2024-04-05 Thread Wolfram Sang
Hi Andi, hi everyone, thank you for reviewing and waiting. I had a small personal hiatus over Easter but now I am back. This series needs another cycle, so no need to hurry. I will address some of the review comments but not all. The conversion (and API improvements) are some bigger tasks, so inco

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Wolfram Sang
> Kind of odd though to change function names but not parameter names of > those very same functions. Ouch, this is definitely a valid point. Seems like this series will need a respin after all. Will wait for further comments, though. Thanks! signature.asc Description: PGP signature

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Wolfram Sang
> Acked-by: Nicolas Ferre # for at91 > Probably file names themselves will need some care, in a second time. Totally true. I am aware of that. But one step after the other... signature.asc Description: PGP signature

[PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Wolfram Sang
performed incrementally along with API changes/improvements. All these changes here are simple search/replace results. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-amd-mp2-plat.c | 2 +- drivers/i2c/busses/i2c-at91-master.c | 2 +- drivers/i2c/busses/i2c-at91-slave.c

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Wolfram Sang
> > static const struct i2c_algorithm at91_twi_algorithm = { > > - .master_xfer= at91_twi_xfer, > > + .xfer = at91_twi_xfer, > > Seems you made this by a script, can you check the indentations afterwards? Yes, I noticed as well. But other (not converted) drivers have issues there as w

[PATCH 42/64] i2c: powermac: reword according to newest specification

2024-03-22 Thread Wolfram Sang
Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms. They are also more specific because we distinguish now between a remote entity ("client") and a local one ("target")

[PATCH 14/64] i2c: cpm: reword according to newest specification

2024-03-22 Thread Wolfram Sang
Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms. They are also more specific because we distinguish now between a remote entity ("client") and a local one ("target")

[PATCH 00/64] i2c: reword i2c_algorithm according to newest specification

2024-03-22 Thread Wolfram Sang
nk you! If you have comments, hints, etc, please let me know. Happy hacking, Wolfram Wolfram Sang (64): i2c: reword i2c_algorithm according to newest specification i2c: ali15x3: reword according to newest specification i2c: altera: reword according to newest specification i2c: amd-m

Re: [PATCH v2] i2c: cpm: Remove linux,i2c-index conversion from be32

2023-12-19 Thread Wolfram Sang
On Wed, Dec 06, 2023 at 11:24:03PM +0100, Christophe Leroy wrote: > sparse reports an error on some data that gets converted from be32. > > That's because that data is typed u32 instead of __be32. > > The type is correct, the be32_to_cpu() conversion is not. > > Remove the conversion. > > Repor

Re: [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON

2023-12-19 Thread Wolfram Sang
> This series and my other series are sitting idle in patchwork > for 3 weeks now. AFAICS they have the needed ack's. > Anything missing before they can be applied? Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH 3/3] PCI: Use PCI_HEADER_TYPE_* instead of literals

2023-10-03 Thread Wolfram Sang
inen Reviewed-by: Wolfram Sang # for Renesas R-Car signature.asc Description: PGP signature

Re: [PATCH] i2c: replace deprecated strncpy

2023-09-22 Thread Wolfram Sang
On Wed, Sep 20, 2023 at 11:07:35AM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We should prefer more robust and less ambiguous string interfaces. > > `info.type` is expected to be NUL-terminated judging by its use in > `i2c_new_clien

Re: [PATCH] I2C: Explicitly include correct DT includes

2023-08-14 Thread Wolfram Sang
On Fri, Jul 14, 2023 at 11:46:16AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each oth

Re: [PATCH 00/89] i2c: Convert to platform remove callback returning void

2023-06-05 Thread Wolfram Sang
On Thu, Jun 01, 2023 at 03:54:50PM +0200, Wolfram Sang wrote: > > > I wonder how this series will go in. My expectation was that Wolfram > > picks up the whole series via his tree?! > > Will do. I am currently super-busy, though. Whole series applied to for-next. I squashed

Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new

2022-11-19 Thread Wolfram Sang
Hi Uwe, > This series completes all drivers to this new callback (unless I missed > something). It's based on current next/master. Thanks for this work, really, but oh my poor inbox... > I don't think it's feasable to apply this series in one go, so I ask the > maintainers of the changed files t

Re: [PATCH v4] i2c/pasemi: PASemi I2C controller IRQ enablement

2022-11-12 Thread Wolfram Sang
On Sat, Nov 05, 2022 at 07:56:49AM -0400, Arminder Singh wrote: > This patch adds IRQ support to the PASemi I2C controller driver to > increase the performace of I2C transactions on platforms with PASemi I2C > controllers. While primarily intended for Apple silicon platforms, this > patch should al

Re: [PATCH v3] i2c/pasemi: PASemi I2C controller IRQ enablement

2022-11-01 Thread Wolfram Sang
> > +complete(&smbus->irq_completion); > > I only realized just now that you also want to disable the interrupt > right here by writing to IMASK. This is a level sensitive interrupt at > AIC level so the moment this handler returns it will fire again until > you reach the write above after th

Re: [PATCH v2] i2c-pasemi: PASemi I2C controller IRQ enablement

2022-10-05 Thread Wolfram Sang
> Does fixing the alignment issues and the commit description justify a v3 > of the patch or should the minor fixes go out as a "resend"? Just not sure > in this particular case as the fixes seem to be very minor ones. Yes, please send a v3. Since you are only fixing whitespace issues, you can ad

Re: [PATCH v2] i2c/pasemi: PASemi I2C controller IRQ enablement

2022-10-02 Thread Wolfram Sang
Hi, some comments from me. Thanks for the patch and review! > > This version of the patch has been tested on an M1 Ultra Mac Studio, > > as well as an M1 MacBook Pro, and userspace launches successfully > > while using the IRQ path for I2C transactions. > > > > Tested-by: Arminder Singh > > I t

Re: [PATCH] macintosh/ams: Adapt declaration of ams_i2c_remove() to earlier change

2022-09-17 Thread Wolfram Sang
On Fri, Sep 16, 2022 at 11:08:02AM +0200, Uwe Kleine-König wrote: > Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed > the prototype of ams_i2c_remove() but failed to adapt the declaration. > Catch up and fix the declaration accordingly. > > Fixes: ed5c2f5fd10d ("i2c: Make rem

Re: [PATCH] macintosh/ams: Adapt declaration of ams_i2c_remove() to earlier change

2022-09-16 Thread Wolfram Sang
> I don't know how to proceed with this fix. Squashing into the broken > commit is out of the game as the commit is on a stable branch that is > already merged in a few trees. Maybe let it go in via the i2c tree? I think it would be simplest if I put it on top of my for-next branch. The other opt

Re: [PATCH] net: move from strlcpy with unused retval to strscpy

2022-08-30 Thread Wolfram Sang
> Unfortunately looks like patchwork was unable to ingest this change :( > Not sure why. vger rejected this mail because the header was too big. I updated my scripts to estimate that before sending out. > Would you mind splitting it into 3 chunks - wireless, ethernet, > everything else, and rese

[PATCH 0/2] spi: remove "spidev" nodes from DTs

2022-08-24 Thread Wolfram Sang
There were two DTs left specifying "spidev" directly. Remove them. Wolfram Sang (2): ARM: dts: stm32: argon: remove spidev node powerpc/82xx: remove spidev node from mgcoge arch/arm/boot/dts/stm32mp157c-emstamp-argon.dtsi | 6 -- arch/powerpc/boot/dts/mgcoge.dts

[PATCH 2/2] powerpc/82xx: remove spidev node from mgcoge

2022-08-24 Thread Wolfram Sang
t;powerpc/82xx: add SPI support for mgcoge") Cc: Heiko Schocher Signed-off-by: Wolfram Sang --- Please take it via your platform tree. arch/powerpc/boot/dts/mgcoge.dts | 7 --- 1 file changed, 7 deletions(-) diff --git a/arch/powerpc/boot/dts/mgcoge.dts b/arch/powerpc/boot/dts/mgcoge.dts

[PATCH] macintosh: move from strlcpy with unused retval to strscpy

2022-08-18 Thread Wolfram Sang
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wo

[PATCH] cpuidle: move from strlcpy with unused retval to strscpy

2022-08-18 Thread Wolfram Sang
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wo

[PATCH] block: move from strlcpy with unused retval to strscpy

2022-08-18 Thread Wolfram Sang
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wo

[PATCH] powerpc: move from strlcpy with unused retval to strscpy

2022-08-18 Thread Wolfram Sang
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wo

[PATCH] tty: move from strlcpy with unused retval to strscpy

2022-08-18 Thread Wolfram Sang
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wo

[PATCH] soc: move from strlcpy with unused retval to strscpy

2022-08-18 Thread Wolfram Sang
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wo

[PATCH] scsi: move from strlcpy with unused retval to strscpy

2022-08-18 Thread Wolfram Sang
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wo

Re: [PATCH] i2c: powermac: Prepare cleanup of powerpc's asm/prom.h

2022-05-04 Thread Wolfram Sang
On Sat, Apr 02, 2022 at 12:06:59PM +0200, Christophe Leroy wrote: > powerpc's asm/prom.h brings some headers that it doesn't > need itself. > > In order to clean it up, first add missing headers in > users of asm/prom.h > > Signed-off-by: Christophe Leroy Applied to for-next, thanks! signatu

Re: [PATCH v1 2/4] powerpc/mpc5xxx: Switch mpc5xxx_get_bus_frequency() to use fwnode

2022-05-04 Thread Wolfram Sang
On Wed, May 04, 2022 at 04:44:47PM +0300, Andy Shevchenko wrote: > Switch mpc5xxx_get_bus_frequency() to use fwnode in order to help > cleaning up other parts of the kernel from OF specific code. > > No functional change intended. > > Signed-off-by: Andy Shevchenko Acke

Re: [PATCH v1 1/4] powerpc/52xx: Remove dead code, i.e. mpc52xx_get_xtal_freq()

2022-05-04 Thread Wolfram Sang
Wow, MPC5200, that was a long time ago for me... > It seems mpc52xx_get_xtal_freq() is not used anywhere. Remove dead code. Looks like it. Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH] i2c: pasemi: Wait for write xfers to finish

2022-04-15 Thread Wolfram Sang
On Tue, Mar 29, 2022 at 08:38:17PM +0200, Martin Povišer wrote: > Wait for completion of write transfers before returning from the driver. > At first sight it may seem advantageous to leave write transfers queued > for the controller to carry out on its own time, but there's a couple of > issues wi

Re: [PATCH v2] i2c: pasemi: Drop I2C classes from platform driver variant

2022-02-15 Thread Wolfram Sang
On Fri, Feb 04, 2022 at 10:59:14AM +0100, Martin Povišer wrote: > Drop I2C device-probing classes from platform variant of the PASemi > controller as it is only used on platforms where I2C devices should > be instantiated in devicetree. (The I2C_CLASS_DEPRECATED flag is not > raised as up to this p

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-11 Thread Wolfram Sang
ergmann > - Renamed i2c-pasemi-apple.c to i2c-pasemi-platform.c as suggested by >Wolfram Sang > - Replaced the ioport number in the adapter name with dev_name to be >able to identify separate busses in e.g. i2cdetect. > > I still don't have access to any old PASemi hard

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-11 Thread Wolfram Sang
> > Because MAINTAINER dependencies can be a bit nasty, I suggest I drop the > > MAINTAINER additions for now and we add them later. Then, you can add > > the pasemi-core as well. D'accord? > > > > We can just split the MAINTAINERS changes into a separate patch and I can > push that one through

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-11 Thread Wolfram Sang
> MAINTAINERS. It'll probably apply cleanly to 5.15-rc5 but if that happens > again It doesn't because Linus' git doesn't have: Documentation/devicetree/bindings/pci/apple,pcie.yaml Because MAINTAINER dependencies can be a bit nasty, I suggest I drop the MAINTAINER additions for now and we add

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-09 Thread Wolfram Sang
> I still don't have access to any old PASemi hardware but the changes from > v1 are pretty small and I expect them to still work. Would still be nice > if someone with access to such hardware could give this a quick test. Looks good to me. I will wait a few more days so that people can report th

Re: [PATCH v2 10/11] i2c: pasemi: Add Apple platform driver

2021-10-09 Thread Wolfram Sang
> F: arch/arm64/boot/dts/apple/ > +F: drivers/i2c/busses/i2c-pasemi-platform.c We have no dedicated maintainer for PASEMI. Are maybe you or your project interested in maintaining the pasemi-core, too? I guess not many patches will show up and they will likely be for M1 anyhow. If so, then n

Re: Add Apple M1 support to PASemi i2c driver

2021-10-04 Thread Wolfram Sang
> i2c-8 i2c PA Semi SMBus adapter at 0x(ptrval) I2C > adapter > i2c-9 i2c PA Semi SMBus adapter at 0x(ptrval) I2C > adapter > i2c-10i2c PA Semi SMBus adapter at 0x(ptrval) > I2C adapter As Sven correctly switched f

Re: [PATCH 00/10] Add Apple M1 support to PASemi i2c driver

2021-09-29 Thread Wolfram Sang
> This looks all very good to me, I had one very minor comment. > > Whole series > > Reviewed-by: Arnd Bergmann Thanks for the series and the review! Same here, looks good to me and I only had one minor comment. signature.asc Description: PGP signature

Re: [PATCH 09/10] i2c: pasemi: Add Apple platform driver

2021-09-29 Thread Wolfram Sang
> drivers/i2c/busses/i2c-pasemi-apple.c | 122 ++ Can't we name it 'i2c-pasemi-platform.c' instead? Makes more sense to me because the other instance is named -pci. signature.asc Description: PGP signature

Re: Add Apple M1 support to PASemi i2c driver

2021-09-27 Thread Wolfram Sang
> Sure, will do that later as well! But please do it privately. For upstreaming, the patch series you sent is way better than a single patch. signature.asc Description: PGP signature

Re: [PATCH v4 5/5] bus: Make remove callback return void

2021-07-20 Thread Wolfram Sang
(For firewire) > Acked-by: Benjamin Tissoires (For hid) > Acked-by: Thorsten Scherer (For siox) > Acked-by: Sven Van Asbroeck (For anybuss) > Acked-by: Ulf Hansson (For MMC) > Signed-off-by: Uwe Kleine-König Acked-by: Wolfram Sang # for I2C Thanks, Uwe! signature.asc Description: PGP signature

Re: [PATCH v3 0/4] P2040/P2041 i2c recovery erratum

2021-05-27 Thread Wolfram Sang
On Wed, May 26, 2021 at 11:02:45AM +1000, Michael Ellerman wrote: > Wolfram Sang writes: > > On Wed, May 12, 2021 at 09:20:48AM +1200, Chris Packham wrote: > >> The P2040/P2041 has an erratum where the i2c recovery scheme > >> documented in the reference manual (and cu

Re: [PATCH v3 0/4] P2040/P2041 i2c recovery erratum

2021-05-25 Thread Wolfram Sang
On Wed, May 12, 2021 at 09:20:48AM +1200, Chris Packham wrote: > The P2040/P2041 has an erratum where the i2c recovery scheme > documented in the reference manual (and currently implemented > in the i2c-mpc.c driver) does not work. The errata document > provides an alternative that does work. This

Re: [PATCH] powerpc/embedded6xx: Remove CONFIG_MV64X60

2021-03-18 Thread Wolfram Sang
Christophe Leroy Acked-by: Wolfram Sang # for I2C signature.asc Description: PGP signature

Re: Errant readings on LM81 with T2080 SoC

2021-03-17 Thread Wolfram Sang
> Probably depends on the device implementation. I've got multiple other > I2C/SMBUS devices and the LM81 seems to be the one that objects. For the recored, there was just a similar case with a DA9063, but that one luckily had a bit to switch from SMBus to I2C mode, i.e. no timeout handling:

Re: Errant readings on LM81 with T2080 SoC

2021-03-17 Thread Wolfram Sang
> The polling code is from pre-git times. Like 2005 and earlier. > I'd say it is about time to get rid of it. Any out-of-tree users > had more than 15 years to upstream their code, after all. Parts of the polling mode might be interesting for the atomic_xfer mode maybe? Which is not implemented y

Re: Errant readings on LM81 with T2080 SoC

2021-03-11 Thread Wolfram Sang
> Bummer. What is really weird is that you see clock stretching under > CPU load. Normally clock stretching is triggered by the device, not > by the host. One example: Some hosts need an interrupt per byte to know if they should send ACK or NACK. If that interrupt is delayed, they stretch the clo

[PATCH] ALSA: ppc: keywest: remove outdated comment

2021-03-10 Thread Wolfram Sang
The I2C attach_adapter callback is gone. Remove this reference. Signed-off-by: Wolfram Sang --- sound/ppc/keywest.c | 5 - 1 file changed, 5 deletions(-) diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c index a6c1905039de..a8915100d6bb 100644 --- a/sound/ppc/keywest.c +++ b/sound/ppc

Re: [PATCH v2] i2c: cpm: Fix i2c_ram structure

2020-09-27 Thread Wolfram Sang
On Wed, Sep 23, 2020 at 04:08:40PM +0200, nico.vi...@gmail.com wrote: > From: Nicolas VINCENT > > the i2c_ram structure is missing the sdmatmp field mentionned in > datasheet for MPC8272 at paragraph 36.5. With this field missing, the > hardware would write past the allocated memory done through

Re: [PATCH v2] i2c: cpm: Fix i2c_ram structure

2020-09-23 Thread Wolfram Sang
On Wed, Sep 23, 2020 at 04:08:40PM +0200, nico.vi...@gmail.com wrote: > From: Nicolas VINCENT > > the i2c_ram structure is missing the sdmatmp field mentionned in > datasheet for MPC8272 at paragraph 36.5. With this field missing, the > hardware would write past the allocated memory done through

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-09 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id) >

Re: [PATCH] arch/powerpc: use simple i2c probe function

2020-08-10 Thread Wolfram Sang
g the identifier tables during probes. > > Signed-off-by: Stephen Kitt This is useful, helps deprecating the old probe method: Acked-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH][V2] macintosh: windfarm: remove detatch debug containing spelling mistakes

2020-08-06 Thread Wolfram Sang
On Thu, Aug 06, 2020 at 11:29:01AM +0100, Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in two debug messages. As recommended > by Wolfram Sang, these can be removed as there is plenty of debug > in the driver core. > > Signed-off-by: Colin

Re: [PATCH] macintosh: windfarm: fix spelling mistake "detatch" -> "detach"

2020-08-05 Thread Wolfram Sang
On Wed, Aug 05, 2020 at 11:43:37AM +0100, Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in DBG messages. Fix them. > > Signed-off-by: Colin Ian King These comments can go entirely. i2c_detach is long history. And for remove, we have debugging output in the driver cor

Re: [PATCH 09/20] Documentation: i2c: eliminate duplicated word

2020-07-22 Thread Wolfram Sang
On Tue, Jul 07, 2020 at 11:04:03AM -0700, Randy Dunlap wrote: > Drop doubled word "new". > > Signed-off-by: Randy Dunlap For the record: Acked-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 09/20] Documentation: i2c: eliminate duplicated word

2020-07-20 Thread Wolfram Sang
On Tue, Jul 07, 2020 at 11:04:03AM -0700, Randy Dunlap wrote: > Drop doubled word "new". > > Signed-off-by: Randy Dunlap > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > Cc: Wolfram Sang > Cc: linux-...@vger.kernel.org Reviewed-by: Wolfram Sang

Re: [PATCH] powerpc/5200: update contact email

2020-05-05 Thread Wolfram Sang
> > My 'pengutronix' address is defunct for years. Merge the entries and use > > the proper contact address. > > Is there any point adding the new address? It's just likely to bit-rot > one day too. At least, this one is a group address, not an individual one, so less likey. > I figure the git

[PATCH] powerpc/5200: update contact email

2020-05-02 Thread Wolfram Sang
My 'pengutronix' address is defunct for years. Merge the entries and use the proper contact address. Signed-off-by: Wolfram Sang --- arch/powerpc/boot/dts/pcm032.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/pcm032.dts b/arch/powerp

Re: [PATCH] i2c: powermac: use true,false for bool variable

2020-04-30 Thread Wolfram Sang
On Sun, Apr 26, 2020 at 05:42:28PM +0800, Jason Yan wrote: > In i2c_powermac_register_devices(), variable 'found_onyx' is bool and > assigned '0' and 'true' in different places. Use 'false' instead of '0'. > This fixes the following coccicheck warning: > > drivers/i2c/busses/i2c-powermac.c:318:6-1

Re: [PATCH] i2c: powermac: Simplify reading the "reg" and "i2c-address" property

2020-04-26 Thread Wolfram Sang
On Wed, Apr 08, 2020 at 03:33:53PM +0530, Aishwarya R wrote: > Use of_property_read_u32 to read the "reg" and "i2c-address" property > instead of using of_get_property to check the return values. > > Signed-off-by: Aishwarya R Applied to for-next, thanks! signature.asc Description: PGP signat

Re: [PATCH] i2c: powermac: Simplify reading the "reg" and "i2c-address" property

2020-04-21 Thread Wolfram Sang
On Wed, Apr 15, 2020 at 06:49:14PM +0530, Aishwarya R wrote: > >> Use of_property_read_u32 to read the "reg" and "i2c-address" property > >> instead of using of_get_property to check the return values. > >> > >> Signed-off-by: Aishwarya R > > > This is quite a fragile driver. Have you tested it o

Re: [PATCH] i2c: powermac: Simplify reading the "reg" and "i2c-address" property

2020-04-15 Thread Wolfram Sang
On Wed, Apr 08, 2020 at 03:33:53PM +0530, Aishwarya R wrote: > Use of_property_read_u32 to read the "reg" and "i2c-address" property > instead of using of_get_property to check the return values. > > Signed-off-by: Aishwarya R This is quite a fragile driver. Have you tested it on HW? signatur

Re: [PATCH v2] macintosh: convert to i2c_new_scanned_device

2020-03-31 Thread Wolfram Sang
On Thu, Mar 26, 2020 at 12:38:19PM +0100, Wolfram Sang wrote: > Move from the deprecated i2c_new_probed_device() to the new > i2c_new_scanned_device(). No functional change for this driver because > it doesn't check the return code anyhow. > > Signed-off-by: Wolfram Sang

[PATCH v2] macintosh: convert to i2c_new_scanned_device

2020-03-26 Thread Wolfram Sang
Move from the deprecated i2c_new_probed_device() to the new i2c_new_scanned_device(). No functional change for this driver because it doesn't check the return code anyhow. Signed-off-by: Wolfram Sang Acked-by: Michael Ellerman --- Change since v1: rebased on top of v5.6-rc7 drivers/maci

Re: [PATCH] macintosh: windfarm: fix MODINFO regression

2020-03-10 Thread Wolfram Sang
On Tue, Mar 03, 2020 at 01:50:46PM +0100, Wolfram Sang wrote: > Commit af503716ac14 made sure OF devices get an OF style modalias with > I2C events. It assumed all in-tree users were converted, yet it missed > some Macintosh drivers. > > Add an OF module device table for all wind

Re: [PATCH] i2c: powermac: correct comment about custom handling

2020-03-10 Thread Wolfram Sang
On Tue, Feb 25, 2020 at 03:26:13PM +0100, Wolfram Sang wrote: > The comment had some flaws which are now fixed: > - the prefix is 'MAC' not 'AAPL' > - no kernel coding style and too short length > - 'we do' instead of 'we to' > >

Re: [PATCH] macintosh: windfarm: fix MODINFO regression

2020-03-10 Thread Wolfram Sang
On Tue, Mar 03, 2020 at 01:50:46PM +0100, Wolfram Sang wrote: > Commit af503716ac14 made sure OF devices get an OF style modalias with > I2C events. It assumed all in-tree users were converted, yet it missed > some Macintosh drivers. > > Add an OF module device table for all wind

Re: [PATCH] macintosh: windfarm: fix MODINFO regression

2020-03-03 Thread Wolfram Sang
> > sound/aoa/codecs/onyx.c > > sound/aoa/codecs/tas.c > > These are loaded explicitly via request_module (as snd-aoa-codec-%s). Good to know, thanks! signature.asc Description: PGP signature

[PATCH] macintosh: windfarm: fix MODINFO regression

2020-03-03 Thread Wolfram Sang
core: report OF style module alias for devices registered via OF") Link: https://bugzilla.kernel.org/show_bug.cgi?id=199471 Reported-by: Erhard Furtner Tested-by: Erhard Furtner Signed-off-by: Wolfram Sang --- This should also help with this: https://lists.debian.org/debian-powerpc/2020/0

Re: [PATCH] macintosh: therm_windtunnel: fix regression when instantiating devices

2020-02-28 Thread Wolfram Sang
On Tue, Feb 25, 2020 at 03:12:29PM +0100, Wolfram Sang wrote: > Removing attach_adapter from this driver caused a regression for at > least some machines. Those machines had the sensors described in their > DT, too, so they didn't need manual creation of the sensor devices. The >

Re: [PATCH] macintosh: therm_windtunnel: fix regression when instantiating devices

2020-02-28 Thread Wolfram Sang
> I think that would be best, it's more I2C related than powerpc arch > stuff that I could review. It is more DT handling than I2C, but I am happy to take this patch. signature.asc Description: PGP signature

Re: [PATCH] macintosh: therm_windtunnel: fix regression when instantiating devices

2020-02-25 Thread Wolfram Sang
On Tue, Feb 25, 2020 at 03:41:22PM +0100, John Paul Adrian Glaubitz wrote: > Hello! > > On 2/25/20 3:12 PM, Wolfram Sang wrote: > > Adding the Debian-PPC List to reach further people maybe willing to > > test. > > This might be related [1]. IIUC, this is the same as

[PATCH] i2c: powermac: correct comment about custom handling

2020-02-25 Thread Wolfram Sang
The comment had some flaws which are now fixed: - the prefix is 'MAC' not 'AAPL' - no kernel coding style and too short length - 'we do' instead of 'we to' Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-powermac.c | 15 +++ 1 fi

[PATCH] macintosh: therm_windtunnel: fix regression when instantiating devices

2020-02-25 Thread Wolfram Sang
e to start the kthread is moved to do_probe() which will be called by both methods. Fixes: 3e7bed52719d ("macintosh: therm_windtunnel: drop using attach_adapter") Link: https://bugzilla.kernel.org/show_bug.cgi?id=201723 Reported-by: Erhard Furtner Tested-by: Erhard Furtner Signed-

[PATCH RESEND] macintosh: convert to i2c_new_scanned_device

2020-02-10 Thread Wolfram Sang
Move from the deprecated i2c_new_probed_device() to the new i2c_new_scanned_device(). No functional change for this driver because it doesn't check the return code anyhow. Signed-off-by: Wolfram Sang --- I can take this via I2C tree if this makes things easier... drivers/maci

Re: [PATCH 00/12] i2c: convert subsystem to use i2c_new_client_device()

2020-01-15 Thread Wolfram Sang
On Tue, Jan 07, 2020 at 06:47:34PM +0100, Wolfram Sang wrote: > This patch series converts the I2C subsystem to use the new API. Drivers > have been build tested. There is one user left in the SMBus part of the > core which will need a seperate series because all users of this > func

[PATCH 05/12] i2c: powermac: convert to use i2c_new_client_device()

2020-01-07 Thread Wolfram Sang
Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang --- Build tested only. drivers/i2c/busses/i2c-powermac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c

[PATCH 00/12] i2c: convert subsystem to use i2c_new_client_device()

2020-01-07 Thread Wolfram Sang
conversion has been done with a coccinelle script and further simplification have been applied when proofreading the patches. A branch is here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/i2c/new_client_device Looking forward to comments... Wolfram Sang (12): i2c: cht-wc

  1   2   3   4   5   6   7   >