Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread heying (H)
Dear Alexandre, 在 2021/3/24 17:29, Alexandre Belloni 写道: On 24/03/2021 05:09:39-0400, He Ying wrote: We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread heying (H)
Dear, 在 2021/3/24 14:22, Christophe Leroy 写道: Le 24/03/2021 à 07:14, Christophe Leroy a écrit : Le 24/03/2021 à 00:05, Alexandre Belloni a écrit : On 23/03/2021 23:18:17+0100, Alexandre Belloni wrote: Hello, On 23/03/2021 05:12:57-0400, He Ying wrote: We found these warnings in

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread heying (H)
Dear, 在 2021/3/24 6:18, Alexandre Belloni 写道: Hello, On 23/03/2021 05:12:57-0400, He Ying wrote: We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should it

Re: [PATCH -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread heying (H)
Dear Christophe, 在 2021/3/23 14:33, Christophe Leroy 写道: Le 23/03/2021 à 07:21, heying (H) a écrit : Dear Christophe, 在 2021/3/18 10:28, heying (H) 写道: 在 2021/3/17 19:16, Christophe Leroy 写道: Le 17/03/2021 à 11:34, He Ying a écrit : We found these warnings in arch/powerpc/kernel

Re: [PATCH -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread heying (H)
Dear Christophe, 在 2021/3/18 10:28, heying (H) 写道: 在 2021/3/17 19:16, Christophe Leroy 写道: Le 17/03/2021 à 11:34, He Ying a écrit : We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol

Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings

2021-03-17 Thread heying (H)
在 2021/3/17 19:57, Michael Ellerman 写道: Daniel Axtens writes: "heying (H)" writes: Thank you for your reply. 在 2021/3/17 11:04, Daniel Axtens 写道: Hi He Ying, Thank you for this patch. I'm not sure what the precise rules for Fixes are, but I wonder if this should ha

Re: [PATCH -next] powerpc: kernel/time.c - cleanup warnings

2021-03-17 Thread heying (H)
在 2021/3/17 19:16, Christophe Leroy 写道: Le 17/03/2021 à 11:34, He Ying a écrit : We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should it be static?

Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings

2021-03-16 Thread heying (H)
Thank you for your reply. 在 2021/3/17 11:04, Daniel Axtens 写道: Hi He Ying, Thank you for this patch. I'm not sure what the precise rules for Fixes are, but I wonder if this should have: Fixes: 9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses") Fixes: f79643787e0a ("powerpc/64s:

Re: [PATCH] powerpc: Fix missing prototype problems for "arch/powerpc/kernel/setup_64.c"

2021-03-15 Thread heying (H)
:48 PM, heying (H) wrote: 在 2021/3/15 20:17, Christophe Leroy 写道: You subject doesn't match the content of the patch. OK. I'll adapt that. Le 15/03/2021 à 13:04, He Ying a écrit : The variables 'uaccess_fulsh' and 'entry_flush' are not referenced outside the file. So define them as static

Re: [PATCH] powerpc: Fix missing prototype problems for "arch/powerpc/kernel/setup_64.c"

2021-03-15 Thread heying (H)
在 2021/3/15 20:17, Christophe Leroy 写道: You subject doesn't match the content of the patch. OK. I'll adapt that. Le 15/03/2021 à 13:04, He Ying a écrit : The variables 'uaccess_fulsh' and 'entry_flush' are not referenced outside the file. So define them as static to avoid the warnings.

Re: [PATCH] powerpc: define the variable 'uaccess_flush' as static

2021-03-15 Thread heying (H)
Hello, 在 2021/3/15 17:16, Christophe Leroy 写道: I think W=1 will only report missing function prototypes. sparse also reports missing variables prototypes so that's better. All should be fixed. OK. I'll try to fix all the warnings in the file "arch/powerpc/kernel/setup_64.c" reported by

Re: [PATCH] powerpc: define the variable 'uaccess_flush' as static

2021-03-15 Thread heying (H)
I think this is the case also for entry_flush. compiling with W=1 will tell you more. When I use these commands: make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- make C=2 arch/powerpc/kernel/setup_64.o ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- I find warnings as