Re: [PATCH, RFC] mv643xx_eth: move sram window setting code into the driver

2008-09-05 Thread Matt Sealey
Lennert Buytenhek wrote: On Thu, Sep 04, 2008 at 08:44:31AM -0500, Matt Sealey wrote: script, but in either case, wouldn't a real sram node in the device tree be the proper solution here? Hardcoding addresses for devices Probably. I guess you don't want to pass that info _directly_ to the m

Re: [PATCH, RFC] mv643xx_eth: move sram window setting code into the driver

2008-09-04 Thread Lennert Buytenhek
On Thu, Sep 04, 2008 at 08:44:31AM -0500, Matt Sealey wrote: > I was thinking about this actually, similar to the Efika Device Tree > Supplement for MPC5200B board (which adds a lot of device tree nodes > not present on the production model and fixes some things), we have > a Pegasos one too whic

Re: [PATCH, RFC] mv643xx_eth: move sram window setting code into the driver

2008-09-04 Thread Matt Sealey
I was thinking about this actually, similar to the Efika Device Tree Supplement for MPC5200B board (which adds a lot of device tree nodes not present on the production model and fixes some things), we have a Pegasos one too which changes some very minor stuff. This could be in the kernel (chrp fi

[PATCH, RFC] mv643xx_eth: move sram window setting code into the driver

2008-09-03 Thread Lennert Buytenhek
This gets rid of a big mv643xx_eth annoyance of mine where the driver exports the offsets of some of its internal registers via a header file, and the Pegasos platform code ioremaps the peripheral directly and pokes into peripheral registers directly without involving the driver at all. I don't ha