Joel Schopp writes:
As for the technical comments, I agree with all of them and will
incorporate them into the next version.
Mark Nelson is working on new memcpy and __copy_tofrom_user routines
that look like they will be simpler than the old ones as well as being
faster, particularly on
[EMAIL PROTECTED] writes:
The current 64 bit csum_partial_copy_generic function is based on the 32
bit version and never was optimized for 64 bit. This patch takes the 64 bit
memcpy and adapts it to also do the sum. It has been tested on a variety
of input sizes and alignments on Power5
Thanks for doing this. A few comments below, but first, can you
clarify what your and George Fulk's roles were in producing this? I had
the impression George had written the code, and if that's the case,
you need to put a From: George Fulk ... line as the first line of
your mail when you
Did you consider the other alternative? If you work on 32-bit chunks
instead of 64-bit chunks (either load them with lwz, or split them
after loading with ld), you can add them up with a regular non-carrying
add, which isn't serialising like adde; this also allows unrolling the
loop (using
The current 64 bit csum_partial_copy_generic function is based on the 32
bit version and never was optimized for 64 bit. This patch takes the 64 bit
memcpy and adapts it to also do the sum. It has been tested on a variety
of input sizes and alignments on Power5 and Power6 processors. It
