Re: [PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs

2008-04-21 Thread Benjamin Herrenschmidt
On Mon, 2008-04-21 at 17:31 -0500, Kumar Gala wrote: > Ok, but we'd also need to fix setup_750_7400_hid0 and > setup_745x_specifics to test. > > There's a bit more cleanup that needs to be done here. I'm not > going > to worry about it for this patch since it covers handling a chip > errat

Re: [PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs

2008-04-21 Thread Kumar Gala
On Apr 21, 2008, at 5:12 PM, Benjamin Herrenschmidt wrote: On Mon, 2008-04-21 at 17:04 -0500, Kumar Gala wrote: On Apr 21, 2008, at 4:22 PM, Benjamin Herrenschmidt wrote: _GLOBAL(__setup_cpu_603) - b setup_common_caches + mflrr4 +BEGIN_FTR_SECTION + bl __in

Re: [PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs

2008-04-21 Thread Benjamin Herrenschmidt
On Mon, 2008-04-21 at 17:04 -0500, Kumar Gala wrote: > On Apr 21, 2008, at 4:22 PM, Benjamin Herrenschmidt wrote: > > > >> > >> _GLOBAL(__setup_cpu_603) > >> - b setup_common_caches > >> + mflrr4 > >> +BEGIN_FTR_SECTION > >> + bl __init_fpu_registers > >> +END_FTR_SECTION_IFCLR(C

Re: [PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs

2008-04-21 Thread Kumar Gala
On Apr 21, 2008, at 4:22 PM, Benjamin Herrenschmidt wrote: _GLOBAL(__setup_cpu_603) - b setup_common_caches + mflrr4 +BEGIN_FTR_SECTION + bl __init_fpu_registers +END_FTR_SECTION_IFCLR(CPU_FTR_FPU_UNAVAILABLE) + bl __init_fpu_registers + bl

Re: [PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs

2008-04-21 Thread Benjamin Herrenschmidt
> > _GLOBAL(__setup_cpu_603) > - b setup_common_caches > + mflrr4 > +BEGIN_FTR_SECTION > + bl __init_fpu_registers > +END_FTR_SECTION_IFCLR(CPU_FTR_FPU_UNAVAILABLE) > + bl __init_fpu_registers > + bl setup_common_caches > + mtlrr4 > + blr

Re: [PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs

2008-04-21 Thread Kumar Gala
On Apr 21, 2008, at 3:19 PM, Gabriel Paubert wrote: On Mon, Apr 21, 2008 at 02:57:47PM -0500, Kumar Gala wrote: 603 CPUs have the same issue that some 750 CPUs have in that they can crash in funny ways if a store from an FPU register instruction is executed on a register that has never been

Re: [PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs

2008-04-21 Thread Gabriel Paubert
On Mon, Apr 21, 2008 at 02:57:47PM -0500, Kumar Gala wrote: > 603 CPUs have the same issue that some 750 CPUs have in that they can crash > in funny ways if a store from an FPU register instruction is executed on a > register that has never been initialized since power on. This patch fixes > it by

[PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs

2008-04-21 Thread Kumar Gala
603 CPUs have the same issue that some 750 CPUs have in that they can crash in funny ways if a store from an FPU register instruction is executed on a register that has never been initialized since power on. This patch fixes it by making sure all FP registers have been properly initialized at kern