Re: [PATCH] [V1] USB: Add support for Xilinx USB host controller

2009-09-21 Thread Benjamin Herrenschmidt
On Tue, 2009-09-22 at 02:56 +0400, Anton Vorontsov wrote: > On Tue, Sep 22, 2009 at 06:49:40AM +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2009-09-21 at 13:38 -0600, Julie Zhu wrote: > > > > > + iounmap(hcd->regs); > > > +err_ioremap: > > > + irq_dispose_mapping(irq); > > > > You missed that

Re: [PATCH] [V1] USB: Add support for Xilinx USB host controller

2009-09-21 Thread Anton Vorontsov
On Tue, Sep 22, 2009 at 06:49:40AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2009-09-21 at 13:38 -0600, Julie Zhu wrote: > > > + iounmap(hcd->regs); > > +err_ioremap: > > + irq_dispose_mapping(irq); > > You missed that one too :-) > > I'm actually considering making irq_dispose_mapping(

Re: [PATCH] [V1] USB: Add support for Xilinx USB host controller

2009-09-21 Thread Benjamin Herrenschmidt
On Mon, 2009-09-21 at 13:38 -0600, Julie Zhu wrote: > + iounmap(hcd->regs); > +err_ioremap: > + irq_dispose_mapping(irq); You missed that one too :-) I'm actually considering making irq_dispose_mapping() a private API and rename it to something like __irq_dispose_mapping() :-) I think t

Re: [PATCH] [V1] USB: Add support for Xilinx USB host controller

2009-09-21 Thread Grant Likely
On Mon, Sep 21, 2009 at 12:38 PM, Julie Zhu wrote: > Add bus glue driver for Xilinx USB host controller. The controller can be > configured as HS only or HS/FS hybrid. The driver uses the device tree file > to configure the driver according to the setting in the hardware system. Looks good, one m

[PATCH] [V1] USB: Add support for Xilinx USB host controller

2009-09-21 Thread Julie Zhu
Add bus glue driver for Xilinx USB host controller. The controller can be configured as HS only or HS/FS hybrid. The driver uses the device tree file to configure the driver according to the setting in the hardware system. This driver has been tested with usbtest using the NET2280 PCI card. Signe