Re: [PATCH] [v5] Add idle wait support for 44x platforms

2008-04-10 Thread Olof Johansson
On Fri, Apr 11, 2008 at 02:18:22AM +0200, Arnd Bergmann wrote: > On Thursday 10 April 2008, Jerone Young wrote: > > Well it could be this simple. But the current code leaves a lot more > > room to add different type waits or spins if need be (if they are ever > > needed ... though none off the top

Re: [PATCH] [v5] Add idle wait support for 44x platforms

2008-04-10 Thread Josh Boyer
On Fri, 2008-04-11 at 02:18 +0200, Arnd Bergmann wrote: > > > static int __init idle_param(char *p) > > > { > > > if (!strcmp(modes[i].name, "spin")) > > > ppc_md.power_save = NULL; > > > } > > > early_param("idle", idle_param); > > > > > > if you statically initialize the ppc_

Re: [PATCH] [v5] Add idle wait support for 44x platforms

2008-04-10 Thread Arnd Bergmann
On Thursday 10 April 2008, Jerone Young wrote: > Well it could be this simple. But the current code leaves a lot more > room to add different type waits or spins if need be (if they are ever > needed ... though none off the top of my head at the moment)...but it > does allow you to create another w

Re: [PATCH] [v5] Add idle wait support for 44x platforms

2008-04-10 Thread Jerone Young
On Thu, 2008-04-10 at 15:44 +0200, Arnd Bergmann wrote: > On Tuesday 08 April 2008, Jerone Young wrote: > > +static struct sleep_mode modes[] = { > > + { .name = "wait", .entry = &ppc44x_idle }, > > + { .name = "spin", .entry = NULL }, > > +}; > > + > > +int __init ppc44x_idle_init(void

Re: [PATCH] [v5] Add idle wait support for 44x platforms

2008-04-10 Thread Arnd Bergmann
On Tuesday 08 April 2008, Jerone Young wrote: > +static struct sleep_mode modes[] = { > +   { .name = "wait", .entry = &ppc44x_idle }, > +   { .name = "spin", .entry = NULL }, > +}; > + > +int __init ppc44x_idle_init(void) > +{ > +   void *func = modes[current_mode].entry; > +   ppc

Re: [PATCH] [v5] Add idle wait support for 44x platforms

2008-04-10 Thread Josh Boyer
On Tue, 08 Apr 2008 11:49:14 -0500 Jerone Young <[EMAIL PROTECTED]> wrote: > 2 files changed, 77 insertions(+), 1 deletion(-) > arch/powerpc/platforms/44x/Makefile |2 > arch/powerpc/platforms/44x/idle.c | 76 +++ > > > Updates: Now setting MSR_WE is now de

Re: [kvm-ppc-devel] [PATCH] [v5] Add idle wait support for 44x platforms

2008-04-08 Thread Hollis Blanchard
On Tuesday 08 April 2008 11:49:14 Jerone Young wrote: > 2 files changed, 77 insertions(+), 1 deletion(-) > arch/powerpc/platforms/44x/Makefile |2 > arch/powerpc/platforms/44x/idle.c | 76 > +++ > > > Updates: Now setting MSR_WE is now default > Tested

[PATCH] [v5] Add idle wait support for 44x platforms

2008-04-08 Thread Jerone Young
2 files changed, 77 insertions(+), 1 deletion(-) arch/powerpc/platforms/44x/Makefile |2 arch/powerpc/platforms/44x/idle.c | 76 +++ Updates: Now setting MSR_WE is now default Tested on hardware platforms bamboo & sequioa and appears things