Re: [PATCH] ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()

2022-10-27 Thread Takashi Iwai
On Thu, 27 Oct 2022 09:41:03 +0200, Yang Yingliang wrote: > > > On 2022/10/27 14:38, Takashi Iwai wrote: > > On Thu, 27 Oct 2022 03:34:38 +0200, > > Yang Yingliang wrote: > >> dev_set_name() in soundbus_add_one() allocates memory for name, it need be > >> freed when of_device_register() fails, ca

Re: [PATCH] ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()

2022-10-27 Thread Yang Yingliang
On 2022/10/27 14:38, Takashi Iwai wrote: On Thu, 27 Oct 2022 03:34:38 +0200, Yang Yingliang wrote: dev_set_name() in soundbus_add_one() allocates memory for name, it need be freed when of_device_register() fails, call soundbus_dev_put() to give up the reference that hold in device_initialize()

Re: [PATCH] ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()

2022-10-26 Thread Takashi Iwai
On Thu, 27 Oct 2022 03:34:38 +0200, Yang Yingliang wrote: > > dev_set_name() in soundbus_add_one() allocates memory for name, it need be > freed when of_device_register() fails, call soundbus_dev_put() to give up > the reference that hold in device_initialize(), so that it can be freed in > kobjec

[PATCH] ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()

2022-10-26 Thread Yang Yingliang
dev_set_name() in soundbus_add_one() allocates memory for name, it need be freed when of_device_register() fails, call soundbus_dev_put() to give up the reference that hold in device_initialize(), so that it can be freed in kobject_cleanup() when the refcount hit to 0. And other resources are also