Re: [PATCH] AMCC Crypto4xx Device Driver v2]

2008-10-29 Thread Kim Phillips
On Tue, 28 Oct 2008 19:18:20 -0700 James Hsiao [EMAIL PROTECTED] wrote: On Tue, 2008-10-28 at 20:51 -0400, Josh Boyer wrote: - The question on ABLKCIPHER kconfig was ignored Is ABLKCIPHER a sub set of BLKCIPHER? So, if BLKCIPHER is selected then if ABLKCIPHER is present, it will use

Re: [PATCH] AMCC Crypto4xx Device Driver v2]

2008-10-29 Thread James Hsiao
Hi Kim, Thanks for comments. Please see inline. James On Wed, 2008-10-29 at 10:54 -0500, Kim Phillips wrote: On Tue, 28 Oct 2008 19:18:20 -0700 James Hsiao [EMAIL PROTECTED] wrote: On Tue, 2008-10-28 at 20:51 -0400, Josh Boyer wrote: - The question on ABLKCIPHER kconfig was ignored Is

Re: [PATCH] AMCC Crypto4xx Device Driver v2]

2008-10-29 Thread James Hsiao
Our crypto engine has a ring architecture, the descriptor ring is controlled by two variable head and tail. head only get increased/0 when we get a request. tail obly get increased/0 in packet done interrupt. It is safe if anytime we can only get one request. Yes, it's possible to have multiple

Re: [PATCH] AMCC Crypto4xx Device Driver v2]

2008-10-28 Thread James Hsiao
Hi Josh, Yes, I did miss couple of Kim's comments. Also, I did not include the message when I submit the V2 patch to Kim. That patch have format problem so nobody except Kim recieved it. Please see inline. Thanks James On Tue, 2008-10-28 at 20:51 -0400, Josh Boyer wrote: On Tue, 28 Oct 2008