Re: [PATCH] ASoC: Use of_node_name_eq for node name comparisons

2018-12-06 Thread Rob Herring
On Wed, Dec 5, 2018 at 7:53 PM Nicolin Chen wrote: > > Hi Rob, > > On Thu, Dec 6, 2018 at 3:51 AM Rob Herring wrote: > > > > Convert string compares of DT node names to use of_node_name_eq helper > > instead. This removes direct access to the node name pointer. > > > > For the FSL ASoC card, the

Re: [alsa-devel] [PATCH] ASoC: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Kuninori Morimoto
Hi Rob > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For the FSL ASoC card, the full node names appear to be "ssi", "esai", > and "sai", so there's not any reason to use strstr and of_node_name_eq > c

Re: [PATCH] ASoC: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Nicolin Chen
Hi Rob, On Thu, Dec 6, 2018 at 3:51 AM Rob Herring wrote: > > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For the FSL ASoC card, the full node names appear to be "ssi", "esai", > and "sai", so there's n

[PATCH] ASoC: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. For the FSL ASoC card, the full node names appear to be "ssi", "esai", and "sai", so there's not any reason to use strstr and of_node_name_eq can be used instead. C