RE: [alsa-devel] [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-03-01 Thread S.j. Wang
Hi > On 3/1/19 12:32 AM, S.j. Wang wrote: > > This case is covered by S24_LE I think. The S32_LE means the data is > > 32bit and slot width Is 32bit, this is not in data sheet. > > The problem is that if you have 32-bit samples in your audio file, and you > want to play them, then software

Re: [alsa-devel] [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-03-01 Thread Timur Tabi
On 3/1/19 12:32 AM, S.j. Wang wrote: This case is covered by S24_LE I think. The S32_LE means the data is 32bit and slot width Is 32bit, this is not in data sheet. The problem is that if you have 32-bit samples in your audio file, and you want to play them, then software (e.g. alsalib) will

RE: [alsa-devel] [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-02-28 Thread S.j. Wang
> > It would be a mistake to remove S32_LE from the format list. > > If you removed that, then we wouldn't be able to do 32 bit native playback > - it would force users to go through an ALSA plugin. > > If you look at the cs42448 data sheet for example, the I2S and TDM bus > uses a 32 bit

Re: [alsa-devel] [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-02-28 Thread Matt Flax
It would be a mistake to remove S32_LE from the format list. If you removed that, then we wouldn't be able to do 32 bit native playback - it would force users to go through an ALSA plugin. If you look at the cs42448 data sheet for example, the I2S and TDM bus uses a 32 bit word size. For

Re: [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-02-28 Thread Nicolin Chen
Hi Shengjiu, On Thu, Feb 28, 2019 at 05:56:31AM +, S.j. Wang wrote: > cs42xx8 is a 24-bit A/D and 24-bit D/A device, so the S32_LE > should not be in the supported format list. > > Signed-off-by: Shengjiu Wang > --- > sound/soc/codecs/cs42xx8.c | 3 +-- This is for cs42xx8 codec driver,

RE: [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-02-28 Thread S.j. Wang
Hi > > cs42xx8 is a 24-bit A/D and 24-bit D/A device, so the S32_LE should > > not be in the supported format list. > > > > Signed-off-by: Shengjiu Wang > > Is the device capable of accepting 32-bit samples, even if it downgrades it to > 24-bit internally? If so, then maybe

Re: [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-02-28 Thread Timur Tabi
On 2/27/19 11:56 PM, S.j. Wang wrote: cs42xx8 is a 24-bit A/D and 24-bit D/A device, so the S32_LE should not be in the supported format list. Signed-off-by: Shengjiu Wang Is the device capable of accepting 32-bit samples, even if it downgrades it to 24-bit internally? If so, then maybe

[PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-02-27 Thread S.j. Wang
cs42xx8 is a 24-bit A/D and 24-bit D/A device, so the S32_LE should not be in the supported format list. Signed-off-by: Shengjiu Wang --- sound/soc/codecs/cs42xx8.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42xx8.c b/sound/soc/codecs/cs42xx8.c