Re: [PATCH] ASoC: fsl_sai: Fix incorrect condition check in trigger()

2014-04-14 Thread Mark Brown
On Fri, Apr 11, 2014 at 10:10:00PM +0800, Nicolin Chen wrote: + /* Check if the opposite FRDE is also disabled */ + if (!(tx ? rcsr FSL_SAI_CSR_FRDE : tcsr FSL_SAI_CSR_FRDE)) { I've applied this since it's a fix but this is *not* a triumph of legibility, the ternery

Re: [PATCH] ASoC: fsl_sai: Fix incorrect condition check in trigger()

2014-04-14 Thread Nicolin Chen
On Mon, Apr 14, 2014 at 09:31:26PM +0100, Mark Brown wrote: On Fri, Apr 11, 2014 at 10:10:00PM +0800, Nicolin Chen wrote: + /* Check if the opposite FRDE is also disabled */ + if (!(tx ? rcsr FSL_SAI_CSR_FRDE : tcsr FSL_SAI_CSR_FRDE)) { I've applied this since it's

[PATCH] ASoC: fsl_sai: Fix incorrect condition check in trigger()

2014-04-11 Thread Nicolin Chen
Patch ASoC: fsl_sai: Fix buggy configurations in trigger() doesn't entirely fix the condition: FRDE of the current substream direction is being cleared while the code is still using the non-updated one. Thus this patch fixes this issue by checking the opposite one's FRDE alone since the current