[PATCH] Audit: push audit success and retcode into arch ptrace.h

2011-06-02 Thread Eric Paris
The audit system previously expected arches calling to audit_syscall_exit to supply as arguments if the syscall was a success and what the return code was. Audit also provides a helper AUDITSC_RESULT which was supposed to simplify by converting from negative retcodes to an audit internal magic

Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h

2011-06-02 Thread H. Peter Anvin
On 06/02/2011 02:04 PM, Eric Paris wrote: The audit system previously expected arches calling to audit_syscall_exit to supply as arguments if the syscall was a success and what the return code was. Audit also provides a helper AUDITSC_RESULT which was supposed to simplify by converting from

Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h

2011-06-02 Thread Richard Weinberger
Am Donnerstag 02 Juni 2011, 23:04:58 schrieb Eric Paris: b/arch/um/sys-i386/shared/sysdep/ptrace.h index d50e62e..ef5c310 100644 --- a/arch/um/sys-i386/shared/sysdep/ptrace.h +++ b/arch/um/sys-i386/shared/sysdep/ptrace.h @@ -162,6 +162,7 @@ struct syscall_args { #define UPT_ORIG_SYSCALL(r)

Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h

2011-06-02 Thread Tony Luck
But there seems to be another problem. Why is pt_regs of type void *? gcc complains: In file included from include/linux/fsnotify.h:15:0,                 from include/linux/security.h:26,                 from init/main.c:32: include/linux/audit.h: In function ‘audit_syscall_exit’:

Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h

2011-06-02 Thread Richard Weinberger
Am Freitag 03 Juni 2011, 01:00:51 schrieb Tony Luck: But there seems to be another problem. Why is pt_regs of type void *? gcc complains: In file included from include/linux/fsnotify.h:15:0, from include/linux/security.h:26, from init/main.c:32:

Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h

2011-06-02 Thread Eric Paris
On 06/02/2011 06:32 PM, Richard Weinberger wrote: Am Donnerstag 02 Juni 2011, 23:04:58 schrieb Eric Paris: b/arch/um/sys-i386/shared/sysdep/ptrace.h index d50e62e..ef5c310 100644 --- a/arch/um/sys-i386/shared/sysdep/ptrace.h +++ b/arch/um/sys-i386/shared/sysdep/ptrace.h @@ -162,6 +162,7 @@

Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h

2011-06-02 Thread Eric Paris
On 06/02/2011 07:00 PM, Tony Luck wrote: But there seems to be another problem. Why is pt_regs of type void *? gcc complains: In file included from include/linux/fsnotify.h:15:0, from include/linux/security.h:26, from init/main.c:32: include/linux/audit.h: