[PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

I think this is how it should be done, but please review: it was not tested. -- Balance alloc/free and ioremap/iounmap Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/powerpc/platforms/pasemi/gpio_mdio.c b/arch/powerpc/platforms/pasemi/gpio_mdio.c index dae9f65..f250ba4 100644

Re: [PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

Hi, Roel Kluin wrote: I think this is how it should be done, but please review: it was not tested. -- Balance alloc/free and ioremap/iounmap It would be more helpful if your changelog identified the objects which could be leaked. More comments below. -static int __devinit

Re: [PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

On Sun, Nov 04, 2007 at 05:53:40PM +0100, Roel Kluin wrote: I think this is how it should be done, but please review: it was not tested. Hi, Thanks for the bug report. The mdio driver needs a set of other cleanups as well. I have a more comprehensive patch that I'll post tomorrow after I have

Re: [PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

Nathan Lynch wrote: Hi, I moved res to the wrong function, that's fixed as well as the unlikely's and the extra new lines. Thanks for your quick response. Here is an updated version: -- Upon errors gpio_regs was not iounmapped, and later priv nor new_bus-irq was freed. Testing succes of the

Re: [PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

Olof Johansson wrote: On Sun, Nov 04, 2007 at 05:53:40PM +0100, Roel Kluin wrote: I think this is how it should be done, but please review: it was not tested. Hi, Thanks for the bug report. The mdio driver needs a set of other cleanups as well. I have a more comprehensive patch that I'll