Re: [PATCH] Consolidate mm_context_t definition in mmu.h

2007-07-11 Thread Josh Boyer
On Wed, 2007-07-11 at 12:33 +0200, Christoph Hellwig wrote: > > mm_context_id_t isn't actually used anywhere but in te mm_context_t > definition. So if you kill it you have two common fields and a bunch > of additional ones for PPC64 leading to a defintion like: > > typedef struct { > unsi

Re: [PATCH] Consolidate mm_context_t definition in mmu.h

2007-07-11 Thread Christoph Hellwig
On Tue, Jul 10, 2007 at 10:01:49AM -0500, Josh Boyer wrote: > + > +#ifdef CONFIG_PPC64 > +typedef unsigned long mm_context_id_t; > + > +typedef struct { > + mm_context_id_t id; > + u16 user_psize; /* page size index */ > + > +#ifdef CONFIG_PPC_MM_SLICES > + u64 low_slices_psize;

Re: [PATCH] Consolidate mm_context_t definition in mmu.h

2007-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2007, Josh Boyer wrote: > > +       u16 user_psize;         /* page size index */ > > + > > +#ifdef CONFIG_PPC64 > > This needs to be moved up to encompass the u16 user_psize member as > well, yes? > Yes, of course. my bad. Arnd <>< ___

Re: [PATCH] Consolidate mm_context_t definition in mmu.h

2007-07-10 Thread Josh Boyer
On Tue, 2007-07-10 at 18:36 +0200, Arnd Bergmann wrote: > On Tuesday 10 July 2007, Josh Boyer wrote: > > +#ifdef CONFIG_PPC64 > > +typedef unsigned long mm_context_id_t; > > + > > +typedef struct { > > + mm_context_id_t id; > > + u16 user_psize; /* page size index */ > > + > > +

Re: [PATCH] Consolidate mm_context_t definition in mmu.h

2007-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2007, Josh Boyer wrote: > +#ifdef CONFIG_PPC64 > +typedef unsigned long mm_context_id_t; > + > +typedef struct { > +   mm_context_id_t id; > +   u16 user_psize; /* page size index */ > + > +#ifdef CONFIG_PPC_MM_SLICES > +   u64 low_slices_psize;   /* SLB page

[PATCH] Consolidate mm_context_t definition in mmu.h

2007-07-10 Thread Josh Boyer
All of the platforms except PPC64 share a common mm_context_t definition. Defining it in mmu.h avoids duplicating it in the platform specific mmu header files. Signed-off-by: Josh Boyer <[EMAIL PROTECTED]> --- include/asm-powerpc/mmu-44x.h |5 - include/asm-powerpc/mmu-8xx.h