Re: [PATCH] Do not inline putprops function

2009-08-10 Thread Milton Miller
On Thu Aug 6 at about 02:49:38 EST in 2009, M. Mohan Kumar wrote: > > When I align the dtstruct variable to 8 bytes, I am able to invoke kdump. > > When the line > static unsigned dtstruct[TREEWORDS], *dt; > changed to > static unsigned dtstruct[TREEWORDS] __attribute__ ((aligned (8)

Re: [PATCH] Do not inline putprops function

2009-08-09 Thread Michael Ellerman
On Fri, 2009-08-07 at 20:24 +0530, M. Mohan Kumar wrote: > On Fri, Aug 07, 2009 at 08:05:49PM +0530, M. Mohan Kumar wrote: > > Hi, > > > > After enabling EARLY_DEBUG (and DEBUG in some of the files in > > arch/powerpc/kernel directory), without forcing the dtstruct variable to 8 > > byte alignment

Re: [PATCH] Do not inline putprops function

2009-08-07 Thread M. Mohan Kumar
On Fri, Aug 07, 2009 at 08:05:49PM +0530, M. Mohan Kumar wrote: > Hi, > > After enabling EARLY_DEBUG (and DEBUG in some of the files in > arch/powerpc/kernel directory), without forcing the dtstruct variable to 8 > byte alignment: > > # ./kexec -e > Starting new kernel > console [udbg0] enabled

Re: [PATCH] Do not inline putprops function

2009-08-07 Thread M. Mohan Kumar
Hi, After enabling EARLY_DEBUG (and DEBUG in some of the files in arch/powerpc/kernel directory), without forcing the dtstruct variable to 8 byte alignment: # ./kexec -e Starting new kernel console [udbg0] enabled -> early_setup(), dt_ptr: 0x7723000 -> early_init_devtree(c7723000) Inva

Re: [PATCH] Do not inline putprops function

2009-08-06 Thread Michael Ellerman
On Wed, 2009-08-05 at 22:19 +0530, M. Mohan Kumar wrote: > Hi, > > When I align the dtstruct variable to 8 bytes, I am able to invoke kdump. > > When the line > static unsigned dtstruct[TREEWORDS], *dt; > changed to > static unsigned dtstruct[TREEWORDS] __attribute__ ((aligned (8))),

Re: [PATCH] Do not inline putprops function

2009-08-05 Thread M. Mohan Kumar
Hi, When I align the dtstruct variable to 8 bytes, I am able to invoke kdump. When the line static unsigned dtstruct[TREEWORDS], *dt; changed to static unsigned dtstruct[TREEWORDS] __attribute__ ((aligned (8))), *dt; kexec-tool works. Regards, M. Mohan Kumar On Mon, Aug 03, 20

Re: [PATCH] Do not inline putprops function

2009-08-02 Thread M. Mohan Kumar
On Wed, Jun 24, 2009 at 10:27:43AM +1000, Michael Ellerman wrote: > On Tue, 2009-06-23 at 09:56 -0400, Neil Horman wrote: > > On Tue, Jun 23, 2009 at 06:25:34PM +0530, M. Mohan Kumar wrote: > > > > > Well it definately looks like removing that variable had some code changes. > > It'll take some ti

Re: [PATCH] Do not inline putprops function

2009-06-23 Thread Michael Ellerman
On Tue, 2009-06-23 at 09:56 -0400, Neil Horman wrote: > On Tue, Jun 23, 2009 at 06:25:34PM +0530, M. Mohan Kumar wrote: > > On Wed, Jun 17, 2009 at 10:40:07AM -0400, Neil Horman wrote: > > > > > > send objdump of fs2dt.o with and without this assignment. > > > > > > > That would be a fine thing

Re: [PATCH] Do not inline putprops function

2009-06-17 Thread Neil Horman
On Wed, Jun 17, 2009 at 07:56:52PM +0530, M. Mohan Kumar wrote: > On Wed, Jun 17, 2009 at 10:05:14AM -0400, Neil Horman wrote: > > On Wed, Jun 17, 2009 at 07:04:35PM +0530, M. Mohan Kumar wrote: > > > On Wed, Jun 17, 2009 at 09:04:13AM -0400, Neil Horman wrote: > > > > On Wed, Jun 17, 2009 at 10:26

Re: [PATCH] Do not inline putprops function

2009-06-17 Thread M. Mohan Kumar
On Wed, Jun 17, 2009 at 10:05:14AM -0400, Neil Horman wrote: > On Wed, Jun 17, 2009 at 07:04:35PM +0530, M. Mohan Kumar wrote: > > On Wed, Jun 17, 2009 at 09:04:13AM -0400, Neil Horman wrote: > > > On Wed, Jun 17, 2009 at 10:26:35PM +1000, Michael Ellerman wrote: > > > > > > > > What compiler vers

Re: [PATCH] Do not inline putprops function

2009-06-17 Thread Neil Horman
On Wed, Jun 17, 2009 at 07:04:35PM +0530, M. Mohan Kumar wrote: > On Wed, Jun 17, 2009 at 09:04:13AM -0400, Neil Horman wrote: > > On Wed, Jun 17, 2009 at 10:26:35PM +1000, Michael Ellerman wrote: > > > > > > What compiler version are you using? Does the behaviour change if you > > > use a newer/o

Re: [PATCH] Do not inline putprops function

2009-06-17 Thread M. Mohan Kumar
On Wed, Jun 17, 2009 at 09:04:13AM -0400, Neil Horman wrote: > On Wed, Jun 17, 2009 at 10:26:35PM +1000, Michael Ellerman wrote: > > > > What compiler version are you using? Does the behaviour change if you > > use a newer/older compiler? It sounds to me like there's some deeper bug > > and your p

Re: [PATCH] Do not inline putprops function

2009-06-17 Thread Neil Horman
On Wed, Jun 17, 2009 at 10:26:35PM +1000, Michael Ellerman wrote: > On Wed, 2009-06-17 at 17:29 +0530, M. Mohan Kumar wrote: > > Do not inline putprops function > > > > With the recent kexec-tools git tree, both kexec and kdump kernels hang (i.e > > kexec -l and kexec -p respectively). This happen

Re: [PATCH] Do not inline putprops function

2009-06-17 Thread Michael Ellerman
On Wed, 2009-06-17 at 17:29 +0530, M. Mohan Kumar wrote: > Do not inline putprops function > > With the recent kexec-tools git tree, both kexec and kdump kernels hang (i.e > kexec -l and kexec -p respectively). This happened after the patch "ppc64: > cleanups" commit b43a84a31a4be6ed025c1bdef3bb1c

Re: [PATCH] Do not inline putprops function

2009-06-17 Thread Simon Horman
On Wed, Jun 17, 2009 at 05:04:56PM +0530, M. Mohan Kumar wrote: > Do not inline putprops function > > With the recent kexec-tools git tree, both kexec and kdump kernels hang (i.e > kexec -l and kexec -p respectively). This happened after the patch "ppc64: > cleanups" commit b43a84a31a4be6ed025c1bd

[PATCH] Do not inline putprops function

2009-06-17 Thread M. Mohan Kumar
Do not inline putprops function With the recent kexec-tools git tree, both kexec and kdump kernels hang (i.e kexec -l and kexec -p respectively). This happened after the patch "ppc64: cleanups" commit b43a84a31a4be6ed025c1bdef3bb1c3c12e01b16. I tried reverting each hunk and then found out that ret

[PATCH] Do not inline putprops function

2009-06-17 Thread M. Mohan Kumar
Do not inline putprops function With the recent kexec-tools git tree, both kexec and kdump kernels hang (i.e kexec -l and kexec -p respectively). This happened after the patch "ppc64: cleanups" commit b43a84a31a4be6ed025c1bdef3bb1c3c12e01b16. I tried reverting each hunk and then found out that ret