[PATCH] FS_ENET: Don't attempt to set mii_speed when fec_inf is null

2008-06-27 Thread Nye Liu
From: Nye Liu <[EMAIL PROTECTED]> When using CONFIG_FIXED_PHY, fec_inf (fep->phydev->bus->priv) is NULL in fs_enet/mac-fec.c restart(). Dereferencing fec_inf when trying to set the mii_speed causes a kernel oops. Signed-off-by: Nye Liu <[EMAIL PROTECTED]> --- diff --git a/drivers/net/fs_enet/ma

Re: [PATCH] FS_ENET: Don't attempt to set mii_speed when fec_inf is null

2008-06-27 Thread Nye Liu
Sorry! diff --git a/drivers/net/fs_enet/mac-fec.c b/drivers/net/fs_enet/mac-fec.c index 8a311d1..7359068 100644 --- a/drivers/net/fs_enet/mac-fec.c +++ b/drivers/net/fs_enet/mac-fec.c @@ -328,7 +328,8 @@ static void restart(struct net_device *dev) /* * Set MII speed. */ -

Re: [PATCH] FS_ENET: Don't attempt to set mii_speed when fec_inf is null

2008-06-27 Thread Sergei Shtylyov
Hello. Nye Liu wrote: From: Nye Liu <[EMAIL PROTECTED]> When using CONFIG_FIXED_PHY, fec_inf (fep->phydev->bus->priv) is NULL in fs_enet/mac-fec.c restart(). Dereferencing fec_inf when trying to set the mii_speed causes a kernel oops. Signed-off-by: Nye Liu <[EMAIL PROTECTED]> --- diff --git

[PATCH] FS_ENET: Don't attempt to set mii_speed when fec_inf is null

2008-06-27 Thread Nye Liu
From: Nye Liu <[EMAIL PROTECTED]> When using CONFIG_FIXED_PHY, fec_inf (fep->phydev->bus->priv) is NULL in fs_enet/mac-fec.c restart(). Dereferencing fec_inf when trying to set the mii_speed causes a kernel oops. Signed-off-by: Nye Liu <[EMAIL PROTECTED]> --- diff --git a/drivers/net/fs_enet/ma