Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300

2010-05-06 Thread Maindoor
Kind of working, I'll confirm this tomorrow.Was discussed earlier on ppcdev. Had to make somechange in fault handler, for this to work.  Regards,Maindoor. --- On Thu, 5/6/10, Maindoor wrote: From: Maindoor Subject: Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300 To: "Xianghua Xiao"

Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300

2010-05-06 Thread Maindoor
oes not seem to work. What if the page is brought in again due to a fault, does the attribute remain the  same ? How can I verify this ?  RegardsMaindoor. --- On Mon, 5/3/10, Xianghua Xiao wrote: From: Xianghua Xiao Subject: Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300 To: "Maindoor"

Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300

2010-05-03 Thread Benjamin Herrenschmidt
On Mon, 2010-05-03 at 09:19 -0500, Xianghua Xiao wrote: > Ok here is the test result I did this morning, in short with/without > Ben's patch it will oops if you write to a freed page. Probably lucky enough that the free_pages() is pushing the stuff out of the TLB. At least my patch prevents writi

Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300

2010-05-03 Thread Xianghua Xiao
On Sun, May 2, 2010 at 5:27 AM, Maindoor wrote: > Any updates on this ? I need something similar. > > Thanks, > Maindoor. > > --- On *Thu, 4/29/10, Benjamin Herrenschmidt *wrote: > > > From: Benjamin Herrenschmidt > Subject: Re: [PATCH] Fix DEBUG_PAGEALLOC on

Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300

2010-05-02 Thread Maindoor
Any updates on this ? I need something similar. Thanks, Maindoor. --- On Thu, 4/29/10, Benjamin Herrenschmidt wrote: From: Benjamin Herrenschmidt Subject: Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300 To: "Xianghua Xiao" Cc: "linuxppc-dev" Date: Thursday, April 29, 2010, 3

Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300

2010-04-28 Thread Benjamin Herrenschmidt
On Wed, 2010-04-28 at 14:15 -0500, Xianghua Xiao wrote: > This change works me on a 834x(e300) platform, tested with lmbench and > a production-ready application with 2.6.33.3. But have you tested that DEBUG_PAGEALLOC actually works ? :-) A way to do that is to - get_free_pages a page

Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300

2010-04-28 Thread Kim Phillips
On Wed, 28 Apr 2010 14:15:50 -0500 Xianghua Xiao wrote: > On Wed, Apr 28, 2010 at 2:22 AM, Benjamin Herrenschmidt > wrote: > > So we tried to speed things up a bit using flush_hash_pages() directly > > but that falls over on 603 of course meaning we fail to flush the TLB > > properly and we may

Re: [PATCH] Fix DEBUG_PAGEALLOC on 603/e300

2010-04-28 Thread Xianghua Xiao
On Wed, Apr 28, 2010 at 2:22 AM, Benjamin Herrenschmidt wrote: > So we tried to speed things up a bit using flush_hash_pages() directly > but that falls over on 603 of course meaning we fail to flush the TLB > properly and we may even end up having it corrupt memory randomly by > accessing a hash

[PATCH] Fix DEBUG_PAGEALLOC on 603/e300

2010-04-28 Thread Benjamin Herrenschmidt
So we tried to speed things up a bit using flush_hash_pages() directly but that falls over on 603 of course meaning we fail to flush the TLB properly and we may even end up having it corrupt memory randomly by accessing a hash table that doesn't exist. This removes the "optimization" by always goi