Re: [PATCH] Fix wrong 'no interrupt' handling in of_i2c

2008-07-16 Thread Grant Likely
On Wed, Jul 16, 2008 at 4:15 PM, Sean MacLennan <[EMAIL PROTECTED]> wrote: > On Sat, 28 Jun 2008 13:16:16 -0600 > "Grant Likely" <[EMAIL PROTECTED]> wrote: > >> On Sat, Jun 28, 2008 at 12:31 PM, Wolfram Sang >> <[EMAIL PROTECTED]> wrote: >> > If an I2C device node does not specify an interrupt, the

Re: [PATCH] Fix wrong 'no interrupt' handling in of_i2c

2008-07-16 Thread Sean MacLennan
On Sat, 28 Jun 2008 13:16:16 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: > On Sat, Jun 28, 2008 at 12:31 PM, Wolfram Sang > <[EMAIL PROTECTED]> wrote: > > If an I2C device node does not specify an interrupt, the .irq > > member of the board_info struct was set to -1. This caused crashes > > on

Re: [PATCH] Fix wrong 'no interrupt' handling in of_i2c

2008-06-28 Thread Grant Likely
On Sat, Jun 28, 2008 at 12:31 PM, Wolfram Sang <[EMAIL PROTECTED]> wrote: > If an I2C device node does not specify an interrupt, the .irq member of the > board_info struct was set to -1. This caused crashes on following > irq_dispose_mappings. Leave it NO_IRQ as returned from irq_of_parse_and_map.

[PATCH] Fix wrong 'no interrupt' handling in of_i2c

2008-06-28 Thread Wolfram Sang
If an I2C device node does not specify an interrupt, the .irq member of the board_info struct was set to -1. This caused crashes on following irq_dispose_mappings. Leave it NO_IRQ as returned from irq_of_parse_and_map. (Suggesting -1 as 'i2c-no-irq' used to be a bug in linux/i2c.h.) Signed-off-by: