Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-12 Thread Mike Mason
Michael Ellerman wrote: On Tue, 2009-02-10 at 13:12 -0800, Mike Mason wrote: I'm resubmitting this patch with a couple changes suggested by Michael Ellerman. 1) the new functions should be static, and 2) some people may object to including unrelated formating changes. =

Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-10 Thread Linas Vepstas
2009/2/10 Michael Ellerman : > On Tue, 2009-02-10 at 11:14 -0600, Linas Vepstas wrote: >> On a somewhat-related note: there was an issue (I forget >> the details) where the kernel needed to shadow some sort >> of MSI state so that it could be correctly, um, kept-track-of, >> after an EEH reset (it

Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-10 Thread Michael Ellerman
On Tue, 2009-02-10 at 13:12 -0800, Mike Mason wrote: > I'm resubmitting this patch with a couple changes > suggested by Michael Ellerman. 1) the new functions > should be static, and 2) some people may object to > including unrelated formating changes. > >

Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-10 Thread Michael Ellerman
On Tue, 2009-02-10 at 11:14 -0600, Linas Vepstas wrote: > 2009/2/9 Mike Mason : > > The EEH code disables and enables interrupts during the > > device recovery process. This is unnecessary for MSI > > and MSI-X interrupts because they are effectively disabled > > by the DMA Stopped state when an E

Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-10 Thread Mike Mason
I'm resubmitting this patch with a couple changes suggested by Michael Ellerman. 1) the new functions should be static, and 2) some people may object to including unrelated formating changes. = The EEH code disables and enables interrupts

Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-10 Thread Linas Vepstas
2009/2/9 Mike Mason : > The EEH code disables and enables interrupts during the > device recovery process. This is unnecessary for MSI > and MSI-X interrupts because they are effectively disabled > by the DMA Stopped state when an EEH error occurs. The current code is also > incorrect for MSI-X i

[PATCH] Only disable/enable LSI interrupts in EEH

2009-02-09 Thread Mike Mason
The EEH code disables and enables interrupts during the device recovery process. This is unnecessary for MSI and MSI-X interrupts because they are effectively disabled by the DMA Stopped state when an EEH error occurs. The current code is also incorrect for MSI-X interrupts. It doesn't take i