Re: [PATCH] PCI/hotplug: Remove unneeded of_node_put() in pnv_php

2021-10-20 Thread Tyrel Datwyler
On 10/20/21 4:39 AM, Nathan Lynch wrote: > Wan Jiabing writes: >> Fix following coccicheck warning: >> ./drivers/pci/hotplug/pnv_php.c:161:2-13: ERROR: probable double put. >> >> Device node iterators put the previous value of the index variable, so >> an explicit put causes a double put. > > I

Re: [PATCH] PCI/hotplug: Remove unneeded of_node_put() in pnv_php

2021-10-20 Thread Tyrel Datwyler
On 10/20/21 2:46 AM, Wan Jiabing wrote: > Fix following coccicheck warning: > ./drivers/pci/hotplug/pnv_php.c:161:2-13: ERROR: probable double put. > > Device node iterators put the previous value of the index variable, so > an explicit put causes a double put. > > Signed-off-by: Wan Jiabing

Re: [PATCH] PCI/hotplug: Remove unneeded of_node_put() in pnv_php

2021-10-20 Thread Nathan Lynch
Wan Jiabing writes: > Fix following coccicheck warning: > ./drivers/pci/hotplug/pnv_php.c:161:2-13: ERROR: probable double put. > > Device node iterators put the previous value of the index variable, so > an explicit put causes a double put. I suppose Coccinelle doesn't take into account that

[PATCH] PCI/hotplug: Remove unneeded of_node_put() in pnv_php

2021-10-20 Thread Wan Jiabing
Fix following coccicheck warning: ./drivers/pci/hotplug/pnv_php.c:161:2-13: ERROR: probable double put. Device node iterators put the previous value of the index variable, so an explicit put causes a double put. Signed-off-by: Wan Jiabing --- drivers/pci/hotplug/pnv_php.c | 1 - 1 file