Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial

2008-09-09 Thread Becky Bruce
On Sep 8, 2008, at 2:56 PM, Scott Wood wrote: Becky Bruce wrote: We're currently passing NULL, and really shouldn't be. This patch doesn't change that for cpm2, since port.dev is never initialized. :-P Signed-off-by: Becky Bruce [EMAIL PROTECTED] ---

Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial

2008-09-09 Thread Timur Tabi
On Mon, Sep 8, 2008 at 2:56 PM, Scott Wood [EMAIL PROTECTED] wrote: This patch doesn't change that for cpm2, since port.dev is never initialized. :-P I don't initialize port-dev in the UCC UART driver, but it's still non-zero, so why isn't it initialized in the CPM UART driver? (P.S. Becky -

Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial

2008-09-09 Thread Scott Wood
Timur Tabi wrote: On Mon, Sep 8, 2008 at 2:56 PM, Scott Wood [EMAIL PROTECTED] wrote: This patch doesn't change that for cpm2, since port.dev is never initialized. :-P I don't initialize port-dev in the UCC UART driver, Yes you do -- check line 1403. -Scott

Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial

2008-09-08 Thread Scott Wood
Becky Bruce wrote: We're currently passing NULL, and really shouldn't be. This patch doesn't change that for cpm2, since port.dev is never initialized. :-P Signed-off-by: Becky Bruce [EMAIL PROTECTED] --- drivers/serial/cpm_uart/cpm_uart_cpm2.c |6 +++--- drivers/serial/ucc_uart.c