Re: [PATCH] Revert powerpc: 52xx: provide a default in mpc52xx_irqhost_map()

2013-10-02 Thread Sebastian Andrzej Siewior
On 10/01/2013 09:03 PM, Wolfram Sang wrote: Yup. But I just remembered a better solution: From: Wolfram Sang w...@the-dreams.de Subject: [PATCH] ppc: mpc52xx: silence false positive from old GCC So people can compile with -Werror. Signed-off-by: Wolfram Sang w...@the-dreams.de ---

[PATCH] Revert powerpc: 52xx: provide a default in mpc52xx_irqhost_map()

2013-10-01 Thread Wolfram Sang
This reverts commit 6391f697d4892a6f233501beea553e13f7745a23. The compiler warning it wants to fix does not appear with my gcc 4.6.2. IMO we don't need superfluous (and here even misleading) code to make old compilers happy. Fixing the printout was bogus, too. We want to know WHICH critical irq

Re: [PATCH] Revert powerpc: 52xx: provide a default in mpc52xx_irqhost_map()

2013-10-01 Thread Sebastian Andrzej Siewior
On 10/01/2013 09:26 AM, Wolfram Sang wrote: This reverts commit 6391f697d4892a6f233501beea553e13f7745a23. The compiler warning it wants to fix does not appear with my gcc 4.6.2. IMO we don't need superfluous (and here even misleading) code to make old compilers happy. Fixing the printout was

Re: [PATCH] Revert powerpc: 52xx: provide a default in mpc52xx_irqhost_map()

2013-10-01 Thread Wolfram Sang
Hi, On Tue, Oct 01, 2013 at 09:54:51AM +0200, Sebastian Andrzej Siewior wrote: On 10/01/2013 09:26 AM, Wolfram Sang wrote: This reverts commit 6391f697d4892a6f233501beea553e13f7745a23. The compiler warning it wants to fix does not appear with my gcc 4.6.2. IMO we don't need superfluous

Re: [PATCH] Revert powerpc: 52xx: provide a default in mpc52xx_irqhost_map()

2013-10-01 Thread Sebastian Andrzej Siewior
On 10/01/2013 11:11 AM, Wolfram Sang wrote: Hi, Hi Wolfram, Well, if you insist, I'd prefer the following patch. From: Wolfram Sang w...@the-dreams.de Subject: [PATCH] ppc: mpc52xx: silence false positive from old GCC So people can compile with -Werror (RT patchset). Why do you mention

Re: [PATCH] Revert powerpc: 52xx: provide a default in mpc52xx_irqhost_map()

2013-10-01 Thread Wolfram Sang
So people can compile with -Werror (RT patchset). Why do you mention the RT patch set here? Doesn't the vanila tree gets compiled with -Werror as well? Not for me. irq_chip *irqchip = NULL; /* pet old compilers */ That would probably work, too. I would drop that comment but then