Hi Sascha,
One small comment.
On Thu, 24 Apr 2008 17:36:59 +0200 Sascha Hauer [EMAIL PROTECTED] wrote:
+#include asm/of_platform.h
Never include asm/of_platform.h, use linux/of_platform.h
+static struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
const, please.
OK, I lied about only
On Thu, Apr 24, 2008 at 12:45:49PM -0600, Grant Likely wrote:
On Thu, Apr 24, 2008 at 9:36 AM, Sascha Hauer [EMAIL PROTECTED] wrote:
Hi all,
Feel free to comment on this.
Sascha
This patch adds gpiolib support for mpc5200 SOCs. I'm not sure
whether it's a good idea to make
This patch adds gpiolib support for mpc5200 SOCs.
Changes since last submit:
- fixed checkpatch warnings
- use shadow variables for register accesses
- make match tables const
- Add documentation
Signed-off-by: Sascha Hauer [EMAIL PROTECTED]
---
On Fri, Apr 25, 2008 at 12:53:33PM +0200, Sascha Hauer wrote:
[...]
As for the wide spans caused by gpt gpios, it is probably okay for
now, but we can rework it to do something clever (like have a single
registration for all gpt gpios) at a later date.
I would rather teach the of gpio
On Thu, Apr 24, 2008 at 05:36:59PM +0200, Sascha Hauer wrote:
+#include linux/of.h
+#include linux/kernel.h
+#include linux/of_gpio.h
+#include linux/io.h
+#include asm/of_platform.h
+#include asm/prom.h
+#include asm/gpio.h
In the latest kernels the preferred way is to include
Can I make a suggestion for this chip support?
On certain 5200 boards these devices are not usable since they are not
connected. My concern is the Efika where we only have 2 wakeup and 1 simple
GPIO available on the board and maybe a few others with a bit of tweaking
and messing around.
Instead
On Fri, Apr 25, 2008 at 04:30:55PM +0100, Matt Sealey wrote:
Can I make a suggestion for this chip support?
On certain 5200 boards these devices are not usable since they are not
connected. My concern is the Efika where we only have 2 wakeup and 1 simple
GPIO available on the board and maybe
On Fri, Apr 25, 2008 at 12:51 PM, Sascha Hauer [EMAIL PROTECTED] wrote:
On Fri, Apr 25, 2008 at 04:30:55PM +0100, Matt Sealey wrote:
Can I make a suggestion for this chip support?
On certain 5200 boards these devices are not usable since they are not
connected. My concern is the Efika
Hi all,
Feel free to comment on this.
Sascha
This patch adds gpiolib support for mpc5200 SOCs. I'm not sure
whether it's a good idea to make this optional via kconfig.
The gpt devices only support a single gpio. In the current of_gpio
implementation each chip consumes 32 GPIOs which leads to
On Thu, Apr 24, 2008 at 9:36 AM, Sascha Hauer [EMAIL PROTECTED] wrote:
Hi all,
Feel free to comment on this.
Sascha
This patch adds gpiolib support for mpc5200 SOCs. I'm not sure
whether it's a good idea to make this optional via kconfig.
The gpt devices only support a single gpio.
10 matches
Mail list logo
