Re: [PATCH] arch/powerpc/platforms/52xx/efika.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Sat, Sep 04, 2010 at 09:13:17AM +0200, Julia Lawall wrote: > This function is implemented as though the function of_get_next_child does > not increment the reference count of its result, but actually it does. > Thus the patch adds of_node_put in error handling code and drops a call to > of_node_

[PATCH] arch/powerpc/platforms/52xx/efika.c: Add of_node_put to avoid memory leak

2010-09-04 Thread Julia Lawall
This function is implemented as though the function of_get_next_child does not increment the reference count of its result, but actually it does. Thus the patch adds of_node_put in error handling code and drops a call to of_node_get. The semantic match that finds this problem is as follows: (http: