Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

2014-12-22 Thread Michael Ellerman
On Mon, 2014-12-22 at 18:44 -0800, Geoff Levand wrote: > Hi Michael, > > On Tue, 2014-12-23 at 11:26 +1100, Michael Ellerman wrote: > > On Mon, 2014-12-22 at 09:26 -0800, Geoff Levand wrote: > > > ps3_repository_write_highmem_info() is needed by otheros++. What we > > > need is a kernel patch to

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

2014-12-22 Thread Geoff Levand
Hi Michael, On Tue, 2014-12-23 at 11:26 +1100, Michael Ellerman wrote: > On Mon, 2014-12-22 at 09:26 -0800, Geoff Levand wrote: > > ps3_repository_write_highmem_info() is needed by otheros++. What we > > need is a kernel patch to add the highmem info to the repository once it > > is known. > > O

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

2014-12-22 Thread Michael Ellerman
On Mon, 2014-12-22 at 09:26 -0800, Geoff Levand wrote: > On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote: > > Remove the function ps3_repository_write_highmem_info() that is not used > > anywhere. > > NAK > > ps3_repository_write_highmem_info() is needed by otheros++. What we > nee

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

2014-12-22 Thread Rickard Strandqvist
2014-12-22 18:36 GMT+01:00 Nathan Whitehorn : > > On 12/22/14 09:26, Geoff Levand wrote: >> >> On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote: >>> >>> Remove the function ps3_repository_write_highmem_info() that is not used >>> anywhere. >> >> NAK >> >> ps3_repository_write_highmem_in

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

2014-12-22 Thread Nathan Whitehorn
On 12/22/14 09:26, Geoff Levand wrote: On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote: Remove the function ps3_repository_write_highmem_info() that is not used anywhere. NAK ps3_repository_write_highmem_info() is needed by otheros++. What we need is a kernel patch to add the h

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

2014-12-22 Thread Geoff Levand
On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote: > Remove the function ps3_repository_write_highmem_info() that is not used > anywhere. NAK ps3_repository_write_highmem_info() is needed by otheros++. What we need is a kernel patch to add the highmem info to the repository once it i

[PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

2014-12-20 Thread Rickard Strandqvist
Remove the function ps3_repository_write_highmem_info() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/platforms/ps3/platform.h |2 -- arch/powerpc/platforms/ps3/repository.