Re: [PATCH] cardbus: Add a fixup hook and fix powerpc

2009-12-16 Thread Jesse Barnes
On Wed, 09 Dec 2009 17:52:13 +1100 Benjamin Herrenschmidt wrote: > The cardbus code creates PCI devices without ever going through the > necessary fixup bits and pieces that normal PCI devices go through. > > There's in fact a commented out call to pcibios_fixup_bus() in there, > it's commented

Re: [PATCH] cardbus: Add a fixup hook and fix powerpc

2009-12-16 Thread Benjamin Herrenschmidt
On Wed, 2009-12-16 at 14:01 -0800, Jesse Barnes wrote: > > Olof, once that's in you should be able to remove the hack you have in > > the PA-Semi code to work around this. > > > > Oops, looks like this fails for the modular case? I get an unresolved > symbol error when building this with my def

Re: [PATCH] cardbus: Add a fixup hook and fix powerpc

2009-12-16 Thread Jesse Barnes
On Wed, 09 Dec 2009 17:52:13 +1100 Benjamin Herrenschmidt wrote: > The cardbus code creates PCI devices without ever going through the > necessary fixup bits and pieces that normal PCI devices go through. > > There's in fact a commented out call to pcibios_fixup_bus() in there, > it's commented

Re: [PATCH] cardbus: Add a fixup hook and fix powerpc

2009-12-16 Thread Jesse Barnes
On Wed, 09 Dec 2009 17:52:13 +1100 Benjamin Herrenschmidt wrote: > The cardbus code creates PCI devices without ever going through the > necessary fixup bits and pieces that normal PCI devices go through. > > There's in fact a commented out call to pcibios_fixup_bus() in there, > it's commented

Re: [PATCH] cardbus: Add a fixup hook and fix powerpc

2009-12-09 Thread Benjamin Herrenschmidt
On Wed, 2009-12-09 at 22:37 +0100, Dominik Brodowski wrote: > Acked-by: Dominik Brodowski (for PCMCIA) > > > Note: In the long run we might want to streamline the hooks for fixing > > up new devices vs. new busses and make some stuff common between cardbus > > and PCI hotplug which is actually a

Re: [PATCH] cardbus: Add a fixup hook and fix powerpc

2009-12-09 Thread Dominik Brodowski
Hey Benjamin, On Wed, Dec 09, 2009 at 05:52:13PM +1100, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Acked-by: Dominik Brodowski (for PCMCIA) > Note: In the long run we might want to streamline the hooks for fixing > up new devices vs. new busses and make some stuff com

[PATCH] cardbus: Add a fixup hook and fix powerpc

2009-12-08 Thread Benjamin Herrenschmidt
The cardbus code creates PCI devices without ever going through the necessary fixup bits and pieces that normal PCI devices go through. There's in fact a commented out call to pcibios_fixup_bus() in there, it's commented because ... it doesn't work. I could make pcibios_fixup_bus() do the right t