Re: [PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-27 Thread christophe lombard
Le 27/11/2017 à 05:03, Michael Ellerman a écrit : christophe lombard writes: Le 24/11/2017 à 14:02, Benjamin Herrenschmidt a écrit : On Fri, 2017-11-24 at 11:14 +0100, christophe lombard wrote: To my knowledge, there is no property (or similar), somewhere, that indicating that the TIDR is su

Re: [PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-26 Thread Michael Ellerman
christophe lombard writes: > Le 24/11/2017 à 14:02, Benjamin Herrenschmidt a écrit : >> On Fri, 2017-11-24 at 11:14 +0100, christophe lombard wrote: >>> To my knowledge, there is no property (or similar), somewhere, that >>> indicating that the TIDR is supported or not. >>> For the time being, if

Re: [PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-24 Thread Benjamin Herrenschmidt
On Fri, 2017-11-24 at 17:37 +0100, christophe lombard wrote: > You are right. We will insert a checking in the cxl driver to allow > updating the TIDR if a P9 is present. This will be in the patch V2. > Thanks Best is to actually: 1) Add something to the device-tree in skiboot (and work with pHy

Re: [PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-24 Thread christophe lombard
Le 24/11/2017 à 14:02, Benjamin Herrenschmidt a écrit : On Fri, 2017-11-24 at 11:14 +0100, christophe lombard wrote: To my knowledge, there is no property (or similar), somewhere, that indicating that the TIDR is supported or not. For the time being, if I am not wrong, the only check we have, is

Re: [PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-24 Thread Benjamin Herrenschmidt
On Fri, 2017-11-24 at 11:14 +0100, christophe lombard wrote: > To my knowledge, there is no property (or similar), somewhere, that > indicating that the TIDR is supported or not. > For the time being, if I am not wrong, the only check we have, is > this condition in the function set_thread_tidr(str

Re: [PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-24 Thread christophe lombard
Le 23/11/2017 à 21:41, Benjamin Herrenschmidt a écrit : On Thu, 2017-11-23 at 12:05 +0100, Christophe Lombard wrote: The POWER9 core supports a new feature: ASB_Notify which requires the support of the Special Purpose Register: TIDR. The ASB_Notify command, generated by the AFU, will attempt to

Re: [PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-23 Thread Benjamin Herrenschmidt
On Thu, 2017-11-23 at 12:05 +0100, Christophe Lombard wrote: > The POWER9 core supports a new feature: ASB_Notify which requires the > support of the Special Purpose Register: TIDR. > > The ASB_Notify command, generated by the AFU, will attempt to > wake-up the host thread identified by the partic

Re: [PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-23 Thread christophe lombard
Le 23/11/2017 à 15:16, Vaibhav Jain a écrit : Hi Christophe, Few review comments: Christophe Lombard writes: + +int cxl_context_thread_tidr(struct cxl_context *ctx, int assign) +{ + int rc = 0; + + /* Clear any TIDR value assigned to the current thread */ + if (!assign) { +

Re: [PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-23 Thread Vaibhav Jain
Hi Christophe, Few review comments: Christophe Lombard writes: > + > +int cxl_context_thread_tidr(struct cxl_context *ctx, int assign) > +{ > + int rc = 0; > + > + /* Clear any TIDR value assigned to the current thread */ > + if (!assign) { > + clear_thread_tidr(current);

[PATCH] cxl: Add support for ASB_Notify on POWER9

2017-11-23 Thread Christophe Lombard
The POWER9 core supports a new feature: ASB_Notify which requires the support of the Special Purpose Register: TIDR. The ASB_Notify command, generated by the AFU, will attempt to wake-up the host thread identified by the particular LPID:PID:TID. This patch assign a unique TIDR (thread id) for the