Re: [PATCH] cxl: Fix an error message

2021-05-14 Thread Greg KH
On Wed, May 05, 2021 at 09:38:49PM +0200, Christophe JAILLET wrote: > 'rc' is known to be 0 here. > Initialize 'rc' with the expected error code before using it. > > While at it, avoid the affectation of 'rc' in a 'if' to make things more > obvious and linux style. > > Fixes: f204e0b8ce ("cxl: Dr

Re: [PATCH] cxl: Fix an error message

2021-05-05 Thread Andrew Donnellan
On 6/5/21 5:38 am, Christophe JAILLET wrote: 'rc' is known to be 0 here. Initialize 'rc' with the expected error code before using it. I would prefer: "In cxl_add_chardev(), if the call to device_create() fails, we print the error message before 'rc' is set correctly, and therefore always pr

[PATCH] cxl: Fix an error message

2021-05-05 Thread Christophe JAILLET
'rc' is known to be 0 here. Initialize 'rc' with the expected error code before using it. While at it, avoid the affectation of 'rc' in a 'if' to make things more obvious and linux style. Fixes: f204e0b8ce ("cxl: Driver code for powernv PCIe based cards for userspace access") Signed-off-by: Chri