Re: [PATCH] cxl: Set up and enable PSL Timebase

2015-06-01 Thread Michael Neuling
On Thu, 2015-05-28 at 15:12 +0200, Philippe Bergheaud wrote: This patch configures the PSL Timebase function and enables it, after the CAPP has been initialized by OPAL. Failures are reported and ignored. Needs an Signed-off-by. Comments inline. --- drivers/misc/cxl/cxl.h |5 +

Re: [PATCH] cxl: Set up and enable PSL Timebase

2015-06-01 Thread Michael Neuling
On Mon, 2015-06-01 at 09:37 +0200, Philippe Bergheaud wrote: Michael Neuling wrote: On Thu, 2015-05-28 at 15:12 +0200, Philippe Bergheaud wrote: This patch configures the PSL Timebase function and enables it, after the CAPP has been initialized by OPAL. Failures are reported and ignored.

Re: [PATCH] cxl: Set up and enable PSL Timebase

2015-06-01 Thread Philippe Bergheaud
Michael Neuling wrote: On Mon, 2015-06-01 at 09:37 +0200, Philippe Bergheaud wrote: Michael Neuling wrote: On Thu, 2015-05-28 at 15:12 +0200, Philippe Bergheaud wrote: This patch configures the PSL Timebase function and enables it, after the CAPP has been initialized by OPAL. Failures are

Re: [PATCH] cxl: Set up and enable PSL Timebase

2015-06-01 Thread Philippe Bergheaud
Michael Neuling wrote: On Thu, 2015-05-28 at 15:12 +0200, Philippe Bergheaud wrote: This patch configures the PSL Timebase function and enables it, after the CAPP has been initialized by OPAL. Failures are reported and ignored. Needs an Signed-off-by. Yes. Comments inline. ---

Re: [PATCH] cxl: Set up and enable PSL Timebase

2015-06-01 Thread Philippe Bergheaud
Michael Neuling wrote: Please use negative error codes here. -EIO? And check it here. Mikey, I am reluctant to fail the entire CAPI init after a PSL timebase sync failure. If we ignore the error, the CAPI device stays available (without timebase sync). If we honour the error, the CAPI device

Re: [PATCH] cxl: Set up and enable PSL Timebase

2015-06-01 Thread Michael Neuling
On Mon, 2015-06-01 at 15:56 +0200, Philippe Bergheaud wrote: Michael Neuling wrote: Please use negative error codes here. -EIO? And check it here. Mikey, I am reluctant to fail the entire CAPI init after a PSL timebase sync failure. If we ignore the error, the CAPI device stays

[PATCH] cxl: Set up and enable PSL Timebase

2015-05-28 Thread Philippe Bergheaud
This patch configures the PSL Timebase function and enables it, after the CAPP has been initialized by OPAL. Failures are reported and ignored. --- drivers/misc/cxl/cxl.h |5 + drivers/misc/cxl/pci.c | 35 +++ 2 files changed, 40 insertions(+), 0