Re: [PATCH] device_attributes: add sysfs_attr_init() for dynamic attributes

2010-04-10 Thread Mike Isely
Acked-By: Mike Isely (in the context of the pvrusb2 driver related changes) -Mike On Mon, 22 Mar 2010, Wolfram Sang wrote: > Made necessary by 6992f5334995af474c2b58d010d08bc597f0f2fe. > > Found by this semantic patch: > > @ init @ > type T; > identifier A; > @@ > > T { >

Re: [PATCH] device_attributes: add sysfs_attr_init() for dynamic attributes

2010-04-10 Thread Mauro Carvalho Chehab
Mike Isely wrote: > Acked-By: Mike Isely > > (in the context of the pvrusb2 driver related changes) Acked-by: Mauro Carvalho Chehab > > -Mike > > On Mon, 22 Mar 2010, Wolfram Sang wrote: > >> Made necessary by 6992f5334995af474c2b58d010d08bc597f0f2fe. >> >> Found by this semantic patch: >>

Re: [PATCH] device_attributes: add sysfs_attr_init() for dynamic attributes

2010-03-22 Thread Wolfram Sang
On Sun, Mar 21, 2010 at 11:40:28PM -0700, Dmitry Torokhov wrote: > My standard question - are all of these need to be dynamically > allocated? I have my doubts for a few of them. Still, this would be a more intrusive change than just fixing the BUG appearance, so I'd like to leave that task for t

Re: [PATCH] device_attributes: add sysfs_attr_init() for dynamic attributes

2010-03-21 Thread Dmitry Torokhov
Hi Wolfram, On Mon, Mar 22, 2010 at 07:21:17AM +0100, Wolfram Sang wrote: > Made necessary by 6992f5334995af474c2b58d010d08bc597f0f2fe. > > Found by this semantic patch: > > @ init @ > type T; > identifier A; > @@ > > T { > ... > struct device_attribute A

[PATCH] device_attributes: add sysfs_attr_init() for dynamic attributes

2010-03-21 Thread Wolfram Sang
Made necessary by 6992f5334995af474c2b58d010d08bc597f0f2fe. Found by this semantic patch: @ init @ type T; identifier A; @@ T { ... struct device_attribute A; ... }; @ main extends init @ expression E; statement S; identifier err;