Re: [PATCH] drivers/crypto/nx: prevent oops on module exit

2014-10-17 Thread Seth Jennings
On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote: On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote: Check old_devdata-dev in nx-842 driver before accessing it, as on systems without any nx-842 hardware, the -dev will never be set. Currently, the module will cause an oops

Re: [PATCH] drivers/crypto/nx: prevent oops on module exit

2014-10-17 Thread Seth Jennings
On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote: On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote: Check old_devdata-dev in nx-842 driver before accessing it, as on systems without any nx-842 hardware, the -dev will never be set. Currently, the module will cause an oops

Re: [PATCH] drivers/crypto/nx: prevent oops on module exit

2014-10-17 Thread Dan Streetman
Yep, I own the driver now, I'll send a maintainers patch. On Thu, Oct 16, 2014 at 6:52 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote: On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote: Check old_devdata-dev in nx-842

[PATCH] drivers/crypto/nx: prevent oops on module exit

2014-10-16 Thread Dan Streetman
Check old_devdata-dev in nx-842 driver before accessing it, as on systems without any nx-842 hardware, the -dev will never be set. Currently, the module will cause an oops during unload since old_devdata-dev is null. Signed-off-by: Dan Streetman ddstr...@ieee.org --- Also Seth and Rob, you guys

Re: [PATCH] drivers/crypto/nx: prevent oops on module exit

2014-10-16 Thread Michael Ellerman
On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote: Check old_devdata-dev in nx-842 driver before accessing it, as on systems without any nx-842 hardware, the -dev will never be set. Currently, the module will cause an oops during unload since old_devdata-dev is null. Hi Dan, Patch

Re: [PATCH] drivers/crypto/nx: prevent oops on module exit

2014-10-16 Thread Benjamin Herrenschmidt
On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote: On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote: Check old_devdata-dev in nx-842 driver before accessing it, as on systems without any nx-842 hardware, the -dev will never be set. Currently, the module will cause an oops