[PATCH] eHEA: Don't do memory allocation under lock if not necessary

2009-03-11 Thread David Howells
In ehea_probe_adapter() the initial memory allocation and initialisation does not need to be done with the ehea_fw_handles.lock semaphore held. Doing so extends the amount of time the lock is held unnecessarily. Signed-off-by: David Howells dhowe...@redhat.com --- drivers/net/ehea/ehea_main.c

Re: [PATCH] eHEA: Don't do memory allocation under lock if not necessary

2009-03-11 Thread Jan-Bernd Themann
Hi David, thanks for your patch. Coincidentally we have been working on a patch that does some locking rework and also touches this particular lock. So your patch finnally won't be required anymore. Thanks anyway for trying to improve the eHEA driver! I'm going to post our patch later today.

Re: [PATCH] eHEA: Don't do memory allocation under lock if not necessary

2009-03-10 Thread Benjamin Herrenschmidt
On Mon, 2009-03-09 at 16:36 +, David Howells wrote: In ehea_probe_adapter() the initial memory allocation and initialisation does not need to be done with the ehea_fw_handles.lock semaphore held. Doing so extends the amount of time the lock is held unnecessarily. Can you resend with

[PATCH] eHEA: Don't do memory allocation under lock if not necessary

2009-03-09 Thread David Howells
In ehea_probe_adapter() the initial memory allocation and initialisation does not need to be done with the ehea_fw_handles.lock semaphore held. Doing so extends the amount of time the lock is held unnecessarily. Signed-off-by: David Howells dhowe...@redhat.com --- drivers/net/ehea/ehea_main.c