Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-29 Thread Johannes Berg
> OK then let's play safe and don't touch fountains at all. How about the > patch below? Looks fine to me, works with my fountain touchpad and should fix Joseph's error too. > Input: appletouch - idle reset logic broke older Fountains > > Fountains do not support change mode request and theref

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-28 Thread Dmitry Torokhov
On Sunday 28 October 2007 11:08, Johannes Berg wrote: > > > I was hoping that FOUNTAIN_TP_ONLY_PRODUCT_ID (0x30A) behaves similar > > to Geyser in this regard. If you know that this assumption is incorrect > > then we need to rename atp_is_older_fountain() to atp_is_fountain() > > anf add this pro

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-28 Thread Johannes Berg
> I was hoping that FOUNTAIN_TP_ONLY_PRODUCT_ID (0x30A) behaves similar > to Geyser in this regard. If you know that this assumption is incorrect > then we need to rename atp_is_older_fountain() to atp_is_fountain() > anf add this product ID to it. Ah ok, I forgot about that one. If I were to ven

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-28 Thread Dmitry Torokhov
On Sunday 28 October 2007, Johannes Berg wrote: > > > OK, then maybe instead of reverting the change outright we could try the > > patch below? > > That patch works, Any chance Benjamin could also test it? The behaviour is different from 2.6.24-rc1 since we call atp_geyser_init for all geysers n

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-28 Thread Johannes Berg
> OK, then maybe instead of reverting the change outright we could try the > patch below? That patch works, minor comments: > Older models of fountains do not support change mode request and I think there's only one fountain model. > therefore shoudl be excluded from idle reset attempts. typo

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-27 Thread Dmitry Torokhov
On Friday 26 October 2007 16:31, Johannes Berg wrote: > > > Johannes, and what is product ID for your touchpad? > > It's 0x20e, listed as 'fountain' > OK, then maybe instead of reverting the change outright we could try the patch below? -- Dmitry Input: appletouch - idle reset logic broke old

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-26 Thread Johannes Berg
> Johannes, and what is product ID for your touchpad? It's 0x20e, listed as 'fountain' johannes signature.asc Description: This is a digitally signed message part ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listi

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-26 Thread Dmitry Torokhov
On 10/25/07, Benjamin Berg <[EMAIL PROTECTED]> wrote: > On Thu, 2007-25-10 at 15:23 +0200, Johannes Berg wrote: > > On Wed, 2007-10-24 at 10:29 -0400, Dmitry Torokhov wrote: > > > > > Do yo know who has powerbooks with older geyser models (0x214, 215, > > > 216)? > > > > Not sure, Benjamin? We're t

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-25 Thread Benjamin Berg
On Thu, 2007-25-10 at 15:23 +0200, Johannes Berg wrote: > On Wed, 2007-10-24 at 10:29 -0400, Dmitry Torokhov wrote: > > > Do yo know who has powerbooks with older geyser models (0x214, 215, > > 216)? > > Not sure, Benjamin? We're talking about the touchpad, just lsusb should > be enough. lsusb

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-25 Thread Johannes Berg
On Wed, 2007-10-24 at 10:29 -0400, Dmitry Torokhov wrote: > Do yo know who has powerbooks with older geyser models (0x214, 215, > 216)? Not sure, Benjamin? We're talking about the touchpad, just lsusb should be enough. > It would be nice to know if they send the data continiously and > whether

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Dmitry Torokhov
On 10/24/07, Johannes Berg <[EMAIL PROTECTED]> wrote: > On Wed, 2007-10-24 at 09:34 -0400, Dmitry Torokhov wrote: > > > Well, but what about fountains then? Regardless of the model, if there > > is a way to stop "empty" meaurements, we should do it. > > There is no way on fountains though. We could

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Johannes Berg
On Wed, 2007-10-24 at 09:34 -0400, Dmitry Torokhov wrote: > Well, but what about fountains then? Regardless of the model, if there > is a way to stop "empty" meaurements, we should do it. There is no way on fountains though. We could check the measurement ourselves and if no finger is detected de

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Dmitry Torokhov
On 10/24/07, Johannes Berg <[EMAIL PROTECTED]> wrote: > Hi, > > > My fault, sorry. > > No, actually, I was wrong about Geyser 1, mine is a fountain. > > > Is there a way to "plug" these Geysers? Waking up the kernel > > continuously is not nice. > > Not sure really, maybe checking for is_geyser ins

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Johannes Berg
Hi, > My fault, sorry. No, actually, I was wrong about Geyser 1, mine is a fountain. > Is there a way to "plug" these Geysers? Waking up the kernel > continuously is not nice. Not sure really, maybe checking for is_geyser instead of is_geyser_3? johannes signature.asc Description: This is a

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Johannes Berg
On Wed, 2007-10-24 at 12:44 +0200, Johannes Berg wrote: > The patch 46249ea60fbb61a72ee6929b831b1f3e6865f024 was obviously done > without testing on a Geyser 1, and I'm a very annoyed that it was > applied. It causes appletouch to continuously printk: I spoke too soon, I don't have a Geyser 1 but

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Dmitry Torokhov
Hi Johannes, On 10/24/07, Johannes Berg <[EMAIL PROTECTED]> wrote: > The patch 46249ea60fbb61a72ee6929b831b1f3e6865f024 was obviously done > without testing on a Geyser 1, My fault, sorry. However Anton's device has product ID of 90x30B which is Geyser 1 as far as I understand... But yes, we shou

[PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Johannes Berg
The patch 46249ea60fbb61a72ee6929b831b1f3e6865f024 was obviously done without testing on a Geyser 1, and I'm a very annoyed that it was applied. It causes appletouch to continuously printk: drivers/input/mouse/appletouch.c: Could not do mode read request from device (Geyser 3 mode) because the G