Re: [PATCH] fix compile failure with non modular builds

2008-09-10 Thread Stephen Rothwell
On Wed, 10 Sep 2008 10:46:39 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > I must admit that none of my test configs I think has module support > turned off (even if I tend to have all the stuff I need built-in). And our allnoconfig turns off CONFIG_64BIT, so we didn't see it in any

Re: [PATCH] fix compile failure with non modular builds

2008-09-09 Thread Benjamin Herrenschmidt
On Tue, 2008-09-09 at 19:11 -0500, James Bottomley wrote: > On Wed, 2008-09-10 at 10:09 +1000, Benjamin Herrenschmidt wrote: > > On Tue, 2008-09-09 at 19:04 -0500, James Bottomley wrote: > > > commit deac93df26b20cf8438339b5935b5f5643bc30c9 > > > Author: James Bottomley <[EMAIL PROTECTED]> > > > Da

Re: [PATCH] fix compile failure with non modular builds

2008-09-09 Thread James Bottomley
On Wed, 2008-09-10 at 10:09 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2008-09-09 at 19:04 -0500, James Bottomley wrote: > > commit deac93df26b20cf8438339b5935b5f5643bc30c9 > > Author: James Bottomley <[EMAIL PROTECTED]> > > Date: Wed Sep 3 20:43:36 2008 -0500 > > > > lib: Correct printk

Re: [PATCH] fix compile failure with non modular builds

2008-09-09 Thread Benjamin Herrenschmidt
On Tue, 2008-09-09 at 19:04 -0500, James Bottomley wrote: > commit deac93df26b20cf8438339b5935b5f5643bc30c9 > Author: James Bottomley <[EMAIL PROTECTED]> > Date: Wed Sep 3 20:43:36 2008 -0500 > > lib: Correct printk %pF to work on all architectures > > Broke the non modular builds by moving

[PATCH] fix compile failure with non modular builds

2008-09-09 Thread James Bottomley
commit deac93df26b20cf8438339b5935b5f5643bc30c9 Author: James Bottomley <[EMAIL PROTECTED]> Date: Wed Sep 3 20:43:36 2008 -0500 lib: Correct printk %pF to work on all architectures Broke the non modular builds by moving an essential function into modules.c. Fix this by moving it out again